Repository navigation
Commit a8a3bfe
committed
fix(release): ship the corrected HA floor in a tag, not just on main
5.2.0 declared "homeassistant": "2023.1.0" in hacs.json, which is the key HACS
gates installation on: a user on 2023.1-2024.3 was allowed to install the
integration and only then hit an ImportError, because config_flow.py imports
ConfigFlowResult and HA added that symbol in 2024.4.
The previous commit corrected hacs.json on main, which does not reach anyone.
HACS reads hacs.json at the version it is considering, not from the default
branch -- version_to_download() resolves to the latest release tag and
async_get_hacs_json() fetches the file at that ref -- so the value that
actually gates an install is the one inside the tag. Confirmed against the
published files: main/hacs.json says 2024.4.0 while v5.2.0/hacs.json still
said 2023.1.0.
This patch release carries the correction inside the tag. Bumping
manifest.json to 5.2.1 in the same release is not decoration: HACS compares the
installed manifest version against the tag, so without the bump an existing
5.2.0 install would have no reason to re-fetch and would keep the bad gate.1 parent 6472fd3 commit a8a3bfe
2 files changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
138 | 147 | | |
139 | 148 | | |
140 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
0 commit comments