Variable-sized Coin serialization - #2373
Open
sisou wants to merge 6 commits into
Open
Conversation
hrxi
approved these changes
May 1, 2024
hrxi
left a comment
Contributor
There was a problem hiding this comment.
Looks like a good improvement to me.
sisou
force-pushed
the
soeren/variable-size-coin
branch
from
August 23, 2024 10:15
fc78f99 to
aa4382b
Compare
sisou
marked this pull request as ready for review
August 23, 2024 10:16
To de/serialize Coins to big-endian fixint for backwards-compatible vesting contract creation data.
Use the mirror function of `u64::from_be_bytes`, which is used when reading it.
sisou
force-pushed
the
soeren/variable-size-coin
branch
from
November 5, 2024 08:05
8d391d9 to
c12d921
Compare
Contributor
|
I think we decided not to do that because it's a breaking change. Is that correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This PR makes
Coinserialize to a varint in transactions and accounts, both over the wire and their internal representations (history store).Reasoning
No transaction will likely ever make use of the full u64 range for its
value, and especially not forfee. So most zero bytes for Coins in most transactions are wasted. This is especially true for signaling transactions, which have 16 zero-bytes to represent 0 value and (mostly) 0 fee. This PR reduces them to two zero bytes.Drawbacks
Exceptions
There are two exceptions for backwards-compatibility with PoW transactions:
fixint::betx.serialize_content()serializesvalueandfeeas before withfixint::bePull request checklist
clippyandrustfmtwarnings.