BugFix: Fix elixir_make (Mix NIF) dependency autopatch (#1054) - #1055
Open
artman41 wants to merge 4 commits into
Open
BugFix: Fix elixir_make (Mix NIF) dependency autopatch (#1054)#1055artman41 wants to merge 4 commits into
artman41 wants to merge 4 commits into
Conversation
…as no test coverage. Add core-elixir-nif-elixir-make, which builds Exqlite for real and verifies its NIF actually loads.
…irectly onto the make target with no space, producing a nonexistent elixir_make.mkall target. Insert the missing space between the -f path and the make targets/args.
…IR/ERL_EI_LIBDIR, which Mix normally injects automatically but erlang.mk never set. Export all four as computed env vars before invoking the dependency's build recipe.
…r_make dependencies' sources a second time without the right flags, clobbering the correct build. Point C_SRC_DIR at a nonexistent path for elixir_make deps so the generic auto-build no-ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1054
To be upfront: Claude Found and Fixed this while I was having it scaffold a project.
This MR is a reimplementation of the fixes the AI made on my local repo.
I've taken a look over the code & test and it seems good.
Happy to reduce the comments in the tests if you think they're excessive