Repository navigation
Commit 8189dd0
Stop asserting compaction the CI runner cannot see
The growth guard has now turned main red twice trying to hold the chunk fill
rate: first against a fixed 25% floor, then against a 1.5x ratio between an
autoCompact-on and an autoCompact-off run of the same workload. Locally the two
halves are 37% against 18-21%. On the GitHub runners they come out within noise
of each other and in either order - 16 against 18 on macOS, 31 against 34 on
Windows - with the fix present and working. So it is not a threshold that was
mis-calibrated and not contention squeezing one half harder than the other:
background compaction's effect on the fill rate is simply not observable there,
and I do not know why.
What is left is the close, which compacts synchronously and owes nothing to a
thread being scheduled: with compaction on the file comes back to its live size,
and the control run with it off must be left larger than its live data, so a
control that reclaimed anyway cannot quietly turn this into a comparison of a
thing against itself. Reverting the close path fails it at 258048 bytes against
69632.
That leaves the background half of the fix - dropping autoCompactFillRate(0),
which is what bounds the file while a long-running application is writing -
unguarded, and the javadoc says so rather than implying the test covers it.
Guarding it would mean guarding something the runner cannot see, which is what
the last two commits were.
Also drops NitriteMVStore.getMvStore(), added for the fill rate reading that no
longer happens.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 3e9a61d commit 8189dd0
2 files changed
Lines changed: 21 additions & 40 deletions
File tree
- nitrite-mvstore-adapter/src
- main/java/org/dizitart/no2/mvstore
- test/java/org/dizitart/no2/mvstore
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | 240 | | |
251 | 241 | | |
252 | 242 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
| 50 | + | |
| 51 | + | |
52 | 52 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
58 | 63 | | |
59 | | - | |
60 | | - | |
61 | 64 | | |
62 | 65 | | |
63 | 66 | | |
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
70 | 73 | | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | 74 | | |
79 | 75 | | |
80 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
81 | 79 | | |
82 | 80 | | |
83 | | - | |
| 81 | + | |
84 | 82 | | |
85 | 83 | | |
86 | 84 | | |
| |||
89 | 87 | | |
90 | 88 | | |
91 | 89 | | |
92 | | - | |
93 | 90 | | |
94 | 91 | | |
95 | 92 | | |
| |||
120 | 117 | | |
121 | 118 | | |
122 | 119 | | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | 120 | | |
127 | 121 | | |
128 | 122 | | |
129 | 123 | | |
130 | | - | |
| 124 | + | |
131 | 125 | | |
132 | 126 | | |
133 | 127 | | |
134 | 128 | | |
135 | 129 | | |
136 | | - | |
137 | 130 | | |
138 | | - | |
139 | | - | |
| 131 | + | |
140 | 132 | | |
141 | 133 | | |
142 | | - | |
143 | 134 | | |
144 | 135 | | |
145 | 136 | | |
| |||
0 commit comments