Support Git tags - #44
Open
myclevorname wants to merge 1 commit into
Open
Conversation
One of the dependencies in [raylib](https://github.com/raysan5/raylib/blob/master/build.zig.zon) has git rev 3.1.50, causing Nix to complain it is not a valid sha1 hash. I added a naive check that checks if the rev is exactly 40 characters. The only time I see this becoming an issue is if a tag's length is exactly 40 characters, but that happening in the wild is very unlikely.
Member
|
Please rebase so CI reruns so we can get logs. |
Member
|
Looks like #57 may fix the problem. |
Member
|
Please rebase since #57 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the dependencies in
raylib has git rev 3.1.50, causing Nix to complain it is not a valid sha1 hash. I added a naive check that checks if the rev is exactly 40 characters. The only time I see this becoming an issue is if a tag's length is exactly 40 characters, but that happening in the wild is very unlikely.