Skip to content

change(nix): make flake more consistent with nixos module - #111

Open
yipfluoric wants to merge 4 commits into
noctalia-dev:mainfrom
yipfluoric:program-to-display-manager
Open

change(nix): make flake more consistent with nixos module#111
yipfluoric wants to merge 4 commits into
noctalia-dev:mainfrom
yipfluoric:program-to-display-manager

Conversation

@yipfluoric

@yipfluoric yipfluoric commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Switching programs.noctalia-greeter to services.displayManager.noctalia-greeter for sanity when switching between nixpkgs and flake.

Motivation

In #3, keeping it as programs.noctalia-greeter was fine, since it was insanely early. Now that the package is in nixpkgs and most people use that variation, using the flake module can conflict with services.displayManager.noctalia-greeter and be a nuisance until you change it to programs.noctalia-greeter. This changes it to the terminology nixpkgs uses for sanity.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging

Related Issue

Testing

nh os switch -u
Mostly just testing using my repo rather than noctalia one in my flake

Manual Coverage

  • Tested under greetd (real login flow)
  • Tested with just run / just run-local (dev compositor)
  • Tested with multiple monitors
  • Tested appearance sync from Noctalia Shell (Sync Now)
  • Tested on NixOS (programs.noctalia-greeter)
  • Tested with a pinned [output].name
  • Tested with custom [output].layout / [output].transforms

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md and README.md.
  • I ran just format with clang-format v22+ installed, or this PR has no code changes.
  • I ran the relevant build or test commands, or explained why they were not run.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated user-facing documentation in docs/user/ when this PR changes user-visible behavior or configuration, or this PR does not require documentation changes.
  • I used the existing canonical names for config keys, paths, and identifiers.

Additional Notes

@github-actions
github-actions Bot marked this pull request as draft September 4, 2026 22:18
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

The description now contains the required template structure.

@yipfluoric
yipfluoric marked this pull request as ready for review September 4, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant