fix(radios): allow backend activation despite reported rfkill hard block - #4182
Draft
p0nti wants to merge 2 commits into
Draft
fix(radios): allow backend activation despite reported rfkill hard block#4182p0nti wants to merge 2 commits into
p0nti wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for the PR, can you try with my commit see how it behaves on your hardware., then report back. |
ItsLemmy
marked this pull request as draft
September 1, 2026 23:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let NetworkManager and BlueZ attempt radio activation even when the preliminary rfkill check reports a hard block. Retain a diagnostic warning and all existing backend error handling.
Motivation
On a Dell Latitude 5531 with Intel AX211/iwlwifi, disabling Wi-Fi in Noctalia produces:
Re-enabling in Noctalia logs
setWirelessEnabled: wlan rfkill hard block is activeand returns without requesting activation from NetworkManager.nmcli radio wifi onalone clears both blocks and reconnects. The vendor platform soft block can manifest as a PHY hard block, so this initial observation must not prevent the backend from attempting activation.The same early-return pattern exists in Bluetooth, and #3367 contains a report of a platform rfkill hard-block indication preventing an otherwise functional Bluetooth adapter from being enabled.
This is not an override of a real hardware switch: kernel enforcement remains unchanged. The patch only removes the client-side refusal to attempt the existing backend operation. Disable behavior and error handling are preserved.
Type of Change
Related Issue
Fixes #3367
Testing
The two modified source files are byte-identical to the locally built and hardware-tested patch based on 29dab93. They were unchanged upstream when rebasing this submission onto main (4912b92).
meson setup build-radio --buildtype=release -Dtests=enabled -Db_ndebug=trueandninja -C build-radio -j 4 noctalia.network_manager_securitytest passed; rerun before submission. This is an existing smoke test, not a new regression test for rfkill.Poweredreturned true. No connected Bluetooth devices were interrupted. The ThinkPad-specific hard-block scenario has not been reproduced on this Dell.just formatwith clang-format 22.1.8 andgit diff --check.Manual Coverage
Environment: Arch Linux, Dell Latitude 5531, Intel AX211, NetworkManager. BIOS WLAN enabled and WLAN autosense disabled; user has write access to /dev/rfkill.
Screenshots / Videos
Not applicable: no visual/layout changes.
Checklist
Additional Notes
Prepared with OpenAI Codex assistance, reviewed against the existing activation paths, and tested on the affected hardware. Bluetooth hard-block behavior on other hardware and genuine hardware-switch cases would benefit from additional testing.