Skip to content

fix(pipewire): mute route-less virtual sources #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvnloo wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix(pipewire): mute route-less virtual sources #4250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/pipewire/pipewire_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1925,9 +1925,9 @@ void PipeWireService::setNodeMuted(std::uint32_t id, bool muted) {
return;
}

// Device nodes go through WirePlumber's mixer-api to keep pipewire-pulse / pavucontrol in sync. The
// committed mute echoes back through onMixerVolumeChanged; swMute is set optimistically for
// immediate UI feedback.
// Device nodes with a hardware route go through WirePlumber's mixer-api to keep pipewire-pulse /
// pavucontrol in sync. Route-less virtual sources also need the direct SPA node mute below: the mixer
// write can update the optimistic UI state without stopping capture in the virtual filter graph.
const bool isDeviceNode = nd.mediaClass == "Audio/Sink" || nd.mediaClass == "Audio/Source";
if (isDeviceNode && m_wpMixer != nullptr) {
m_wpMixer->setMuted(id, muted);
Expand All @@ -1942,7 +1942,9 @@ void PipeWireService::setNodeMuted(std::uint32_t id, bool muted) {
}
rebuildState();
}
return;
if (nd.hasRoute) {
return;
}
}

// Program streams, and device nodes for immediate local/UI consistency.
Expand Down