fix(ui): initialize button badge colors - #4305
Open
tbracquart wants to merge 3 commits into
Open
Conversation
tbracquart
marked this pull request as ready for review
September 6, 2026 02:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initialize colors for dynamically-created button badges so session shortcut badges are visible immediately.
Motivation
Session shortcut badges displayed their text, but their rounded background was invisible until the button received hover or focus. The badge is created dynamically after the initial button colors are applied, so it did not receive its colors until a later state change.
Type of Change
Related Issue
Testing
just formatjust buildjust runjust testjust testcompleted with 110/112 tests passing. The unrelatednoctalia:processandnoctalia:time_formattests failed; neither exercises the button badge code changed by this PR.Manual Coverage
Screenshots / Videos
Before
The shortcut badges display their numbers, but their rounded backgrounds are not visible until the button receives hover or focus.
After
The shortcut badges now display their rounded backgrounds immediately, without requiring hover or focus.
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.docs/user/when this PR changes documented behavior or configuration, or this PR does not require documentation changes.assets/translations/en.json, or this PR adds no new user-facing strings.