Skip to content

Commit 865a231

Browse files
committed
Honor historical Common defaults for the Script property
Assisted-By: GPT-6
1 parent e3b5e6d commit 865a231

2 files changed

Lines changed: 24 additions & 8 deletions

File tree

‎scripts/parse-blocks-scripts-properties.mjs‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ const findCanonicalName = (shortName) => {
1515
return canonicalName;
1616
};
1717

18-
const initialMapForType = (type) => {
18+
const initialMapForType = (type, defaultScript) => {
1919
switch (type) {
2020
case 'scripts':
2121
return {
22-
Unknown: regenerate().addRange(0, CODEPOINT_MAX),
22+
[defaultScript]: regenerate().addRange(0, CODEPOINT_MAX),
2323
};
2424
default:
2525
return {};
@@ -32,7 +32,9 @@ const initialMapForType = (type) => {
3232
* @returns
3333
*/
3434
const parseBlocksScriptsProperties = async (type, version) => {
35-
const map = initialMapForType(type);
35+
// Script=Unknown was introduced in Unicode 5.0. Earlier releases use Common.
36+
const defaultScript = parseInt(version, 10) < 5 ? 'Common' : 'Unknown';
37+
const map = initialMapForType(type, defaultScript);
3638
const source = utils.readDataFile(version, type);
3739
if (!source) {
3840
return;
@@ -89,14 +91,14 @@ const parseBlocksScriptsProperties = async (type, version) => {
8991
const start = parseInt(rangeParts[0], 16);
9092
const end = parseInt(rangeParts[1], 16);
9193
map[item].addRange(start, end);
92-
if (type === 'scripts') {
93-
map.Unknown.removeRange(start, end);
94+
if (type === 'scripts' && item !== defaultScript) {
95+
map[defaultScript].removeRange(start, end);
9496
}
9597
} else {
9698
const codepoint = parseInt(charRange, 16);
9799
map[item].add(codepoint);
98-
if (type === 'scripts') {
99-
map.Unknown.remove(codepoint);
100+
if (type === 'scripts' && item !== defaultScript) {
101+
map[defaultScript].remove(codepoint);
100102
}
101103
}
102104
}

‎tests/parsers.mjs‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,25 @@ test('Property records do not require spaces around semicolons', async (t) => {
3232
const scripts = await parseScripts(version);
3333
t.assert.ok(scripts.Common.contains(0x100000));
3434
t.assert.ok(scripts.Common.contains(0x10fffd));
35-
t.assert.ok(!scripts.Unknown.contains(0x100000));
35+
t.assert.ok(!scripts.Unknown?.contains(0x100000));
3636
}
3737
for (const version of ['4.0.1', '4.1.0', '5.0.0']) {
3838
const core = await parseDerivedCoreProperties(version);
3939
t.assert.ok(core.Default_Ignorable_Code_Point.contains(0x10fffe));
4040
t.assert.ok(core.Default_Ignorable_Code_Point.contains(0x10ffff));
4141
}
4242
});
43+
44+
test('Script defaults follow the Unicode version', async (t) => {
45+
for (const version of ['3.1.0', '3.1.1', '3.2.0', '4.0.0', '4.0.1', '4.1.0']) {
46+
const scripts = await parseScripts(version);
47+
t.assert.ok(scripts.Common.contains(0x20));
48+
t.assert.ok(scripts.Common.contains(0x378));
49+
t.assert.ok(!scripts.Common.contains(0x41));
50+
t.assert.equal(scripts.Unknown, undefined);
51+
}
52+
const scripts = await parseScripts('5.0.0');
53+
t.assert.ok(scripts.Common.contains(0x20));
54+
t.assert.ok(scripts.Unknown.contains(0x378));
55+
t.assert.ok(!scripts.Common.contains(0x378));
56+
});

0 commit comments

Comments
 (0)