Perform server-side redirect on certificate login.

The client-side script was trying to perform the redirect
and the associated client-side authentication step,
thereby writing to solid-auth-client's internal state.
This commit leaves authentication to the server.

Author: RubenVerborgh

default-views/auth/login-tls.hbs

@@ -8,33 +8,3 @@
     {{> auth/auth-hidden-fields}}
   </div>
 </form>
-
-<script type="text/javascript">
-  const button = document.getElementById('login-tls')
-  button.addEventListener('click', function(event) {
-    event.preventDefault()
-    fetch('/login/tls', { method: 'POST', credentials: 'include' })
-      .then(function(response) {
-        const webId = response.headers.get('user')
-        const idp = new URL(webId).origin
-        const session = { authType: 'WebID-TLS', webId, idp }
-        const authClientNamespace = 'solid-auth-client'
-        let authClientStore
-        try {
-          authClientStore = JSON.parse(localStorage.getItem(authClientNamespace) || '{}')
-        } catch (err) {
-          authClientStore = {}
-        }
-        authClientStore.session = session
-        localStorage.setItem(authClientNamespace, JSON.stringify(authClientStore))
-        return response
-      })
-      .then(function(response) {
-        // Temporary solution to restore return URL
-        // until https://github.com/solid/oidc-auth-manager/issues/17 is resolved
-        const returnToUrl = localStorage.getItem('returnToUrl')
-        localStorage.removeItem('returnToUrl')
-        window.location.href = returnToUrl || '/'
-      })
-  })
-</script>

lib/requests/login-request.js

@@ -175,19 +175,6 @@ class LoginRequest extends AuthRequest {
    * Redirects the Login request to continue on the OIDC auth workflow.
    */
   redirectPostLogin (validUser) {
-    // TODO: Make the kludge below unnecessary (e.g., by separating OIDC and TLS auth).
-    // If we have arrived here in the WebID-TLS case,
-    // this means the client has done an AJAX POST request to /login/tls.
-    // If the WebID is external, and we send out a redirect to that external URL,
-    // there is a risk that this external URL returns a non-2xx response.
-    // This in turn makes the AJAX call on the client fail,
-    // and its success code is not executed because of that failure.
-    // To prevent this, we just reply a 204 for external WebIDs.
-    if (this.authMethod === TLS_AUTH && validUser.externalWebId) {
-      debug('Login successful with WebID-TLS')
-      return this.response.header('User', validUser.webId).status(204).send()
-    }
-
     let uri = this.postLoginUrl(validUser)
     debug('Login successful, redirecting to ', uri)
     this.response.redirect(uri)