Repository navigation
fix(core): preserve shared metadata in json-simple - #1187
Open
dxnnystyles wants to merge 1 commit into
Open
dxnnystyles wants to merge 1 commit into
dxnnystyles wants to merge 1 commit into
Conversation
Signed-off-by: dxnnystyles <aaronsanchez2000@yahoo.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ovflowd
approved these changes
Oct 26, 2026
ovflowd
left a comment
Member
There was a problem hiding this comment.
I suppose this looks good to me.
Thanks for your first contribution!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 93.44% 93.47% +0.03%
==========================================
Files 278 279 +1
Lines 27820 27873 +53
Branches 2790 2795 +5
==========================================
+ Hits 25997 26055 +58
+ Misses 1801 1796 -5
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
29.24 MB | 29.24 MB | +2.35 KB (+0.0%) |
Performance estimate (single CI run)
- Generation time: 29.0% slower (7.35 s → 9.48 s)
- Peak memory: 9.4% lower (1.28 GB → 1.16 GB)
web Generator
Performance estimate (single CI run)
- Generation time: 11.0% slower (22.42 s → 24.89 s)
- Peak memory: 4.9% higher (1.90 GB → 2.00 GB)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
json-simplenow filters copied entry content, leaving shared metadata unchanged. It returns and writes the filtered copies.Validation
node --run test(Node v24.22.1): 748 tests passed.node --run lint: passed.node --run format:check: passed.node --run build: passed.@doc-kit/corepatch.Related Issues
Fixes #1182
Check List
node --run testand all tests passed.node --run format:check&node --run lint.Signed-off-bytrailer.