Repository navigation
Conversation
Nothing after `metadata` reads where a node came from in the source: the type warnings that print positions run while it parses. Dropping them shrinks every entry the main thread holds and copies to and from the workers. On Node.js's docs that is ~480k position objects, about 80MB, and builds are ~5% faster. `json-simple`, which writes the metadata as it is, no longer has them either, and is about a third of its size. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
- Coverage 94.14% 94.14% -0.01%
==========================================
Files 291 291
Lines 28950 28993 +43
Branches 2944 2953 +9
==========================================
+ Hits 27256 27296 +40
- Misses 1672 1675 +3
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks done
Contributor
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
ovflowd
marked this pull request as ready for review
November 3, 2026 20:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR drops
positionfrom every node ofmetadata's entries once they're parsed. Nothing aftermetadatareads where a node came from in the source: the type warnings that print positions run while it parses. On Node.js's docs that's ~480k objects, about 80MB, that the main thread no longer holds or copies to and from the workers, and builds are ~5% faster.json-simplewrites the metadata as it is, so it no longer has them either, and is about a third of its size.Validation
Added
drops where each node of an entry came from, which checks that no node of a parsed entry has aposition.json-simpleis the only target whose output changes, and the<api>.jsonfilesjsonandlegacy-jsonboth write already race onmain.Related Issues
Split out of #1205.
Check List
node --run testand all tests passed.node --run format:check&node --run lint.