Skip to content

docs: remove unused argument from getSong example - #192

Open
PedroHercules wants to merge 1 commit into
nodejs:mainfrom
PedroHercules:patch-1
Open

PedroHercules wants to merge 1 commit into
nodejs:mainfrom
PedroHercules:patch-1

Conversation

@PedroHercules

Copy link
Copy Markdown

The asynchronous flow control example calls getSong('beer'), even though the function does not accept any parameters.

This unused argument may confuse readers into thinking it contributes to the error being demonstrated.

Removing it keeps the example focused on the actual issue: getSong() returns before the asynchronous setTimeout callbacks execute.

This change improves clarity without affecting the example's behavior.

The asynchronous flow control example calls `getSong('beer')`, even though the function does not accept any parameters.

This unused argument may confuse readers into thinking it contributes to the error being demonstrated.

Removing it keeps the example focused on the actual issue: `getSong()` returns before the asynchronous `setTimeout` callbacks execute.

This change improves clarity without affecting the example's behavior.

Signed-off-by: Pedro Hercules <pedroherculesdantas@gmail.com>
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-learn Ready Ready Preview Nov 12, 2026 11:28pm UTC

Request Review

@github-actions

Copy link
Copy Markdown

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/timers

Please review the changes when you have a chance. Thank you! 🙏

This branch was successfully deployed

1 active deployment
Preview — 561283d9 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants