Skip to content

doc: require 24 hours before merging a pull request - #10

Merged
bengl merged 1 commit into
nodejs:mainfrom
bengl:bengl/contributing-24h
Oct 27, 2026
Merged

bengl merged 1 commit into
nodejs:mainfrom
bengl:bengl/contributing-24h

Conversation

@bengl

@bengl bengl commented Oct 26, 2026

Copy link
Copy Markdown
Member

Adds a Pull requests section to the contribution guide: a pull request should be open for at least 24 hours before it is merged, so that reviewers across time zones have a chance to see it. Trivial changes, as determined by the maintainers, may be merged sooner.

A pull request should be open for at least 24 hours before it is
merged, so that reviewers across time zones have a chance to see it.
Trivial changes, as determined by the maintainers, may be merged
sooner.

Signed-off-by: Bryan English <bryan@bryanenglish.com>
@bengl
bengl marked this pull request as ready for review October 26, 2026 19:44
@bengl
bengl merged commit c248885 into nodejs:main Oct 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants