Repository navigation
test: restore the validate parity test and close coverage gaps - #8
Merged
Merged
Conversation
The parity test deferred from the initial port is back: one shared battery of calls runs through lib/validate.js and through node's real internal validators and error constructors in a child under --expose-internals, and the outcomes must match down to the messages. outOfRangeError is exported again for the battery to construct. The coverage gaps: IPv6 authorities and portless Host headers on the http client (both scheme defaults, 80 and 443), the boolean, non-integer, and fallback arms of the OTLP attribute encoding, and the non-2xx collector response warning. The undici origin's scheme-default port stays uncovered: reaching it requires binding port 80 or 443. Signed-off-by: Bryan English <bryan@bryanenglish.com>
bengl
force-pushed
the
bengl/parity-coverage
branch
from
October 26, 2026 19:07
cefef87 to
9d4e843
Compare
bengl
marked this pull request as ready for review
October 26, 2026 19:12
AbhiPrasad
approved these changes
Oct 26, 2026
jsumners-nr
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the parity test deferred from the initial port, and closes the coverage gaps left behind in the merged code.
The parity test: one shared battery of calls runs through lib/validate.js and through node's real internal validators and error constructors in a child under --expose-internals, and the outcomes must match down to the error messages. outOfRangeError is exported again so the battery can construct it. If core ever changes these message formats, this test catches the drift.
The coverage gaps:
The undici origin's scheme-default port stays uncovered: reaching it requires binding port 80 or 443, which tests cannot do.
Overall the suite goes from 94.6% to 97.4% line coverage, and validate.js from 41% to 73% branch coverage.