Repository navigation
Conversation
server.address must be the bare host, with the port in server.port. The server span copied the Host header verbatim, port included, and the undici span set the whole origin. Both now carry only the host. A new test validates every emitted attribute name against the semantic-conventions registry at test time: the @opentelemetry/semantic-conventions package, whose exports are the attribute names the conventions define, becomes a devDependency, and one trace through every instrumentation shape walks span, event, and resource attributes through the registry. Signed-off-by: Bryan English <bryan@bryanenglish.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the spans with the current OpenTelemetry semantic conventions, and locks the alignment in at test time.
The divergence: server.address must be the bare host, with the port in server.port. The http server span copied the Host header verbatim, port included, and the undici span set the whole origin. Both now carry only the host.
The lock: the @opentelemetry/semantic-conventions package becomes a devDependency, and a new test validates at test time that every attribute name emitted on spans, events, and resources is defined by the conventions registry. One trace exercises every instrumentation shape: server spans with query attributes, http and fetch client spans, error statuses, and refused connections with exception events. If an instrumentation ever emits a name the conventions do not define, or the conventions rename something underneath us, the test fails.