Skip to content

Commit eb73f14

Browse files
joyeecheungnodejs-github-bot
authored andcommitted
build: do not match v8_libplatform_headers when scraping sources
Otherwise the target contains undefined symbols because there are only header files in the list. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 0111d9a commit eb73f14

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎tools/v8_gypfiles/v8.gyp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1810,7 +1810,7 @@
18101810
'v8_libbase',
18111811
],
18121812
'sources': [
1813-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?sources = ")',
1813+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?sources = ")',
18141814
],
18151815
'conditions': [
18161816
['component=="shared_library"', {
@@ -1821,10 +1821,10 @@
18211821
}],
18221822
['v8_use_perfetto==1', {
18231823
'sources!': [
1824-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\-= ")',
1824+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?v8_use_perfetto.*?sources \\-= ")',
18251825
],
18261826
'sources': [
1827-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\+= ")',
1827+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?v8_use_perfetto.*?sources \\+= ")',
18281828
],
18291829
'conditions': [
18301830
['node_shared_perfetto=="false"', {

0 commit comments

Comments
 (0)