Skip to content

Commit 25ba9fa

Browse files
deepak1556christianaurichzm
authored andcommitted
deps: enable V8 API interrupt JS check
Signed-off-by: deepak1556 <hop2deep@gmail.com> Signed-off-by: Christian Aurich Zanettini Martins <christian.aurichzm@gmail.com>
1 parent 5337718 commit 25ba9fa

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

‎common.gypi‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@
5656
# Refs: https://github.com/nodejs/node/issues/23167
5757
# Enable compiler warnings when using V8_DEPRECATED apis from V8 code.
5858
'v8_deprecation_warnings': 0,
59+
# Check that JavaScript execution is disallowed in V8 API interrupts.
60+
'v8_disallow_js_in_api_interrupts_is_checked': 1,
5961
# Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code.
6062
'v8_imminent_deprecation_warnings': 0,
6163

@@ -557,6 +559,9 @@
557559
['v8_deprecation_warnings == 1', {
558560
'defines': ['V8_DEPRECATION_WARNINGS',],
559561
}],
562+
['v8_disallow_js_in_api_interrupts_is_checked == 1', {
563+
'defines': ['V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED',],
564+
}],
560565
['v8_imminent_deprecation_warnings == 1', {
561566
'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
562567
}],

‎tools/v8_gypfiles/features.gypi‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,9 @@
107107
# Enable compiler warnings when using V8_DEPRECATED apis.
108108
'v8_deprecation_warnings%': 0,
109109

110+
# Check that JavaScript execution is disallowed in V8 API interrupts.
111+
'v8_disallow_js_in_api_interrupts_is_checked%': 0,
112+
110113
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
111114
'v8_imminent_deprecation_warnings%': 0,
112115

@@ -422,6 +425,9 @@
422425
['v8_deprecation_warnings==1', {
423426
'defines': ['V8_DEPRECATION_WARNINGS',],
424427
}],
428+
['v8_disallow_js_in_api_interrupts_is_checked==1', {
429+
'defines': ['V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED',],
430+
}],
425431
['v8_imminent_deprecation_warnings==1', {
426432
'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
427433
}],

0 commit comments

Comments
 (0)