Revert "deps: V8: backport b36cf9f6ccd2"

This reverts commit ccd648e.

PR-URL: #65907
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: aduh95

deps/v8/BUILD.bazel

@@ -148,11 +148,6 @@ v8_flag(name = "v8_enable_trace_maps")
 
 v8_flag(name = "v8_enable_v8_checks")
 
-v8_flag(
-    name = "v8_disallow_js_in_api_interrupts_is_checked",
-    default = True,
-)
-
 v8_flag(name = "v8_enable_verify_csa")
 
 v8_flag(name = "v8_enable_verify_heap")
@@ -501,7 +496,6 @@ v8_config(
         "v8_android_log_stdout": "V8_ANDROID_LOG_STDOUT",
         "v8_code_comments": "V8_CODE_COMMENTS",
         "v8_deprecation_warnings": "V8_DEPRECATION_WARNINGS",
-        "v8_disallow_js_in_api_interrupts_is_checked": "V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED",
         "v8_imminent_deprecation_warnings": "V8_IMMINENT_DEPRECATION_WARNINGS",
         "v8_enable_debug_code": "V8_ENABLE_DEBUG_CODE",
         "v8_enable_disassembler": "ENABLE_DISASSEMBLER",

deps/v8/BUILD.gn

@@ -59,10 +59,6 @@ declare_args() {
   # Enable compiler warnings when using V8_DEPRECATED apis.
   v8_deprecation_warnings = true
 
-  # Check that executing JavaScript inside API interrupt callbacks is
-  # disallowed.
-  v8_disallow_js_in_api_interrupts_is_checked = true
-
   # Enable compiler warnings when using V8_DEPRECATE_SOON apis.
   v8_imminent_deprecation_warnings = true
 
@@ -1003,7 +999,6 @@ external_v8_defines = [
   "V8_COMPRESS_ZONES",
   "V8_ENABLE_SANDBOX",
   "V8_DEPRECATION_WARNINGS",
-  "V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED",
   "V8_IMMINENT_DEPRECATION_WARNINGS",
   "V8_USE_PERFETTO",
   "V8_USE_PERFETTO_JSON_EXPORT",
@@ -1052,10 +1047,6 @@ if (v8_enable_sandbox) {
 if (v8_deprecation_warnings) {
   enabled_external_v8_defines += [ "V8_DEPRECATION_WARNINGS" ]
 }
-if (v8_disallow_js_in_api_interrupts_is_checked) {
-  enabled_external_v8_defines +=
-      [ "V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED" ]
-}
 if (v8_imminent_deprecation_warnings) {
   enabled_external_v8_defines += [ "V8_IMMINENT_DEPRECATION_WARNINGS" ]
 }
@@ -3102,8 +3093,6 @@ generated_file("v8_generate_features_json") {
   output_conversion = "json"
   contents = {
     v8_deprecation_warnings = v8_deprecation_warnings
-    v8_disallow_js_in_api_interrupts_is_checked =
-        v8_disallow_js_in_api_interrupts_is_checked
     v8_enable_31bit_smis_on_64bit_arch = v8_enable_31bit_smis_on_64bit_arch
     v8_enable_direct_handle = v8_enable_direct_handle
     v8_enable_extensible_ro_snapshot = v8_enable_extensible_ro_snapshot

deps/v8/src/common/assert-scope.h

@@ -110,7 +110,7 @@ class V8_NODISCARD PerThreadAssertScope
     ScopeType& operator=(const ScopeType&) = delete;                 \
     V8_EXPORT_PRIVATE ~ScopeType();                                  \
                                                                      \
-    V8_EXPORT_PRIVATE static bool IsAllowed(Isolate* isolate);       \
+    static bool IsAllowed(Isolate* isolate);                         \
                                                                      \
     V8_EXPORT_PRIVATE static void Open(Isolate* isolate,             \
                                        bool* was_execution_allowed); \

deps/v8/src/execution/isolate.cc

@@ -2357,13 +2357,6 @@ void Isolate::InvokeApiInterruptCallbacks() {
     }
     VMState<EXTERNAL> state(this);
     HandleScope handle_scope(this);
-    // API interrupt callbacks are forbidden from executing JavaScript on the
-    // interrupted Isolate (see v8::Isolate::RequestInterrupt contract in
-    // v8-isolate.h: "Registered |callback| must not reenter interrupted
-    // Isolate.").
-#ifdef V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED
-    DisallowJavascriptExecution no_js(this);
-#endif  // V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED
     entry.first(reinterpret_cast<v8::Isolate*>(this), entry.second);
   }
 }

deps/v8/src/inspector/v8-debugger.cc

@@ -532,7 +532,6 @@ void V8Debugger::handleProgramBreak(
         }
       });
   {
-    v8::Isolate::AllowJavascriptExecutionScope allow_script(m_isolate);
     v8::Context::Scope scope(pausedContext);
 
     m_inspector->forEachSession(

deps/v8/src/inspector/v8-inspector-impl.cc

@@ -96,7 +96,6 @@ int V8InspectorImpl::resolveUniqueContextId(
 
 v8::MaybeLocal<v8::Value> V8InspectorImpl::compileAndRunInternalScript(
     v8::Local<v8::Context> context, v8::Local<v8::String> source) {
-  v8::Isolate::AllowJavascriptExecutionScope allow_script(m_isolate);
   v8::Local<v8::UnboundScript> unboundScript;
   if (!v8::debug::CompileInspectorScript(m_isolate, source)
            .ToLocal(&unboundScript))

deps/v8/src/inspector/v8-inspector-session-impl.cc

@@ -355,8 +355,6 @@ void V8InspectorSessionImpl::reportAllContexts(V8RuntimeAgentImpl* agent) {
 }
 
 void V8InspectorSessionImpl::dispatchProtocolMessage(StringView message) {
-  v8::Isolate::AllowJavascriptExecutionScope allow_script(
-      m_inspector->isolate());
   KeepSessionAliveScope keepAlive(*this);
 
   using v8_crdtp::span;

deps/v8/src/inspector/v8-regex.cc

@@ -38,7 +38,6 @@ V8Regex::V8Regex(V8InspectorImpl* inspector, const String16& pattern,
   v8::Local<v8::RegExp> regex;
   // Protect against reentrant debugger calls via interrupts.
   v8::debug::PostponeInterruptsScope no_interrupts(m_inspector->isolate());
-  v8::Isolate::AllowJavascriptExecutionScope allow_js(m_inspector->isolate());
   if (v8::RegExp::New(context, toV8String(isolate, pattern),
                       static_cast<v8::RegExp::Flags>(flags))
           .ToLocal(&regex))
@@ -70,7 +69,6 @@ int V8Regex::match(const String16& string, int startFrom,
                                  v8::MicrotasksScope::kDoNotRunMicrotasks);
   // Protect against reentrant debugger calls via interrupts.
   v8::debug::PostponeInterruptsScope no_interrupts(m_inspector->isolate());
-  v8::Isolate::AllowJavascriptExecutionScope allow_js(m_inspector->isolate());
   v8::TryCatch tryCatch(isolate);
 
   v8::Local<v8::RegExp> regex = m_regex.Get(isolate);

deps/v8/test/cctest/test-api.cc

@@ -22306,26 +22306,6 @@ TEST(RequestInterruptSmallScripts) {
   CHECK(interrupt_was_called);
 }
 
-#ifdef V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED
-static bool interrupt_check_no_js = false;
-void DisallowJsInterruptCallback(v8::Isolate* isolate, void* data) {
-  CHECK(!i::AllowJavascriptExecution::IsAllowed(
-      reinterpret_cast<i::Isolate*>(isolate)));
-  interrupt_check_no_js = true;
-}
-
-TEST(RequestInterruptDisallowsJavascript) {
-  LocalContext env;
-  v8::Isolate* isolate = CcTest::isolate();
-  v8::HandleScope scope(isolate);
-
-  interrupt_check_no_js = false;
-  isolate->RequestInterrupt(&DisallowJsInterruptCallback, nullptr);
-  CompileRun("(function(x){return x;})(1);");
-  CHECK(interrupt_check_no_js);
-}
-#endif  // V8_DISALLOW_JS_IN_API_INTERRUPTS_IS_CHECKED
-
 static v8::Global<Value> function_new_expected_env_global;
 static void FunctionNewCallback(const v8::FunctionCallbackInfo<Value>& info) {
   v8::Isolate* isolate = info.GetIsolate();

deps/v8/test/cctest/test-regexp.cc

@@ -124,13 +124,7 @@ class InterruptTest {
     CHECK(string->ContainsOnlyOneByte());
     // Internalize the subject by using it as a computed property name in an
     // object.
-    {
-      // This test is technically wrong for running JS in a C++ interrupt.
-      // However we know that the interuptee here is the regexp engine, which
-      // does not care.
-      Isolate::AllowJavascriptExecutionScope allow_script(isolate);
-      CompileRun("o = { [subject_string]: 'foo' }");
-    }
+    CompileRun("o = { [subject_string]: 'foo' }");
     CHECK(string->IsOneByte());
   }