test: use registerHooks() over module.register()

Port the tests that registered async module customization hooks, via
`--loader`, `--experimental-loader` or `module.register()`, only as a
means of exercising other features to use `module.registerHooks()`
instead. This keeps the coverage for those features independent of the
async module customization hooks, which are being removed.

Tests that exist only to exercise the async module customization hooks
themselves are left as they are.

Assisted-by: Claude
Signed-off-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #67074
Refs: #62395
Refs: #62401
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Author: GeoffreyBooth

test/es-module/test-esm-assertionless-json-import.js

@@ -1,4 +1,4 @@
-// Flags: --experimental-loader ./test/fixtures/es-module-loaders/assertionless-json-import.mjs
+// Flags: --import ./test/fixtures/es-module-loaders/assertionless-json-import.mjs
 'use strict';
 const common = require('../common');
 const assert = require('assert');

test/es-module/test-esm-detect-ambiguous.mjs

@@ -147,26 +147,27 @@ describe('Module syntax detection', { concurrency: !process.env.TEST_PARALLEL },
     }
 
     it('should not hint wrong format in resolve hook', async () => {
-      // eslint-disable-next-line no-unassigned-vars
-      let writeSync;
       const { stdout, stderr, code, signal } = await spawnPromisified(process.execPath, [
         '--no-warnings',
-        '--loader',
-        `data:text/javascript,import { writeSync } from "node:fs"; export ${encodeURIComponent(
-          async function resolve(s, c, next) {
-            const result = await next(s, c);
-            writeSync(1, result.format + '\n');
-            return result;
-          }
-        )}`,
+        '--import',
+        'data:text/javascript,' + encodeURIComponent(`
+          import { writeSync } from 'node:fs';
+          import { registerHooks } from 'node:module';
+          registerHooks({
+            resolve(specifier, context, nextResolve) {
+              const result = nextResolve(specifier, context);
+              writeSync(1, result.format + '\\n');
+              return result;
+            },
+          });
+        `),
         fixtures.path('es-modules/package-without-type/noext-esm'),
       ]);
 
       assert.strictEqual(stderr, '');
       assert.strictEqual(stdout, 'null\nexecuted\n');
       assert.strictEqual(code, 0);
       assert.strictEqual(signal, null);
-
     });
   });
 

test/es-module/test-esm-import-meta-resolve.mjs

@@ -94,7 +94,10 @@ await assert.rejects(import('data:text/javascript,export default import.meta.res
   const result = await spawnPromisified(execPath, [
     '--no-warnings',
     '--input-type=module',
-    '--import', 'data:text/javascript,import{register}from"node:module";register("data:text/javascript,")',
+    '--import', 'data:text/javascript,' + encodeURIComponent(
+      'import { registerHooks } from "node:module";' +
+      'registerHooks({ resolve: (s, c, next) => next(s, c) });',
+    ),
     '--eval',
     'console.log(import.meta.resolve(new URL("http://example.com")))',
   ]);

test/es-module/test-esm-virtual-json.mjs

@@ -1,10 +1,10 @@
 import '../common/index.mjs';
 import * as fixtures from '../common/fixtures.mjs';
-import { register } from 'node:module';
+import { registerHooks } from 'node:module';
 import assert from 'node:assert';
 
-async function resolve(referrer, context, next) {
-  const result = await next(referrer, context);
+function resolve(referrer, context, next) {
+  const result = next(referrer, context);
   const url = new URL(result.url);
   url.searchParams.set('randomSeed', Math.random());
   result.url = url.href;
@@ -22,7 +22,7 @@ function load(url, context, next) {
   return next(url, context);
 }
 
-register(`data:text/javascript,export ${encodeURIComponent(resolve)};export ${encodeURIComponent(load)}`);
+registerHooks({ resolve, load });
 
 assert.notDeepStrictEqual(
   await import(fixtures.fileURL('empty.json'), { with: { type: 'json' } }),

test/fixtures/es-module-loaders/assertionless-json-import.mjs

@@ -1,15 +1,22 @@
+import { registerHooks } from 'node:module';
+
 const DATA_URL_PATTERN = /^data:application\/json(?:[^,]*?)(;base64)?,([\s\S]*)$/;
 const JSON_URL_PATTERN = /^[^?]+\.json(\?[^#]*)?(#.*)?$/;
 
-export async function resolve(specifier, context, next) {
-  const noAttributesSpecified = context.importAttributes.type == null;
+function resolve(specifier, context, next) {
+  // Hooks also run for require() calls, which have no import attributes.
+  if (context.importAttributes === undefined) {
+    return next(specifier, context);
+  }
 
-  // Mutation from resolve hook should be discarded.
-  context.importAttributes.type = 'whatever';
+  const noAttributesSpecified = context.importAttributes.type == null;
 
   // This fixture assumes that no other resolve hooks in the chain will error on invalid import attributes
   // (as defaultResolve doesn't).
-  const result = await next(specifier, context);
+  const result = next(specifier, {
+    ...context,
+    importAttributes: { ...context.importAttributes, type: 'whatever' },
+  });
 
   if (noAttributesSpecified &&
       (DATA_URL_PATTERN.test(result.url) || JSON_URL_PATTERN.test(result.url))) {
@@ -22,3 +29,5 @@ export async function resolve(specifier, context, next) {
 
   return result;
 }
+
+registerHooks({ resolve });

…es-module-shadow-realm/custom-loaders.js …s/es-module-shadow-realm/custom-hooks.jstest/fixtures/es-module-shadow-realm/custom-loaders.js renamed to test/fixtures/es-module-shadow-realm/custom-hooks.js test/fixtures/es-module-shadow-realm/custom-loaders.js renamed to test/fixtures/es-module-shadow-realm/custom-hooks.js

@@ -1,10 +1,10 @@
-// This fixture is used to test that custom loaders are not enabled in the ShadowRealm.
+// This fixture is used to test that customization hooks are not enabled in the ShadowRealm.
 
 'use strict';
 const assert = require('assert');
 
 async function workInChildProcess() {
-  // Assert that the process is running with a custom loader.
+  // Assert that the process is running with custom hooks.
   const moduleNamespace = await import('file:///42.mjs');
   assert.strictEqual(moduleNamespace.default, 42);
 

test/fixtures/es-module-shadow-realm/register-hooks.js

@@ -0,0 +1,17 @@
+'use strict';
+const { registerHooks } = require('node:module');
+
+registerHooks({
+  resolve(specifier, context, nextResolve) {
+    if (specifier.startsWith('file:///') && specifier.includes('42')) {
+      return { shortCircuit: true, url: specifier };
+    }
+    return nextResolve(specifier, context);
+  },
+  load(url, context, nextLoad) {
+    if (url.startsWith('file:///') && url.includes('42')) {
+      return { shortCircuit: true, format: 'module', source: 'export default 42' };
+    }
+    return nextLoad(url, context);
+  },
+});

test/fixtures/module-hooks/register-logger-async-hooks.mjs

@@ -0,0 +1,13 @@
+import { registerHooks } from 'node:module';
+import { writeSync } from 'node:fs';
+
+registerHooks({
+  resolve(specifier, context, nextResolve) {
+    writeSync(1, `resolve ${specifier} from ${context.parentURL}\n`);
+    return nextResolve(specifier, context);
+  },
+  load(url, context, nextLoad) {
+    writeSync(1, `load ${url}\n`);
+    return nextLoad(url, context);
+  },
+});

test/fixtures/module-hooks/register-logger-hooks.mjs

@@ -1,3 +1,5 @@
+import { registerHooks } from 'node:module';
+
 const sources = {
 // Virtual file. Doesn't exist on disk
   "virtual.js": `
@@ -16,10 +18,12 @@ import{describe,it}from"node:test";import assert from"node:assert";import{sum}fr
   //# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJtYXBwaW5ncyI6ImtIQUFPLFNBQVMsT0FBUSxFQUFHLENBQ3pCLEdBQUksQ0FBQyxFQUFFLE1BQU8sS0FBUSxPQUFPLE1BQVEsUUFBUSxFQUFHLE1BQU0sSUFBSSxNQUFNLGNBQWMsRUFDOUUsT0FBTyxFQUFFLE9BQU8sQ0FBQyxJQUFLLE1BQVEsSUFBTSxHQUFHLENBQ3pDLENBSGdCIiwibmFtZXMiOltdLCJpZ25vcmVMaXN0IjpbXSwic291cmNlcyI6WyIuL3N1bS50cyJdLCJzb3VyY2VzQ29udGVudCI6W251bGxdfQ==`,
 };
 
-export async function load(url, context, nextLoad) {
+function load(url, context, nextLoad) {
   const file = url.split('/').at(-1);
   if (sources[file] !== undefined) {
     return { format: "module", source: sources[file], shortCircuit: true };
   }
   return nextLoad(url, context);
 }
+
+registerHooks({ load });