Skip to content

Commit da0567a

Browse files
Renegade334marco-ippolito
authored andcommitted
lib: use js-only implementation of isDataView()
PR-URL: #62780 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent 419861e commit da0567a

4 files changed

Lines changed: 10 additions & 18 deletions

File tree

‎benchmark/util/type-check.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ const args = {
2323
'false-primitive': true,
2424
'false-object': int32Array,
2525
},
26+
DataView: {
27+
'true': dataView,
28+
'false-primitive': true,
29+
'false-object': uint8Array,
30+
},
2631
};
2732

2833
const bench = common.createBenchmark(main, {

‎lib/internal/util/types.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ const {
66
TypedArrayPrototypeGetSymbolToStringTag,
77
} = primordials;
88

9+
function isDataView(value) {
10+
return ArrayBufferIsView(value) && TypedArrayPrototypeGetSymbolToStringTag(value) === undefined;
11+
}
12+
913
function isTypedArray(value) {
1014
return TypedArrayPrototypeGetSymbolToStringTag(value) !== undefined;
1115
}
@@ -61,6 +65,7 @@ function isBigUint64Array(value) {
6165
module.exports = {
6266
...internalBinding('types'),
6367
isArrayBufferView: ArrayBufferIsView,
68+
isDataView,
6469
isTypedArray,
6570
isUint8Array,
6671
isUint8ClampedArray,

‎src/node_types.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ namespace {
1919
V(AsyncFunction) \
2020
V(BigIntObject) \
2121
V(BooleanObject) \
22-
V(DataView) \
2322
V(Date) \
2423
V(External) \
2524
V(GeneratorFunction) \

‎test/parallel/test-util-types.js‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -654,23 +654,6 @@ for (const [ value, _method ] of [
654654
}
655655
}
656656

657-
{
658-
function testIsDataView(input) {
659-
return types.isDataView(input);
660-
}
661-
662-
eval('%PrepareFunctionForOptimization(testIsDataView)');
663-
testIsDataView(new DataView(new ArrayBuffer()));
664-
eval('%OptimizeFunctionOnNextCall(testIsDataView)');
665-
assert.strictEqual(testIsDataView(new DataView(new ArrayBuffer())), true);
666-
assert.strictEqual(testIsDataView(Math.random()), false);
667-
668-
if (common.isDebug) {
669-
const { getV8FastApiCallCount } = internalBinding('debug');
670-
assert.strictEqual(getV8FastApiCallCount('types.isDataView'), 2);
671-
}
672-
}
673-
674657
{
675658
function testIsSharedArrayBuffer(input) {
676659
return types.isSharedArrayBuffer(input);

0 commit comments

Comments
 (0)