Repository navigation
build: fix overriding node_path in GN build - #66805
Open
dsanders11 wants to merge 1 commit into
Open
dsanders11 wants to merge 1 commit into
dsanders11 wants to merge 1 commit into
Conversation
Signed-off-by: David Babenko-Sanders <dsanders11@ucsbalum.com>
Contributor
|
https://github.com/nodejs/node/actions/runs/39009516514/job/117328805687?pr=66805
FYI: This looks like the test runner’s UTF-8 decoding issue addressed by #66783, possibly unrelated to the changes here. |
inoway46
added
the
build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overriding the
node_pathvariable would lead to an error due to the default value fornode_module_versionusing the default value ofnode_path. GN's documentation calls out this exact issue, so I implemented their suggested solution and added a comment explaining it. Validated the fix in electron/electron#55080