Repository navigation
Conversation
Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
nodejs-github-bot
added
the
meta
inoway46
marked this pull request as ready for review
October 17, 2026 16:22
lpinca
approved these changes
Oct 17, 2026
bjohansebas
approved these changes
Oct 17, 2026
Member
|
gn build files are not owned by @nodejs/build as far as I know... |
Contributor
Author
|
Thanks for pointing this out. I checked CODEOWNERS and couldn't find an entry for these GN files. My intention was to categorize GN-related build changes under the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the build label for changes to top-level GN files: BUILD.gn, node.gni, and unofficial.gni.
Refs: #66805