Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9342 +/- ##
==========================================
+ Coverage 87.06% 87.13% +0.07%
==========================================
Files 91 92 +1
Lines 6563 6656 +93
Branches 401 405 +4
==========================================
+ Hits 5714 5800 +86
- Misses 845 852 +7
Partials 4 4 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the installation-method fallback update.
No open issues 🎉
What changed in this PR
Updates the download page’s fallback installation-method selection to follow dropdown display order. This addresses the behavior introduced with nvm-windows: switching from macOS with nvm selected to Windows now selects fnm.
Changes:
- Uses the displayed method groups to choose a replacement when the current method becomes unavailable.
- Adds tests for OS and version changes, including preserving a compatible community method.
| File | Description |
|---|---|
| apps/site/components/Downloads/Release/InstallationMethodDropdown.tsx | Selects fallback methods in display order. |
| apps/site/components/Downloads/Release/__tests__/InstallationMethodDropdown.test.jsx | Covers fallback selection and preservation of compatible methods. |
Review effort: Balanced
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
17d2a0e to
2e2d967
Compare
ovflowd
left a comment
There was a problem hiding this comment.
Interesting, that should already have been the case...
Description
With #9313 landed, I noticed that if I had
macOS/nvmselected, and then switched toWindows, I was automatically switched tonvm-windowsrather thanfnmwhich is also available for Windows and is displayed beforenvm-windowsin the dropdown. This updates the logic for how the method is switched to follow the displayed order.Validation
Select
macOS/nvm, then selectWindows. Observe switched tofnm.Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.