Repository navigation
fix: type EventSource error callbacks as Event - #6079
Open
blueDaydreaming725 wants to merge 1 commit into
Open
blueDaydreaming725 wants to merge 1 commit into
blueDaydreaming725 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
EventSource error events: https://html.spec.whatwg.org/multipage/server-sent-events.html
Rationale
EventSource dispatches a plain
Eventon failure, but its declaration currently suppliesErrorEventto bothonerrorandaddEventListener('error', ...). This lets callers access fields such asevent.messagethat are absent at runtime.Changes
Use
Eventfor both error callback declarations and remove the unusedErrorEventimport. No runtime behaviour changes.Features
N/A
Bug Fixes
Error callbacks now have the type of the event actually dispatched.
Breaking Changes and Deprecations
Code relying on ErrorEvent-only fields or explicitly annotating these callbacks as ErrorEvent will need to use Event instead. Those fields were not provided at runtime.
Status
Full JavaScript and WPT suites were not run.
Implemented, tested and reviewed with OpenAI Codex assistance.