fix(sensor): swap Fast Cadence Period Divisor and Status Trigger Type - #176
Open
stevebutler11 wants to merge 1 commit into
Open
stevebutler11 wants to merge 1 commit into
stevebutler11 wants to merge 1 commit into
Conversation
Mesh Model v1.1 Section 4.1.3 packs the first byte of the Sensor Cadence state as the Fast Cadence Period Divisor in bits 0-6 and the Status Trigger Type in bit 7. SensorCadence in SensorMessage.kt encodes & decodes them the other way round. This fixes sensor cadence encoding/decoding in accordance with Mesh Model v1.1 by putting triggerType as the MSB and the divisor as the LSBs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mesh Model v1.1 Section 4.1.3 packs the first byte of the Sensor Cadence state as the Fast Cadence Period Divisor in bits 0-6 and the Status Trigger Type in bit 7.
SensorCadence in SensorMessage.kt encodes & decodes them the other way round.
This fixes sensor cadence encoding/decoding in accordance with Mesh Model v1.1 by putting Status Trigger Type as the MSB and the Fast Cadence Period Divisor as the LSBs
NCS firmare (v3.1.1, subsys/bluetooth/mesh/sensor.c) confirms, as it encodes & decodes correctly: