Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
KqueueWatcheropens every entry of a recursive walk. Since #1017 onlyNotFoundon a child entry is skipped, so any other open error aborts the whole watch. On macOS that happens for setuid binaries such as/usr/bin/sudo(PermissionDenied) and for sockets (EOPNOTSUPP), so watching/or any tree containing them fails.add_watch_entriesnow skips child entries (never the root) that fail withNotFound,PermissionDeniedorUnsupported, both for walkdir errors and foradd_single_watcherrors. Other errors, such as a symlink loop or too many open files, still abort.The existing
failed_walk_registers_added_watchestest used an unreadable directory as its failing case; it now uses a symlink cycle, since an unreadable directory is skipped. A new test covers an unreadable file, an unreadable directory and a dangling symlink in one tree.Watching all of
/still stops on a symlink loop below/Library/Developerand on the open-file limit; I left both alone as they are separate behaviours.Ran live:
watch("/usr/bin", Recursive)on macOS ->Err(... PermissionDenied ... "/usr/bin/sudo")before,Ok(())after.Related Issues
Fixes #703