test(html): cover html_sanitizer wiring for 100% Clover coverage (#34)

* test(html): cover html_sanitizer wiring for 100% Clover coverage

Exercise allowlist/custom/empty sanitizer paths and buildForm transformer hooks.

* style(test): align Ckeditor5EditorTypeTest with php-cs-fixer

Author: HecFranco

tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -152,4 +152,23 @@ public function testMergedScalarChunkNormalizesThroughEarlyReturn(): void
         $processor = new Processor();
         $processor->processConfiguration(new Configuration(), [true]);
     }
+
+    public function testHtmlSanitizerDefaultsToNull(): void
+    {
+        $processor = new Processor();
+        $config    = $processor->processConfiguration(new Configuration(), [[]]);
+
+        self::assertArrayHasKey('html_sanitizer', $config);
+        self::assertNull($config['html_sanitizer']);
+    }
+
+    public function testFlatConfigurationPreservesHtmlSanitizer(): void
+    {
+        $processor = new Processor();
+        $config    = $processor->processConfiguration(new Configuration(), [[
+            'html_sanitizer' => 'allowlist',
+        ]]);
+
+        self::assertSame('allowlist', $config['html_sanitizer']);
+    }
 }

tests/Unit/DependencyInjection/NowoCkeditor5EditorExtensionTest.php

@@ -6,12 +6,15 @@
 
 use Nowo\Ckeditor5EditorBundle\DependencyInjection\Configuration;
 use Nowo\Ckeditor5EditorBundle\DependencyInjection\NowoCkeditor5EditorExtension;
+use Nowo\Ckeditor5EditorBundle\Form\Ckeditor5EditorType;
 use Nowo\Ckeditor5EditorBundle\Security\AllowlistCkeditor5HtmlSanitizer;
 use Nowo\Ckeditor5EditorBundle\Security\Ckeditor5HtmlSanitizerInterface;
 use PHPUnit\Framework\TestCase;
+use ReflectionMethod;
 use Symfony\Bundle\FrameworkBundle\DependencyInjection\FrameworkExtension;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Extension\Extension;
+use Symfony\Component\DependencyInjection\Reference;
 
 /**
  * @covers \Nowo\Ckeditor5EditorBundle\DependencyInjection\NowoCkeditor5EditorExtension
@@ -79,6 +82,48 @@ public function testLoadWithAllowlistHtmlSanitizer(): void
             AllowlistCkeditor5HtmlSanitizer::class,
             (string) $container->getAlias(Ckeditor5HtmlSanitizerInterface::class),
         );
+
+        $typeDefinition = $container->getDefinition(Ckeditor5EditorType::class);
+        $arg            = $typeDefinition->getArgument('$htmlSanitizer');
+        self::assertInstanceOf(Reference::class, $arg);
+        self::assertSame(Ckeditor5HtmlSanitizerInterface::class, (string) $arg);
+    }
+
+    public function testLoadWithHtmlSanitizerCustomService(): void
+    {
+        $container = new ContainerBuilder();
+        $extension = new NowoCkeditor5EditorExtension();
+        $extension->load([['html_sanitizer' => 'app.custom_sanitizer']], $container);
+
+        self::assertTrue($container->hasAlias(Ckeditor5HtmlSanitizerInterface::class));
+        self::assertSame('app.custom_sanitizer', (string) $container->getAlias(Ckeditor5HtmlSanitizerInterface::class));
+    }
+
+    public function testLoadWithHtmlSanitizerEmptyDisables(): void
+    {
+        $container = new ContainerBuilder();
+        $extension = new NowoCkeditor5EditorExtension();
+        $extension->load([['html_sanitizer' => '']], $container);
+
+        $typeDefinition = $container->getDefinition(Ckeditor5EditorType::class);
+        self::assertNull($typeDefinition->getArgument('$htmlSanitizer'));
+    }
+
+    public function testConfigureHtmlSanitizerRegistersAllowlistWhenMissing(): void
+    {
+        $container = new ContainerBuilder();
+        $container->register(Ckeditor5EditorType::class, Ckeditor5EditorType::class)
+            ->setAutowired(true)
+            ->setAutoconfigured(true)
+            ->addTag('form.type');
+
+        $extension = new NowoCkeditor5EditorExtension();
+        $method    = new ReflectionMethod(NowoCkeditor5EditorExtension::class, 'configureHtmlSanitizer');
+        $method->setAccessible(true);
+        $method->invoke($extension, $container, 'allowlist');
+
+        self::assertTrue($container->hasDefinition(AllowlistCkeditor5HtmlSanitizer::class));
+        self::assertTrue($container->hasAlias(Ckeditor5HtmlSanitizerInterface::class));
     }
 
     public function testPrependAddsTwigFormTheme(): void

tests/Unit/Form/Ckeditor5EditorTypeTest.php

@@ -5,9 +5,12 @@
 namespace Nowo\Ckeditor5EditorBundle\Tests\Unit\Form;
 
 use Nowo\Ckeditor5EditorBundle\Form\Ckeditor5EditorType;
+use Nowo\Ckeditor5EditorBundle\Form\DataTransformer\Ckeditor5HtmlSanitizeTransformer;
+use Nowo\Ckeditor5EditorBundle\Security\AllowlistCkeditor5HtmlSanitizer;
 use PHPUnit\Framework\TestCase;
 use ReflectionMethod;
 use Symfony\Component\Form\Extension\Core\Type\TextareaType;
+use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\Form\FormView;
 use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
@@ -400,4 +403,29 @@ public function testNormalizeThemePrivate(): void
         self::assertSame('light', $m->invoke($type, 'invalid-theme'));
         self::assertSame('auto', $m->invoke($type, ' AuTo '));
     }
+
+    public function testBuildFormAddsSanitizerTransformer(): void
+    {
+        $type = new Ckeditor5EditorType(
+            $this->sampleConfigs(),
+            'default',
+            $this->createCsrfTokenManager(),
+            new AllowlistCkeditor5HtmlSanitizer(),
+        );
+        $builder = $this->createMock(FormBuilderInterface::class);
+        $builder->expects(self::once())
+            ->method('addModelTransformer')
+            ->with(self::isInstanceOf(Ckeditor5HtmlSanitizeTransformer::class));
+
+        $type->buildForm($builder, []);
+    }
+
+    public function testBuildFormSkipsTransformerWithoutSanitizer(): void
+    {
+        $type    = $this->createType();
+        $builder = $this->createMock(FormBuilderInterface::class);
+        $builder->expects(self::never())->method('addModelTransformer');
+
+        $type->buildForm($builder, []);
+    }
 }