Skip to content

Performance issue in the definition of create_models, pilco/controllers.py(P1) #59

Description

@DLPerf

Hello, I found a performance issue in the definition of create_models, pilco/controllers.py, tf.ones will be calculated repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

The same issue exists in tf.ones in line 31 and tf.ones in line 19.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions