feat!: build unicode targets only by default

Author: idleberg

README.md

@@ -94,15 +94,15 @@ A Plugin repository is laid out like NSISDIR. The action checks this first and f
 
 ## Inputs
 
-| Name        | Default                | Description                                                                                                   |
-| ----------- | ---------------------- | ------------------------------------------------------------------------------------------------------------- |
-| `name`      |                        | Plugin name, i.e. the DLL basename scripts call as `Name::Func`.                                              |
-| `sources`   |                        | `msvc` and `mingw` only: C/C++ source globs (`.c`, `.cpp`, `.cxx`, `.cc`, `.rc`).                             |
-| `project`   |                        | `fpc` and `rust` only: path of the Pascal project file (`.dpr`, `.lpr`, `.pas`) or the plugin's `Cargo.toml`. |
-| `targets`   | `x86-ansi,x86-unicode` | Any of `x86-ansi`, `x86-unicode`, `amd64-unicode`, `arm64-unicode`.                                           |
-| `toolchain` | `msvc`                 | `msvc`, `fpc` or `rust` on a Windows runner, `mingw` on a Linux runner.                                       |
-| `crt`       | `static`               | C/C++ only: `static` links the C runtime in; `none` builds without it, entry point `DllMain`.                 |
-| `release`   | `true`                 | Attach the files to the release that triggered the run.                                                       |
+| Name        | Default                     | Description                                                                                                   |
+| ----------- | --------------------------- | ------------------------------------------------------------------------------------------------------------- |
+| `name`      |                             | Plugin name, i.e. the DLL basename scripts call as `Name::Func`.                                              |
+| `sources`   |                             | `msvc` and `mingw` only: C/C++ source globs (`.c`, `.cpp`, `.cxx`, `.cc`, `.rc`).                             |
+| `project`   |                             | `fpc` and `rust` only: path of the Pascal project file (`.dpr`, `.lpr`, `.pas`) or the plugin's `Cargo.toml`. |
+| `targets`   | `x86-unicode,amd64-unicode` | Any of `x86-ansi`, `x86-unicode`, `amd64-unicode`, `arm64-unicode`. `x86-ansi` is opt-in.                     |
+| `toolchain` | `msvc`                      | `msvc`, `fpc` or `rust` on a Windows runner, `mingw` on a Linux runner.                                       |
+| `crt`       | `static`                    | C/C++ only: `static` links the C runtime in; `none` builds without it, entry point `DllMain`.                 |
+| `release`   | `true`                      | Attach the files to the release that triggered the run.                                                       |
 
 Each Toolchain takes exactly one of `sources` and `project`; the action fails before building if the other one is set.
 List inputs are comma or newline separated, so paths may contain spaces.

action.yml

@@ -15,7 +15,7 @@ inputs:
     description: fpc and rust only; path of the Pascal project file (.dpr, .lpr, .pas) or the plugin's Cargo.toml
   targets:
     description: x86-ansi, x86-unicode, amd64-unicode, arm64-unicode
-    default: x86-ansi,x86-unicode
+    default: x86-unicode,amd64-unicode
   toolchain:
     description: msvc, fpc or rust (Windows runner), mingw (Linux runner)
     default: msvc

scripts/build_c.py

@@ -251,7 +251,7 @@ def build_mingw(cfg, arch, unicode, dll, objdir):
 def resolve():
     toolchain, targets, crt = (
         env("TOOLCHAIN", "msvc"),
-        split(env("TARGETS", "x86-ansi,x86-unicode")),
+        split(env("TARGETS", "x86-unicode,amd64-unicode")),
         env("CRT", "static"),
     )
     check_inputs(toolchain, targets, crt)
@@ -267,7 +267,7 @@ def resolve():
 def build():
     toolchain, targets, crt = (
         env("TOOLCHAIN", "msvc"),
-        split(env("TARGETS", "x86-ansi,x86-unicode")),
+        split(env("TARGETS", "x86-unicode,amd64-unicode")),
         env("CRT", "static"),
     )
     check_inputs(toolchain, targets, crt)

scripts/build_pascal.py

@@ -111,7 +111,7 @@ def fpc_command(cfg, arch, unicode, dll, objdir):
 
 
 def resolve():
-    check_inputs(split(env("TARGETS", "x86-ansi,x86-unicode")))
+    check_inputs(split(env("TARGETS", "x86-unicode,amd64-unicode")))
     temp = Path(env("RUNNER_TEMP", tempfile.gettempdir()))
     set_output("version", PINNED_NSIS_VERSION)
     set_output("plugin-api", temp / f"nsis-plugin-api-{PINNED_NSIS_VERSION}")
@@ -121,7 +121,7 @@ def resolve():
 
 
 def build():
-    targets = split(env("TARGETS", "x86-ansi,x86-unicode"))
+    targets = split(env("TARGETS", "x86-unicode,amd64-unicode"))
     check_inputs(targets)
     name = env("NAME")
     if not name:

scripts/build_rust.py

@@ -87,14 +87,14 @@ def find_dll(messages, manifest):
 
 
 def resolve():
-    check_inputs(split(env("TARGETS", "x86-ansi,x86-unicode")))
+    check_inputs(split(env("TARGETS", "x86-unicode,amd64-unicode")))
     # No Plugin API to fetch, but the installer is still compiled with the pinned NSIS
     set_output("version", PINNED_NSIS_VERSION)
     set_output("output-dir", Path(env("OUTPUT_DIR", "out")).resolve())
 
 
 def build():
-    targets = split(env("TARGETS", "x86-ansi,x86-unicode"))
+    targets = split(env("TARGETS", "x86-unicode,amd64-unicode"))
     check_inputs(targets)
     name = env("NAME")
     if not name: