Fix KeyConfig default capabilities - #168
Open
pollychen-lab wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #147.
KeyConfigdocumented encryption and decryption as enabled by default, andKeyConfig::new()already set both flags totrue, but the derivedDefaultimplementation left all booleans asfalse. This madeKeyConfig::default()create a key configuration that could neither encrypt nor decrypt.This PR replaces the derived default with an explicit
Defaultimplementation that delegates toKeyConfig::new(), keeping the idiomatic constructor aligned with the documented contract. It also adds a regression test for the expected default capabilities.Validation
cargo fmt --checkcargo test -p egide-transit test_key_config_default_matches_newcargo test -p egide-transitcargo clippy -p egide-transit --all-targets -- -D warnings