Repository navigation
feat(snippets): give the issues of the network, hint and cache snippets of Loading a stable code - #320
Merged
Conversation
…ts of Loading a stable code Back-Forward-Cache, Cache-Strategy-Analysis, Client-Side-Redirect-Detection, Compression-Audit, Prefetch-Resource-Validation, Priority-Hints-Audit, Resource-Hints, Resource-Hints-Validation, Server-Timing-Early-Hints, Service-Worker-Analysis, Speculation-Rules-Inspector, TTFB-Resources and TTFB-Sub-Parts carry a code in every issue, with their tables under Issue codes in snippets/SCHEMA.md, and leave PENDING_ISSUE_CODES. The issues about one resource name its URL in target, a Service Worker its scope, and a reason the browser gives for not restoring the page from bfcache, under one code, the reason and its frame, since the reasons are text of the browser and not literals of the snippet. Cache-Strategy-Analysis keeps its id, which the code repeats. The catalog test reads codes in single quotes, as three of these snippets are written. No message changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 5 of the stable issue codes (#316 to #319): the snippets of Loading about the network, hints and caching carry a code in every issue, with their tables under Issue codes in
snippets/SCHEMA.md.PENDING_ISSUE_CODES: Back-Forward-Cache, Cache-Strategy-Analysis, Client-Side-Redirect-Detection, Compression-Audit, Prefetch-Resource-Validation, Priority-Hints-Audit, Resource-Hints, Resource-Hints-Validation, Server-Timing-Early-Hints, Service-Worker-Analysis, Speculation-Rules-Inspector, TTFB-Resources and TTFB-Sub-Parts.target: the URL of the resource in Prefetch-Resource-Validation, Priority-Hints-Audit, Resource-Hints (excepttoo-many-preloads) and Cache-Strategy-Analysis (exceptheader-coverage), and the scope in the per-scope issues of Service-Worker-Analysis.unload-listener,response-cache-control-no-store…) are text of the browser, not literals of the snippet, so they share the codenot-restored, with the reason and its frame intarget. The blockers the snippet detects itself have their own codes.idper issue; the code repeats it, andidstays for whoever reads it.large-total-size,slow-startup,low-cache-hit-rateandslow-ttfb.No message changes. The skills,
dist/andllms-full.txtare regenerated. 10 snippets of Loading are left for the last PR, which makes the code mandatory.Test plan
PENDING_ISSUE_CODES, and passes with their codes and tables (local).no-prefetch,no-rulesandno-resources; every issue of Priority-Hints-Audit hascodeandtarget;duplicate-uncachedhas the whole URL intarget;unload-handlerfor anonunloadhandler; eachnot-restorednames its reason intarget.check:consistency,check:emoji, CLI unit 329 of 329, CLI e2e 575 of 575,test:skills179 of 179,test:site44 of 44,test:extension66 of 66,test:extension:e2e77 of 77 (local).as, a font preload withoutcrossorigin, an unused preconnect, a prefetch of a script the page uses, a preload withfetchpriority="low", broken speculation rules, anonunloadhandler and scripts sent withno-storeand uncompressed returns the expected codes from Resource-Hints, Prefetch-Resource-Validation, Priority-Hints-Audit, Speculation-Rules-Inspector, Back-Forward-Cache, Cache-Strategy-Analysis, Compression-Audit and Server-Timing-Early-Hints, with the URL intargetof each per-resource issue.