Skip to content

feat(snippets): give the issues of the CSS, font and image snippets of Loading a stable code, and require one - #321

Merged
nucliweb merged 1 commit into
mainfrom
feat/issue-codes-loading-css-fonts-images
Oct 25, 2026
Merged

nucliweb merged 1 commit into
mainfrom
feat/issue-codes-loading-css-fonts-images

Conversation

@nucliweb

Copy link
Copy Markdown
Owner

Summary

Step 6, the last of the snippets, of the stable issue codes (#316 to #320): the snippets of Loading about CSS, fonts and images carry a code in every issue, and the code is required from now on.

  • 10 snippets get their codes: Content-Visibility, Critical-CSS-Detection, CSS-Media-Queries-Analysis, Find-Above-The-Fold-Lazy-Loaded-Images, Find-Images-With-Lazy-and-Fetchpriority, Find-non-Lazy-Loaded-Images-outside-of-the-viewport, Find-render-blocking-resources, Fonts-Preloaded-Loaded-and-used-above-the-fold, Inline-CSS-Info-and-Size and Webfont-Usage-Analyzer.
  • PENDING_ISSUE_CODES is empty and goes away, with its exceptions in the contract and the catalog test: every snippet that returns issues must give each one a code and have its table under Issue codes in snippets/SCHEMA.md.
  • target: Content-Visibility names the element by its selector, Fonts-Preloaded-Loaded-and-used-above-the-fold the font, and Webfont-Usage-Analyzer the font file by its URL, or the face when it has none, in load-failed, loaded-unused and redeclared.
  • Webfont-Usage-Analyzer built one issue with one of two messages for a loaded face nobody uses; it builds the issue for each situation, loaded-unused or redeclared, so each has its literal code.
  • Severity by threshold keeps one code: wide-rules in CSS-Media-Queries-Analysis.
  • CONTRIBUTING.md: the rule of the codes next to the other rules of the contract, the table under Issue codes in the entry of SCHEMA.md for a new snippet, and in the checklist of a pull request.

No message changes. The skills, dist/ and llms-full.txt are regenerated. Two findings of the manual run come from before this work and are noted for later: Content-Visibility never raises missing-intrinsic-size in Chrome, which computes contain-intrinsic-size: auto none for content-visibility: auto without a declared size, and Cache-Strategy-Analysis repeats its header issues once per request of the same resource (seen in #320).

Test plan

  • The catalog test fails for the 10 snippets once they leave PENDING_ISSUE_CODES, and passes with their codes and tables; with the list gone, every other snippet passes as it is (local).
  • E2e (local): loaded-unused with a target, blocking-font-display, redeclared with the URL of the file in target and shadowed in Webfont-Usage-Analyzer; the contract runs every snippet with no exception for issues without a code.
  • Lint, check:consistency, check:emoji, CLI unit 329 of 329, CLI e2e 575 of 575, test:skills 179 of 179, test:site 44 of 44, test:extension 66 of 66, test:extension:e2e 77 of 77 (local).
  • By hand with the CLI (local): a page with a large blocking stylesheet, inline styles in <body>, a lazy image in the viewport with fetchpriority="high", eager images far below, a font preload without crossorigin and a face that fails to load returns the expected codes from the 10 snippets, with the font in target. The audit workflow on that page returns 24 issues, none without a code.

…f Loading a stable code, and require one

Content-Visibility, Critical-CSS-Detection, CSS-Media-Queries-Analysis, Find-Above-The-Fold-Lazy-Loaded-Images, Find-Images-With-Lazy-and-Fetchpriority, Find-non-Lazy-Loaded-Images-outside-of-the-viewport, Find-render-blocking-resources, Fonts-Preloaded-Loaded-and-used-above-the-fold, Inline-CSS-Info-and-Size and Webfont-Usage-Analyzer carry a code in every issue, with their tables under Issue codes in snippets/SCHEMA.md. They were the last of PENDING_ISSUE_CODES, which goes away: the contract and the catalog test hold every snippet to its codes. Webfont-Usage-Analyzer chose between two messages for one issue; it builds one issue per situation now, loaded-unused and redeclared. The issues about one font file or element name it in target. CONTRIBUTING.md describes the rule for a new snippet. No message changes.
@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
webperf-snippets Ready Ready Preview Oct 25, 2026 11:36am UTC

@nucliweb
nucliweb merged commit 3c343fb into main Oct 25, 2026
3 checks passed
@nucliweb
nucliweb deleted the feat/issue-codes-loading-css-fonts-images branch October 25, 2026 11:56

This branch was successfully deployed

1 active deployment
Preview — 63167bf3 Deployed Oct 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant