Repository navigation
feat(snippets): give the issues of the CSS, font and image snippets of Loading a stable code, and require one - #321
Merged
Conversation
…f Loading a stable code, and require one Content-Visibility, Critical-CSS-Detection, CSS-Media-Queries-Analysis, Find-Above-The-Fold-Lazy-Loaded-Images, Find-Images-With-Lazy-and-Fetchpriority, Find-non-Lazy-Loaded-Images-outside-of-the-viewport, Find-render-blocking-resources, Fonts-Preloaded-Loaded-and-used-above-the-fold, Inline-CSS-Info-and-Size and Webfont-Usage-Analyzer carry a code in every issue, with their tables under Issue codes in snippets/SCHEMA.md. They were the last of PENDING_ISSUE_CODES, which goes away: the contract and the catalog test hold every snippet to its codes. Webfont-Usage-Analyzer chose between two messages for one issue; it builds one issue per situation now, loaded-unused and redeclared. The issues about one font file or element name it in target. CONTRIBUTING.md describes the rule for a new snippet. No message changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 of 6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 6, the last of the snippets, of the stable issue codes (#316 to #320): the snippets of Loading about CSS, fonts and images carry a code in every issue, and the code is required from now on.
PENDING_ISSUE_CODESis empty and goes away, with its exceptions in the contract and the catalog test: every snippet that returns issues must give each one a code and have its table under Issue codes insnippets/SCHEMA.md.target: Content-Visibility names the element by its selector, Fonts-Preloaded-Loaded-and-used-above-the-fold the font, and Webfont-Usage-Analyzer the font file by its URL, or the face when it has none, inload-failed,loaded-unusedandredeclared.loaded-unusedorredeclared, so each has its literal code.wide-rulesin CSS-Media-Queries-Analysis.CONTRIBUTING.md: the rule of the codes next to the other rules of the contract, the table under Issue codes in the entry ofSCHEMA.mdfor a new snippet, and in the checklist of a pull request.No message changes. The skills,
dist/andllms-full.txtare regenerated. Two findings of the manual run come from before this work and are noted for later: Content-Visibility never raisesmissing-intrinsic-sizein Chrome, which computescontain-intrinsic-size: auto noneforcontent-visibility: autowithout a declared size, and Cache-Strategy-Analysis repeats its header issues once per request of the same resource (seen in #320).Test plan
PENDING_ISSUE_CODES, and passes with their codes and tables; with the list gone, every other snippet passes as it is (local).loaded-unusedwith atarget,blocking-font-display,redeclaredwith the URL of the file intargetandshadowedin Webfont-Usage-Analyzer; the contract runs every snippet with no exception for issues without a code.check:consistency,check:emoji, CLI unit 329 of 329, CLI e2e 575 of 575,test:skills179 of 179,test:site44 of 44,test:extension66 of 66,test:extension:e2e77 of 77 (local).<body>, a lazy image in the viewport withfetchpriority="high", eager images far below, a font preload withoutcrossoriginand a face that fails to load returns the expected codes from the 10 snippets, with the font intarget. Theauditworkflow on that page returns 24 issues, none without a code.