Skip to content

feat(extension): filter the audit table to keep errors and warnings in focus - #323

Merged
nucliweb merged 1 commit into
mainfrom
feat/extension-audit-filter
Oct 25, 2026
Merged

nucliweb merged 1 commit into
mainfrom
feat/extension-audit-filter

Conversation

@nucliweb

Copy link
Copy Markdown
Owner

Summary

The audit table of the extension mixes the snippets that found something to fix with the ones that only give information or found nothing, so the errors and warnings get lost among 22 rows. A filter keeps them in focus.

  • The table opens on the snippets with errors or warnings. Three buttons above it change the rows it shows: Errors, Errors and warnings, and All, each with its count.
  • Below the table, a line says how many snippets the filter leaves out (11 more snippets with info only or nothing to fix, 17 more snippets without errors), with Show all.
  • When the filter leaves the table empty, it says so: No snippet has errors.
  • The panel remembers the choice in the synced settings, like the reload before the audit, so it follows the user to every Chrome they sign in to. A value it does not know shows every row and falls back to Errors and warnings.
  • Copy JSON and Download JSON keep every snippet, whatever the filter. While the audit runs, every row shows as it arrives; the filter applies once it is done.

The logic is in extension/lib/audit.js (filterRows, filterCounts), the setting in extension/lib/settings.js (auditFilter), and the extension page and the changelog describe it.

Screenshots of the panel with the seeded page of the e2e tests: Errors and warnings, Errors, and Errors and warnings in the dark theme.

Test plan

  • Unit tests (local): filterRows keeps the snippets with errors, with errors or warnings, or all of them, a failed snippet counts as an error and an unknown filter shows every row; filterCounts; auditFilter defaults to issues and goes to the synced area. They failed before the change.
  • test:extension:e2e (local, 77 of 77): after an audit of the seeded page the table shows only rows with errors or warnings, with the line of the rows left out and All 22; Errors shows only rows with errors; Show all lists the 22 and the line goes away; the choice survives closing DevTools; Copy JSON keeps the 22 results with the filter on Errors and warnings. The audit test failed with the panel of main.
  • Lint, check:emoji, test:extension 67 of 67, test:site 44 of 44 (local).
  • By hand (local): screenshots of the panel in the light and dark themes, attached.
  • In Chrome, with the extension loaded unpacked.

…n focus

The audit table opens on the snippets with errors or warnings. Three buttons above it, Errors, Errors and warnings, and All, change the rows it shows, each with the number of rows it has, and a line below the table says how many snippets the filter leaves out, with a link to show them all. The panel remembers the choice in the synced settings, as it does the reload before the audit, and Copy JSON and Download JSON keep every snippet. While the audit runs, every row shows as it arrives.
@vercel

vercel Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
webperf-snippets Ready Ready Preview Oct 25, 2026 5:59pm UTC

@nucliweb
nucliweb merged commit 0960a47 into main Oct 25, 2026
3 checks passed
@nucliweb
nucliweb deleted the feat/extension-audit-filter branch October 25, 2026 23:19
nucliweb added a commit that referenced this pull request Oct 25, 2026
The changelog keeps both sections of Unreleased: Added, from the audit filter of the extension (#323), and Changed, from this pull request.

This branch was successfully deployed

1 active deployment
Preview — 09c5e64d Deployed Oct 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant