Repository navigation
feat(extension): filter the audit table to keep errors and warnings in focus - #323
Merged
Merged
Conversation
…n focus The audit table opens on the snippets with errors or warnings. Three buttons above it, Errors, Errors and warnings, and All, change the rows it shows, each with the number of rows it has, and a line below the table says how many snippets the filter leaves out, with a link to show them all. The panel remembers the choice in the synced settings, as it does the reload before the audit, and Copy JSON and Download JSON keep every snippet. While the audit runs, every row shows as it arrives.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nucliweb
added a commit
that referenced
this pull request
Oct 25, 2026
The changelog keeps both sections of Unreleased: Added, from the audit filter of the extension (#323), and Changed, from this pull request.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The audit table of the extension mixes the snippets that found something to fix with the ones that only give information or found nothing, so the errors and warnings get lost among 22 rows. A filter keeps them in focus.
11 more snippets with info only or nothing to fix,17 more snippets without errors), with Show all.No snippet has errors.The logic is in
extension/lib/audit.js(filterRows,filterCounts), the setting inextension/lib/settings.js(auditFilter), and the extension page and the changelog describe it.Screenshots of the panel with the seeded page of the e2e tests: Errors and warnings, Errors, and Errors and warnings in the dark theme.
Test plan
filterRowskeeps the snippets with errors, with errors or warnings, or all of them, a failed snippet counts as an error and an unknown filter shows every row;filterCounts;auditFilterdefaults toissuesand goes to the synced area. They failed before the change.test:extension:e2e(local, 77 of 77): after an audit of the seeded page the table shows only rows with errors or warnings, with the line of the rows left out andAll 22; Errors shows only rows with errors; Show all lists the 22 and the line goes away; the choice survives closing DevTools; Copy JSON keeps the 22 results with the filter on Errors and warnings. The audit test failed with the panel ofmain.check:emoji,test:extension67 of 67,test:site44 of 44 (local).