feat(control): panels, resize, goals, tasks and log args for external agents

Fixes from an external agent's difficulty report (CONTROL_REPORT.md):
- QDockWidget panels (workspace panels) get an adapter: select, close, float.
  A tabified panel behind its tab is off-screen, not hidden, so reachability
  uses ids::isShownToUser / isBehindTab. /instance lists workspacePanels.
- /ui/do op=resize drags the nearest edge setting that size (panel
  separator, floating window, QSplitter / ADS CDockSplitter handle, the
  central area via a panel beside it).
- Hidden-action twins (ids::setAlternative): the 409 names the visible one.
- Goal dialogs, Edit Tasks and the empty terminal panel's task rows have
  stable ids; text-less buttons are labelled by the labels inside them;
  /instance lists workspaceTasks (no env).
- /log entries and action events carry args (strings capped, password
  fields masked).
- Commands outside an open popup menu are refused (except a click, which
  closes it): closing the menu's owner under its exec() double-freed it.
- Lint fixes in src/control; skill version 3; README mentions the API.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: nullmastermind

README.md

@@ -14,6 +14,8 @@ In a chat, a finished turn folds into a single "Worked for 2m14s" row; click it
 
 There is also a Goal Agent: pick an ACP judge (Claude Code, Codex, Opencode) or a Custom API endpoint that speaks Anthropic's Messages API. You set success criteria and it drives the working agent until those criteria hold, or attach a goal to an existing conversation. Criteria presets can be saved globally, or into the current project's `.agents/.goals` folder so they travel with the repo; files already in that folder show up in the load list. A judge that needs a human action, or that hits the iteration cap with the criterion still unmet, stops and hands the criterion back instead of marking the goal done. With Prefix /goal checked, the first criterion is sent immediately when the agent supports `/goal`. If a reply is still running and the agent does not support `/goal`, that goal waits in the send queue so the current reply is not stopped. Later criteria wait until the previous is achieved. Send with Goal defaults to the agent's own `/goal` command instead: each criterion goes out on its own, with no separate judge. A `/goal` typed in the composer is sent while a turn is still running only when the agent supports that command; otherwise it waits in the queue. A goal is not judged, and auto compact does not run, while the agent still has background tasks running or a wake-up turn pending. When a goal is achieved, the session can compact automatically. Prompts sent while an agent is still working are queued and delivered when it finishes. AI chats group by project, with a session strip to switch conversations in the same dock. Open chats come back after a restart and resume their agent session on the first prompt. A local Claude Code chat can be moved to another agent from the agent button in the dock's title bar, keeping its transcript. The composer can ask the agent to work in a new git worktree. When you commit, AI can write the commit message from your staged diff. That generator (and other LLM calls) can talk to an OpenAI-compatible endpoint or Anthropic's Messages API. Leave the commit box empty (when not amending) and Commit lets you pick an ACP agent to do the commit. Protocol details and how to wire up a custom ACP agent are in [doc/AcpAgents.md](doc/AcpAgents.md).
 
+An outside AI agent can also drive NotepadAI itself. AI ▸ Connect External Agent turns on a local HTTP API (off by default, token-protected) and gives you a prompt to hand to the agent; it fetches a skill from the app describing how to use it. The agent works only through the controls you see: menus, buttons, fields, tabs, editors, terminals and chats, each step highlighted on screen and listed in an activity log, with a Stop button in the status bar. Workspaces, terminals and tasks, AI sessions, goals, git, settings and pane sizes are all reachable this way.
+
 ### Git
 
 Inline blame, gutter diff markers, commit history, staging and unstaging (including bulk actions on a status section), a branch picker, and git status decorations in the file tree. Linked worktrees show up in the repository list; you can remove one, or merge its branch into the main checkout and then remove it. Merge and rebase flows are included, with an interactive-rebase editor and a 3-way conflict viewer. Diffs and commits open as editor tabs in a GitHub-style view with a file tree, collapsible files, word-level highlights, and syntax colouring. Most operations never shell out to `git`: it diffs with xdiff and parses status, log, and blame itself.

src/control/ControlActionIndex.h

@@ -18,6 +18,8 @@
 #include <QString>
 #include <QStringList>
 
+#include <cstdint>
+
 class QAction;
 class QMainWindow;
 class QMenu;
@@ -31,7 +33,7 @@ namespace control {
 class ControlActionIndex
 {
 public:
-    enum class Location { MenuBar, ToolBar, Window, Popup };
+    enum class Location : std::uint8_t { MenuBar, ToolBar, Window, Popup };
 
     struct Entry
     {

src/control/ControlActivityLog.cpp

@@ -12,6 +12,7 @@
 
 #include <QBrush>
 #include <QGuiApplication>
+#include <QJsonDocument>
 #include <QJsonObject>
 #include <QPalette>
 
@@ -59,11 +60,23 @@ QString ControlActivityLog::displayText(const Entry &e)
 {
     QString text = e.time.toString(QStringLiteral("HH:mm:ss")) + QStringLiteral("  ") + e.op
                    + QStringLiteral("  ") + (e.label.isEmpty() ? e.target : e.label);
+    if (!e.args.isEmpty())
+        text += QStringLiteral(" ← ") + argsText(e.args);
     if (!e.ok)
         text += QStringLiteral("  — ") + e.detail;
     return text;
 }
 
+QString ControlActivityLog::argsText(const QJsonObject &args)
+{
+    if (args.size() == 1) {
+        const QJsonValue v = *args.constBegin();
+        if (v.isString())
+            return v.toString();
+    }
+    return QString::fromUtf8(QJsonDocument(args).toJson(QJsonDocument::Compact));
+}
+
 QJsonArray ControlActivityLog::toJson(int limit) const
 {
     QJsonArray out;
@@ -78,6 +91,8 @@ QJsonArray ControlActivityLog::toJson(int limit) const
             o.insert(QStringLiteral("label"), e.label);
         if (!e.detail.isEmpty())
             o.insert(QStringLiteral("detail"), e.detail);
+        if (!e.args.isEmpty())
+            o.insert(QStringLiteral("args"), e.args);
         out.append(o);
     }
     return out;

src/control/ControlActivityLog.h

@@ -14,6 +14,7 @@
 #include <QAbstractListModel>
 #include <QDateTime>
 #include <QJsonArray>
+#include <QJsonObject>
 #include <QString>
 #include <QVector>
 
@@ -35,7 +36,8 @@ class ControlActivityLog : public QAbstractListModel
         QString target; // id
         QString label;  // what the user sees ("AI ▸ AI Agents…")
         bool ok = true;
-        QString detail; // error or extra
+        QString detail;   // error or extra
+        QJsonObject args; // the request minus its id: value, text, op + args, ...
     };
 
     explicit ControlActivityLog(QObject *parent = nullptr);
@@ -47,6 +49,8 @@ class ControlActivityLog : public QAbstractListModel
     // Newest `limit` entries, oldest first.
     QJsonArray toJson(int limit = kCapacity) const;
     static QString displayText(const Entry &entry);
+    // The arguments as one short line: a lone text/value/keys as itself, else compact JSON.
+    static QString argsText(const QJsonObject &args);
 
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
     QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;

src/control/ControlApi.cpp

@@ -45,10 +45,12 @@ namespace control {
 
 namespace {
 
+// NOLINTBEGIN(bugprone-throwing-static-initialization): ApplicationSetting stores std::function (file-scope idiom).
 const ApplicationSetting<bool> kEnabled{"ControlApi/Enabled", false};
 const ApplicationSetting<int> kPort{"ControlApi/Port", int(ControlApi::kDefaultPort)};
 const ApplicationSetting<bool> kAllowLan{"ControlApi/AllowLan", false};
 const ApplicationSetting<QString> kLanAddress{"ControlApi/LanAddress", QString()};
+// NOLINTEND(bugprone-throwing-static-initialization)
 
 // Object name of a pending /wait (a child of the API, deleted on Stop).
 constexpr char kPendingWait[] = "controlPendingWait";
@@ -198,7 +200,7 @@ void ControlApi::setAllowLan(bool on)
 
 QString ControlApi::lanAddress() const
 {
-    const QString saved = m_host.settings ? m_host.settings->get(kLanAddress) : QString();
+    QString saved = m_host.settings ? m_host.settings->get(kLanAddress) : QString();
     const QStringList available = lanAddresses();
     if (available.contains(saved))
         return saved;
@@ -353,7 +355,7 @@ void ControlApi::stopServer()
 
 void ControlApi::route(const QByteArray &method, const QByteArray &path, Handler handler)
 {
-    m_routes.insert(routeKey(method, path), std::move(handler));
+    m_routes.emplace(routeKey(method, path), std::move(handler));
 }
 
 void ControlApi::notePicker(const QString &id, const QString &valueHint)
@@ -366,7 +368,7 @@ QStringList ControlApi::pickerValues(const QJsonValue &value)
     QStringList out;
     if (value.isArray()) {
         const QJsonArray array = value.toArray();
-        for (const QJsonValue &v : array)
+        for (const auto &v : array)
             out.append(v.toVariant().toString());
     } else {
         out = value.toVariant().toString().split(QLatin1Char('\n'));
@@ -375,7 +377,7 @@ QStringList ControlApi::pickerValues(const QJsonValue &value)
 }
 
 void ControlApi::logAction(const QString &op, const QString &target, const QString &label, bool ok,
-                           const QString &detail)
+                           const QString &detail, const QJsonObject &args)
 {
     ControlActivityLog::Entry e;
     e.time = QDateTime::currentDateTime();
@@ -384,12 +386,15 @@ void ControlApi::logAction(const QString &op, const QString &target, const QStri
     e.label = label;
     e.ok = ok;
     e.detail = detail;
+    e.args = args;
     if (events::wanted()) {
         QJsonObject data{{QStringLiteral("op"), op}, {QStringLiteral("label"), label}, {QStringLiteral("ok"), ok}};
         if (!target.isEmpty())
             data.insert(QStringLiteral("id"), target);
         if (!detail.isEmpty())
             data.insert(QStringLiteral("detail"), detail);
+        if (!args.isEmpty())
+            data.insert(QStringLiteral("args"), args);
         events::publish(QStringLiteral("action"), data);
     }
     m_log->append(std::move(e));
@@ -530,7 +535,16 @@ void ControlApi::handleTrigger(const QJsonObject &body, const Reply &reply)
     const QString label = menuLabel(r.menuPath, ControlActionIndex::plainText(r.action->text()));
     if (!r.visible) {
         logAction(QStringLiteral("trigger"), id, label, false, QStringLiteral("not visible"));
-        reply.error(409, QStringLiteral("'%1' is hidden; a user could not click it").arg(label));
+        QString message = QStringLiteral("'%1' is hidden; a user could not click it").arg(label);
+        const QString alternative = r.action->property(ids::kAlternativeProperty).toString();
+        if (!alternative.isEmpty()) {
+            const ControlActionIndex::Resolved alt = index.resolve(alternative);
+            if (alt.action && alt.visible && alt.enabled)
+                message += QStringLiteral(". '%1' (id %2) does the same")
+                               .arg(menuLabel(alt.menuPath, ControlActionIndex::plainText(alt.action->text())),
+                                    alternative);
+        }
+        reply.error(409, message);
         return;
     }
     if (!r.enabled) {
@@ -545,6 +559,12 @@ void ControlApi::handleTrigger(const QJsonObject &body, const Reply &reply)
         reply.error(409, QStringLiteral("the modal dialog '%1' is open; answer it first").arg(ids::nodeId(modal).id));
         return;
     }
+    // Nor while a menu is open (its exec() loop is on the stack): only its own items.
+    if (QApplication::activePopupWidget() && !r.inPopup) {
+        logAction(QStringLiteral("trigger"), id, label, false, QStringLiteral("a menu is open"));
+        reply.error(409, QStringLiteral("a menu is open; pick from it, or close it with POST /ui/key {\"keys\": \"Escape\"}"));
+        return;
+    }
 
     const bool hasValue = body.contains(QStringLiteral("value"));
     const QStringList values = hasValue ? pickerValues(body.value(QStringLiteral("value"))) : QStringList();
@@ -573,14 +593,59 @@ void ControlApi::handleTrigger(const QJsonObject &body, const Reply &reply)
 
     if (!r.inPopup)
         m_feedback->flashAction(r.action);
-    logAction(QStringLiteral("trigger"), id,
-              hasValue ? label + QStringLiteral(" ← ") + values.join(QStringLiteral(", ")) : label);
+    logAction(QStringLiteral("trigger"), id, label, true, QString(),
+              hasValue ? QJsonObject{{QStringLiteral("value"), QJsonArray::fromStringList(values)}} : QJsonObject());
     runCommand(reply, std::move(act), {{QStringLiteral("action"), id}, {QStringLiteral("label"), label}},
                hasValue ? &values : nullptr);
 }
 
 // --- /ui ---------------------------------------------------------------------
 
+namespace {
+
+// A log line's copy of a string: bounded, so a pasted file cannot fill the log.
+QJsonValue loggedValue(const QJsonValue &v)
+{
+    constexpr qsizetype kMaxChars = 120;
+    if (v.isString()) {
+        const QString s = v.toString();
+        return s.size() > kMaxChars ? QJsonValue(s.left(kMaxChars) + QStringLiteral("…")) : v;
+    }
+    if (v.isArray()) {
+        QJsonArray out;
+        const QJsonArray array = v.toArray();
+        for (const auto &item : array)
+            out.append(loggedValue(item));
+        return out;
+    }
+    if (v.isObject()) {
+        QJsonObject out;
+        const QJsonObject o = v.toObject();
+        for (auto it = o.constBegin(); it != o.constEnd(); ++it)
+            out.insert(it.key(), loggedValue(it.value()));
+        return out;
+    }
+    return v;
+}
+
+// What the step was given (the body minus its id), as the log keeps it.
+// Never what goes into a password field.
+QJsonObject loggedArgs(const QJsonObject &body, const QWidget *target)
+{
+    QJsonObject args;
+    const auto *edit = qobject_cast<const QLineEdit *>(target);
+    const bool secret = edit && edit->echoMode() != QLineEdit::Normal;
+    for (auto it = body.constBegin(); it != body.constEnd(); ++it) {
+        if (it.key() == QLatin1String("id"))
+            continue;
+        const bool typed = it.key() == QLatin1String("text") || it.key() == QLatin1String("value");
+        args.insert(it.key(), secret && typed ? QJsonValue(QStringLiteral("••••")) : loggedValue(it.value()));
+    }
+    return args;
+}
+
+} // namespace
+
 void ControlApi::uiCommand(const QJsonObject &body, const Reply &reply, const QString &op, bool needsTarget,
                            const std::function<QString(const ui::Target &)> &fn)
 {
@@ -594,7 +659,7 @@ void ControlApi::uiCommand(const QJsonObject &body, const Reply &reply, const QS
         }
         const QString blocked = ui::blockedReason(target, op);
         if (!blocked.isEmpty()) {
-            logAction(op, id, ui::labelOf(target.widget), false, blocked);
+            logAction(op, id, ui::labelOf(target.widget), false, blocked, loggedArgs(body, target.widget));
             reply.error(409, blocked);
             return;
         }
@@ -606,20 +671,9 @@ void ControlApi::uiCommand(const QJsonObject &body, const Reply &reply, const QS
     QString label = target.widget ? ui::labelOf(target.widget) : QString();
     if (!target.part.isEmpty())
         label += QStringLiteral(" @ ") + target.part;
-    QString detail;
-    if (body.contains(QStringLiteral("text")) || body.contains(QStringLiteral("value"))) {
-        const QJsonValue v = body.contains(QStringLiteral("text")) ? body.value(QStringLiteral("text"))
-                                                                    : body.value(QStringLiteral("value"));
-        auto *edit = target.widget ? qobject_cast<QLineEdit *>(target.widget) : nullptr;
-        // Never echo what goes into a password field.
-        detail = edit && edit->echoMode() != QLineEdit::Normal ? QStringLiteral("••••")
-                                                               : v.toVariant().toString().left(120);
-    } else if (body.contains(QStringLiteral("keys"))) {
-        detail = body.value(QStringLiteral("keys")).toVariant().toString();
-    }
     if (target.widget)
         m_feedback->flash(target.widget, ui::targetRect(target));
-    logAction(op, id, detail.isEmpty() ? label : label + QStringLiteral(" ← ") + detail);
+    logAction(op, id, label, true, QString(), loggedArgs(body, target.widget));
 
     QPointer<QWidget> widget = target.widget;
     const QString part = target.part;
@@ -714,7 +768,7 @@ void ControlApi::registerUiRoutes()
         const QJsonValue keys = body.value(QStringLiteral("keys"));
         if (keys.isArray()) {
             const QJsonArray array = keys.toArray();
-            for (const QJsonValue &k : array)
+            for (const auto &k : array)
                 sequences.append(k.toString());
         } else {
             sequences.append(keys.toString());
@@ -770,7 +824,7 @@ bool shownTextContains(const QJsonValue &v, const QString &needle, const QString
         return key != QLatin1String("id") && key != QLatin1String("key") && v.toString().contains(needle);
     if (v.isArray()) {
         const QJsonArray a = v.toArray();
-        for (const QJsonValue &e : a) {
+        for (const auto &e : a) {
             if (shownTextContains(e, needle, key))
                 return true;
         }
@@ -824,6 +878,7 @@ bool eventMatches(const QString &pattern, const QJsonObject &match, const QStrin
     return true;
 }
 
+// NOLINTNEXTLINE(bugprone-throwing-static-initialization): a QStringList table cannot have noexcept dynamic init.
 const QStringList kStates{QStringLiteral("exists"),  QStringLiteral("gone"),     QStringLiteral("visible"),
                           QStringLiteral("hidden"),  QStringLiteral("enabled"),  QStringLiteral("disabled"),
                           QStringLiteral("idle"),    QStringLiteral("waitingForUser")};
@@ -839,7 +894,8 @@ void ControlApi::registerEventRoutes()
         const QString id = body.value(QStringLiteral("id")).toString();
         QStringList states;
         if (const QJsonValue sv = body.value(QStringLiteral("state")); sv.isArray()) {
-            for (const QJsonValue &v : sv.toArray())
+            const QJsonArray list = sv.toArray();
+            for (const auto &v : list)
                 states.append(v.toString());
         } else if (!sv.toString().isEmpty()) {
             states.append(sv.toString());

src/control/ControlApi.h

@@ -65,7 +65,7 @@ class ControlApi : public QObject
 
 public:
     static constexpr int kApiVersion = 1;
-    static constexpr int kSkillVersion = 1;
+    static constexpr int kSkillVersion = 3;
     static constexpr quint16 kDefaultPort = 47821;
     // The keychain entry holding the token.
     static constexpr char kTokenSecretKey[] = "control-api-token";
@@ -126,7 +126,7 @@ class ControlApi : public QObject
     QString pickerHint(const QString &id) const { return m_pickers.value(id); }
     // Logs the step, flashes nothing (callers flash what they touched).
     void logAction(const QString &op, const QString &target, const QString &label, bool ok = true,
-                   const QString &detail = QString());
+                   const QString &detail = QString(), const QJsonObject &args = {});
 
     // Runs `act` as a command: answers with {ok, completed, effects} once it
     // finished or a modal dialog / popup took over. With `pickerValues`, the

src/control/ControlAudit.cpp

@@ -42,6 +42,9 @@ bool isPartOfAnotherControl(const QWidget *w)
 {
     if (qstrncmp(w->metaObject()->className(), "ads::", 5) == 0)
         return true;
+    // QMainWindow's own bar over tabbed panels: driven through the panels.
+    if (qobject_cast<const QTabBar *>(w) && qobject_cast<const QMainWindow *>(w->parentWidget()))
+        return true;
     for (const QWidget *p = w->parentWidget(); p; p = p->parentWidget()) {
         if (ids::isIgnored(p))
             return true;

src/control/ControlEvents.cpp

@@ -73,7 +73,7 @@ void ControlEvents::setSubscribers(int count)
 quint64 ControlEvents::addWaiter(Waiter waiter)
 {
     const quint64 id = m_nextWaiter++;
-    m_waiters.insert(id, std::move(waiter));
+    m_waiters.emplace(id, std::move(waiter));
     updateActive();
     return id;
 }

src/control/ControlHttp.h

@@ -17,6 +17,8 @@
 #include <QPair>
 #include <QString>
 
+#include <cstdint>
+
 // Minimal HTTP/1.1 for the Control API: Content-Length bodies only, keep-alive,
 // pipelining. Pure, no sockets.
 namespace control::http {
@@ -40,7 +42,7 @@ struct Request
 class RequestParser
 {
 public:
-    enum class State { NeedMore, Complete, Error };
+    enum class State : std::uint8_t { NeedMore, Complete, Error };
 
     static constexpr qsizetype kMaxHeadBytes = 16 * 1024;
     static constexpr qsizetype kMaxBodyBytes = 4 * 1024 * 1024;