chore: release pass fixes (crash guards, clang-tidy, README sync)

- Model picker menu lives on the heap so a combo destroyed while it is
  open no longer double-destroys a stack QMenu.
- PM2 banner buttons run a copy of their action: updateBanner() replaced
  the stored std::function while it was executing.
- clang-tidy: no-automatic-move, enum-size, implicit-conversion-in-loop,
  and move the pending entry out before erasing it.
- README: PM2 Processes dialog and Prewalk.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: nullmastermind

README.md

@@ -10,7 +10,7 @@ You shouldn't have to leave your editor to talk to an AI, run git, or open a she
 
 NotepadAI speaks the Agent Client Protocol (ACP) over stdio. Claude Code and Codex ship as factory agents and can be edited or deleted in Settings. You can also add any other ACP-compatible agent, including Gemini, Auggie, or your own command. Agents read and write files, run terminal commands, and see your workspace context, so they work on the same code you do. Start a session from the AI menu or by right-clicking a folder in the file tree.
 
-In a chat, a finished turn folds into a single "Worked for 2m14s" row; click it to bring back the tool calls and intermediate messages. Tool calls show how long they took. Claude Code background tasks and the wake-ups or cron jobs it schedules for itself appear under the transcript, with a Stop link for tasks that can be stopped. When the agent offers `/advisor`, an Advisor checkbox in the composer turns it on and off. When an agent needs a decision, its questions appear as a form in the chat with the suggested answer preselected, and a note box at the end takes anything else you want to add.
+In a chat, a finished turn folds into a single "Worked for 2m14s" row; click it to bring back the tool calls and intermediate messages. Tool calls show how long they took. Claude Code background tasks and the wake-ups or cron jobs it schedules for itself appear under the transcript, with a Stop link for tasks that can be stopped. When the agent offers `/advisor`, an Advisor checkbox in the composer turns it on and off. For Claude Code, Prewalk (at the top of the model picker) switches to a cheaper model once the agent starts editing files and back when the turn ends. When an agent needs a decision, its questions appear as a form in the chat with the suggested answer preselected, and a note box at the end takes anything else you want to add.
 
 There is also a Goal Agent: pick an ACP judge (Claude Code, Codex, Opencode) or a Custom API endpoint that speaks Anthropic's Messages API. You set success criteria and it drives the working agent until those criteria hold, or attach a goal to an existing conversation. Criteria presets can be saved globally, or into the current project's `.agents/.goals` folder so they travel with the repo; files already in that folder show up in the load list. A judge that needs a human action, or that hits the iteration cap with the criterion still unmet, stops and hands the criterion back instead of marking the goal done. With Prefix /goal checked, the first criterion is sent immediately when the agent supports `/goal`. If a reply is still running and the agent does not support `/goal`, that goal waits in the send queue so the current reply is not stopped. Later criteria wait until the previous is achieved. Send with Goal defaults to the agent's own `/goal` command instead: each criterion goes out on its own, with no separate judge. A `/goal` typed in the composer is sent while a turn is still running only when the agent supports that command; otherwise it waits in the queue. A goal is not judged, and auto compact does not run, while the agent still has background tasks running or a wake-up turn pending. When a goal is achieved, the session can compact automatically. Prompts sent while an agent is still working are queued and delivered when it finishes. AI chats group by project, with a session strip to switch conversations in the same dock. Open chats come back after a restart and resume their agent session on the first prompt. A local Claude Code chat can be moved to another agent from the agent button in the dock's title bar, keeping its transcript. The composer can ask the agent to work in a new git worktree. When you commit, AI can write the commit message from your staged diff. That generator (and other LLM calls) can talk to an OpenAI-compatible endpoint or Anthropic's Messages API. Leave the commit box empty (when not amending) and Commit lets you pick an ACP agent to do the commit. Protocol details and how to wire up a custom ACP agent are in [doc/AcpAgents.md](doc/AcpAgents.md).
 
@@ -22,6 +22,8 @@ Inline blame, gutter diff markers, commit history, staging and unstaging (includ
 
 A PTY terminal built on libvterm and libptyqt, with mouse reporting and a scrollback buffer. New terminals open as a bottom tab under the editor. When a workspace opens with no terminal, that area shows a placeholder with a New terminal button and the workspace's configured tasks; close it to hide it for that workspace, or turn it off under Preferences → Terminal. The tab strip follows the raised workspace: only terminals whose working directory belongs to that folder (or a nested workspace, longest match) are shown. If any open terminal sits outside every workspace, the filter turns off and every tab stays visible. Closing a workspace closes its terminals. Programs launched from a local terminal share a memory ceiling (16 GB by default, changeable under Preferences → Terminal) so a runaway process is stopped instead of exhausting the machine. A local terminal's title bar shows that process tree's CPU and RAM; hover the CPU figure for each logical core's load. Remote terminals omit those figures. It reads Justfile, Makefile, package.json, and deno.json, finds which tasks you can run, and draws clickable run icons in the editor margin. Open a terminal at the active workspace or at the current file's folder.
 
+Terminal → PM2 Processes lists every process of your local pm2 with live status, uptime, CPU and memory. You can start, stop, restart, or delete them, follow their logs in a terminal tab, and run a new command under pm2 with its own directory, shell, and environment variables. pm2 is fetched through npx if it is not installed.
+
 
 ### Editor
 

src/pm2/Pm2Client.cpp

@@ -69,7 +69,7 @@ QString Pm2Client::helperScriptPath(QString *error)
 
     const QString dir = QStandardPaths::writableLocation(QStandardPaths::AppDataLocation)
         + QStringLiteral("/pm2-helper");
-    const QString path = dir + QStringLiteral("/pm2-helper.cjs");
+    QString path = dir + QStringLiteral("/pm2-helper.cjs");
     QFile current(path);
     if (current.open(QIODevice::ReadOnly) && current.size() == script.size() && current.readAll() == script)
         return path;

src/pm2/Pm2ProcessModel.h

@@ -25,8 +25,8 @@ class Pm2ProcessModel : public QAbstractTableModel
     Q_OBJECT
 
 public:
-    enum class Column : int { Name, Status, Uptime, Restarts, Cpu, Memory, Pid, Cwd, Count };
-    enum Role : int {
+    enum class Column : uint8_t { Name, Status, Uptime, Restarts, Cpu, Memory, Pid, Cwd, Count };
+    enum Role : uint16_t {
         SortRole = Qt::UserRole + 1, // numeric value for numeric columns
         StatusRole,                  // Pm2Status as int
     };

src/pm2/Pm2ProcessesDialog.cpp

@@ -269,13 +269,15 @@ Pm2ProcessesDialog::Pm2ProcessesDialog(TerminalManager *terminals, std::function
     connect(m_restartAllButton, &QToolButton::clicked, this, &Pm2ProcessesDialog::restartAll);
     connect(m_stopAllButton, &QToolButton::clicked, this, &Pm2ProcessesDialog::stopAll);
     connect(m_resurrectButton, &QToolButton::clicked, this, &Pm2ProcessesDialog::resurrect);
+    // Run a copy: every action ends in updateBanner(), which replaces the
+    // stored one while it is still running.
     connect(m_bannerPrimary, &QPushButton::clicked, this, [this]() {
-        if (m_bannerPrimaryAction)
-            m_bannerPrimaryAction();
+        if (const std::function<void()> action = m_bannerPrimaryAction)
+            action();
     });
     connect(m_bannerSecondary, &QPushButton::clicked, this, [this]() {
-        if (m_bannerSecondaryAction)
-            m_bannerSecondaryAction();
+        if (const std::function<void()> action = m_bannerSecondaryAction)
+            action();
     });
     connect(m_table, &QTableView::doubleClicked, this, &Pm2ProcessesDialog::showLogs);
     connect(m_table, &QTableView::customContextMenuRequested, this, &Pm2ProcessesDialog::showContextMenu);
@@ -402,10 +404,11 @@ void Pm2ProcessesDialog::track(int requestId, Done done, bool saveAfter, const Q
 
 void Pm2ProcessesDialog::onCommandFinished(int requestId, bool ok, const QString &error)
 {
-    const auto it = m_pending.constFind(requestId);
-    if (it == m_pending.cend())
+    const auto it = m_pending.find(requestId);
+    if (it == m_pending.end())
         return;
-    const Pending finished = *it;
+    // Moved out: erasing the entry ends the iterator's life.
+    const Pending finished = std::move(it.value());
     m_pending.erase(it);
     if (finished.done)
         finished.done(ok, error);

src/pm2/Pm2Protocol.cpp

@@ -53,7 +53,7 @@ QStringList stringList(const QJsonArray &a)
 {
     QStringList out;
     out.reserve(a.size());
-    for (const QJsonValue &v : a)
+    for (const auto &v : a)
         out.append(v.toString());
     return out;
 }
@@ -108,7 +108,7 @@ Pm2HelperMessage parseLine(QByteArrayView text)
         m.kind = Pm2HelperMessage::Kind::List;
         const QJsonArray procs = o.value(QLatin1String("procs")).toArray();
         m.processes.reserve(procs.size());
-        for (const QJsonValue &v : procs) {
+        for (const auto &v : procs) {
             Pm2ProcessInfo p = processFromJson(v.toObject());
             if (p.pmId >= 0)
                 m.processes.append(std::move(p));

src/widgets/AcpSessionView.cpp

@@ -348,33 +348,39 @@ class MenuComboBox : public QComboBox
     {
         if (count() == 0)
             return;
-        QMenu menu(this);
-        menu.setToolTipsVisible(true);
+        // On the heap: if the combo dies while the menu is open, the menu dies
+        // with it (a stack menu would then be destroyed twice).
+        auto *menu = new QMenu(this);
+        menu->setToolTipsVisible(true);
         if (addLeadingEntries)
-            addLeadingEntries(&menu);
-        if (!menu.isEmpty())
-            menu.addSeparator();
-        auto *items = new QActionGroup(&menu);
+            addLeadingEntries(menu);
+        if (!menu->isEmpty())
+            menu->addSeparator();
+        auto *items = new QActionGroup(menu);
         for (int i = 0; i < count(); ++i) {
-            QAction *a = menu.addAction(itemText(i));
+            QAction *a = menu->addAction(itemText(i));
             a->setCheckable(true);
             a->setChecked(i == currentIndex());
             a->setData(itemData(i));
             items->addAction(a);
         }
-        menu.setMinimumWidth(width());
+        menu->setMinimumWidth(width());
         // Below the combo, or above it when the screen ends first.
         QPoint at = mapToGlobal(QPoint(0, height()));
         const QScreen *screen = this->screen();
-        const int h = menu.sizeHint().height();
+        const int h = menu->sizeHint().height();
         if (screen && at.y() + h > screen->availableGeometry().bottom())
             at = mapToGlobal(QPoint(0, 0)) - QPoint(0, h);
         const QPointer<MenuComboBox> self(this);
-        QAction *chosen = menu.exec(at);
+        QAction *chosen = menu->exec(at);
+        if (!self)
+            return;
         // The items may have been rebuilt while the menu was open: go by data.
-        if (!self || !chosen || chosen->actionGroup() != items)
+        const QVariant data = chosen && chosen->actionGroup() == items ? chosen->data() : QVariant();
+        delete menu;
+        if (!data.isValid())
             return;
-        const int index = findData(chosen->data());
+        const int index = findData(data);
         if (index >= 0)
             setCurrentIndex(index);
     }