Repository navigation
fix: align Lua 5.2 VM equality, modulo and loop rules - #379
Merged
Merged
Conversation
akeit0
force-pushed
the
codex/pr-lua52-vm-semantics
branch
from
October 27, 2026 02:56
01a99b1 to
e5b1f96
Compare
5 tasks
akeit0
force-pushed
the
codex/pr-lua52-vm-semantics
branch
from
October 27, 2026 03:11
e5b1f96 to
737ab3f
Compare
akeit0
marked this pull request as ready for review
October 27, 2026 03:28
akeit0
force-pushed
the
codex/pr-lua52-vm-semantics
branch
from
October 27, 2026 03:28
737ab3f to
bb83114
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua 5.2 only invokes __eq for eligible same-type operands with a shared metamethod. Enforce that rule and skip the slow path for primitive inequality. Use the non-positive-step direction for zero-step numeric loops and the floor-based modulo expression for both execution and constant folding. Convert a numeric __tostring result to one string.
These are semantic alignment changes. Tests cover shared/different equality methods, hooks and suspended callbacks, zero-step loops, and folded/runtime modulo. The full test suite passes on .NET 8/10; CSharpier passes.