Repository navigation
fix: align Lua 5.2 numeric coercion and math selection - #380
Merged
Merged
Conversation
akeit0
force-pushed
the
codex/pr-lua52-vm-semantics
branch
from
October 27, 2026 02:56
01a99b1 to
e5b1f96
Compare
akeit0
force-pushed
the
codex/pr-lua52-numeric-coercion
branch
2 times, most recently
from
October 27, 2026 03:11
10f4662 to
f7bd5df
Compare
akeit0
force-pushed
the
codex/pr-lua52-vm-semantics
branch
from
October 27, 2026 03:11
e5b1f96 to
737ab3f
Compare
akeit0
marked this pull request as ready for review
October 27, 2026 03:28
akeit0
force-pushed
the
codex/pr-lua52-numeric-coercion
branch
from
October 27, 2026 03:28
f7bd5df to
8aa7108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Lua numeral rules and a single digit-accumulation loop for explicit-base tonumber. For example, tonumber('1.5',10) returns nil and tonumber(10,2) returns 2. Preserve the current managed number-to-text conversion for numeric inputs.
Align select's count/range rules, min/max's NaN and signed-zero selection, optional-nil/base-zero logarithms, and random's argument handling. Accept fractional bit32 words through the existing managed normalizer.
Tests cover malformed and valid numerals, bases, selection, logarithm edges, random bounds and bit32 coercion. The full test suite passes on .NET 8/10; CSharpier passes.