Repository navigation
fix: align Lua 5.2 string and table argument conversion - #381
Merged
Merged
Conversation
akeit0
force-pushed
the
codex/pr-lua52-numeric-coercion
branch
from
October 27, 2026 02:56
4411bb5 to
10f4662
Compare
akeit0
force-pushed
the
codex/pr-lua52-string-table-arguments
branch
from
October 27, 2026 02:56
d549634 to
05051bb
Compare
akeit0
force-pushed
the
codex/pr-lua52-numeric-coercion
branch
from
October 27, 2026 03:11
10f4662 to
f7bd5df
Compare
akeit0
force-pushed
the
codex/pr-lua52-string-table-arguments
branch
from
October 27, 2026 03:11
05051bb to
385f661
Compare
akeit0
marked this pull request as ready for review
October 27, 2026 03:28
akeit0
force-pushed
the
codex/pr-lua52-string-table-arguments
branch
from
October 27, 2026 03:28
385f661 to
fd783ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncate fractional string indices, character codes, repetition counts and table insert/remove positions before applying bounds. string.rep('ab',2.9,':') now returns ab:ab. Share safe index conversion so large positions cannot wrap, and evaluate sort's length metamethod before validating the comparator.
Also return string.char's rented builder buffer when argument validation fails. Tests cover fractional and extreme positions, byte/UTF-16 character ranges, failure recovery and sort side-effect order. The full test suite passes on .NET 8/10; CSharpier passes.