Repository navigation
Conversation
akeit0
force-pushed
the
codex/pr-lua52-printf
branch
from
October 27, 2026 02:56
40527c1 to
8f5f178
Compare
akeit0
force-pushed
the
codex/proposal-lua52-numeric-text
branch
from
October 27, 2026 02:56
51ea84d to
7eb0faa
Compare
This was referenced Oct 27, 2026
akeit0
force-pushed
the
codex/proposal-lua52-numeric-text
branch
from
October 27, 2026 03:11
7eb0faa to
da3e47e
Compare
akeit0
force-pushed
the
codex/pr-lua52-printf
branch
2 times, most recently
from
October 27, 2026 03:28
1c99995 to
d2d1fe5
Compare
akeit0
force-pushed
the
codex/proposal-lua52-numeric-text
branch
from
October 27, 2026 03:33
da3e47e to
6c8678e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A separate proposal for the decision in #378: use 14 significant digits, lowercase exponents and signed inf/nan in Lua-facing numeric text, while retaining public C# LuaValue.ToString(). This affects tostring, numeric __tostring, %s/%q, concatenation, table.concat, gsub replacements, numeric inputs to explicit-base tonumber, and explicit printf special values.
For example, tostring(1/3) changes from 0.3333333333333333 to 0.33333333333333. tonumber(1e14,10) changes from 1e14 to nil because its intermediate text becomes scientific notation. Persisted text and round-trip precision can change.
Recommendation: keep the existing invariant managed default until that decision is made. Lua's default %.14g is configurable; MoonSharp 2.0.0 on .NET 10 also uses managed precision and Infinity/NaN words.
Tests check the conversion paths under another culture and preserve host formatting. The full test suite passes on .NET 8/10; all library targets build; CSharpier passes. Of 14,128 native comparisons, only the five deferred frexp/deg differences remain.