Skip to content

Commit 0596115

Browse files
chore(ui-scripts): re-point two texts at the fleet-patrols.yml jobs (#27816)
domain:ui#4 · os-bill · session_01Utp6CbDAucNyQ4UtzCJKyh <!-- claude-projects-attribution: {"github_login":"os-bill"} --> _Requested by **Bill** · [project thread](https://claude.ai/code/project/chan_016iMXWSZDzqWRWvWzdNo8wg?thread=cmsg_016iMXWSZDzqWRWvWzdNo8wgDFH4S5pR1C8YvYCWWsZfXx)_ Fixes #27479 Clause-②: no Metadata-protocol: none ## 维护者速读 - 改了什么:`ui/scripts/` 下两处文字(一条测试注释、Dependabot 合并门里一条可选检查的说明)不再点名已退役的 `required-set-patrol.yml` / `board-snapshot.yml`,改指根 `fleet-patrols.yml` 里的同名 job。 - 为什么改:这两个巡检 workflow 已并入 `fleet-patrols.yml`,旧文件名会把读者引向不存在的文件。 - 风险与回滚:只改注释与一条说明字符串,零行为变化(该字符串只要求长度 > 40,无人打印或解析);回滚即 revert 本 PR。 - 先看:`ui/scripts/dependabot-merge-gate.mjs` 的 `Snapshot the board to the archive branch` 条目;其次 `ui/scripts/__tests__/check-required-check-set.test.ts` 的 retired-pins 注释。 - 两分钟验证:`git grep -n -E 'required-set-patrol\.yml|platform-checklist-watchdog\.yml|release-coverage-patrol\.yml|board-snapshot\.yml' -- ui/`,预期零输出(退出码 1)。 - 需要你做的:无,席位落地。 ## What changes - `ui/scripts/__tests__/check-required-check-set.test.ts`: the comment over the retired workflow pins now names the `required-set-patrol` job of the root `fleet-patrols.yml` instead of the retired root `required-set-patrol.yml`. Comment only. - `ui/scripts/dependabot-merge-gate.mjs`: the `OPTIONAL_CONTEXTS` reason for `Snapshot the board to the archive branch` now names the `board-snapshot` job of the root `fleet-patrols.yml`. Its paths-filter clause is restated to match that workflow (the workflow file plus the root scripts its jobs run, none under `ui/`), because "the workflow file itself" stopped being the whole filter when four patrols became one file. The key and the bucket are unchanged. ## Tests - `pnpm --dir ui exec vitest run scripts/__tests__/check-required-check-set.test.ts scripts/__tests__/dependabot-merge-gate.test.ts`: 2 files, 47 tests passed (run under `os-verify-lock`, VERDICT command-exit 0). - `pnpm --dir ui exec vitest run scripts/` (the derived family) on head `814431ed`: 169 files passed, 2 skipped; 4902 tests passed, 2 skipped (VERDICT command-exit 0). - No test asserts the reason text beyond `states a reason for every context it declines to gate on` (length over 40), and the script reads only the keys of `OPTIONAL_CONTEXTS`, so no pin moves with the string. ## Acceptance notes - Card reading: `git grep -n -E 'required-set-patrol\.yml|platform-checklist-watchdog\.yml|release-coverage-patrol\.yml|board-snapshot\.yml' -- ui/` reads 0 lines on this branch (exit 1); it read 2 on `origin/main` at the branch point. - Verified on `origin/main` before the edit: `.github/workflows/fleet-patrols.yml` declares jobs `required-set-patrol` and `board-snapshot`, and its header table maps each to the retired file. - No changeset: `ui/scripts` belongs to the private `object-ui-monorepo` root and publishes nothing, so this PR carries `skip-changeset`. - Not touched: the comment's other references (`required-check-set-patrol.yml` is objectui's own retired file, correctly named as such). ## Verification Local gate subset and the `--ran` reconciliation are in the report comment on #27479; every CI family is read from this PR's check-runs. --- _Generated by [Claude Code](https://claude.ai/code/session_01Utp6CbDAucNyQ4UtzCJKyh)_ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 47c3e12 commit 0596115

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

‎ui/scripts/__tests__/check-required-check-set.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -320,11 +320,11 @@ describe('check-required-check-set — the wiring', () => {
320320
// invokes this script`, `the patrol asks for no write permission at all` and
321321
// `a run that could not read must fail the job`. Each read objectui's
322322
// `required-check-set-patrol.yml`, which runs nowhere under the monorepo:
323-
// GitHub runs the root `.github/workflows/` alone, and the root
324-
// `required-set-patrol.yml` patrols the monorepo's own ruleset. objectui's
325-
// patrol is row 25 of the objectstack#25697 workflow roster (→ sub-issue 4); a
326-
// port brings these pins back against the root workflow that runs this
327-
// script, by path.
323+
// GitHub runs the root `.github/workflows/` alone, and the
324+
// `required-set-patrol` job of the root `fleet-patrols.yml` patrols the
325+
// monorepo's own ruleset. objectui's patrol is row 25 of the
326+
// objectstack#25697 workflow roster (→ sub-issue 4); a port brings these pins
327+
// back against the root workflow that runs this script, by path.
328328
});
329329

330330
/**

‎ui/scripts/dependabot-merge-gate.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export const OPTIONAL_CONTEXTS = Object.freeze({
233233
'Regenerate the per-file test timings':
234234
"test-shard-timings-refresh.yml filters its pull_request trigger on paths: the workflow file and the two scripts it loads (`scripts/test-file-timings.mjs`, `scripts/test-shard-partition.mjs`, objectui#12208). Blocking when it runs: the pull_request leg runs the selection, the artifact downloads and the regeneration on a real runner and skips only the push and the pull request, so an edit that breaks the refresh is red before it merges. It is OPTIONAL rather than required because that path filter means it does not report on a pull request that touches none of those files, which is every dependency bump that does not edit that workflow.",
235235
'Snapshot the board to the archive branch':
236-
"board-snapshot.yml filters on paths: the workflow file itself (objectui#9387; since objectui#10208 the archiver runs from an objectstack checkout, so no script of this repository is on that list). Blocking when it runs: the pull_request leg runs the archiver's own --self-test and then a capped `--dry-run` snapshot on a real runner, so a workflow edit that breaks the archiver's invocation is red before it merges. It is OPTIONAL rather than required because that path filter means it does not report at all on a pull request that does not touch that file, which is every Dependabot bump. ⛔ Not NOT_A_GATE: that bucket says a check cannot gate, and this one is the only thing in the repository that exercises the archiver's wiring before it merges.",
236+
"The `board-snapshot` job of the root fleet-patrols.yml runs on a pull request only when it touches that workflow's paths filter: the workflow file itself and the root scripts its jobs run (objectui#9387; since objectui#10208 the archiver runs from an objectstack checkout, so no script under ui/ is on that list). Blocking when it runs: the pull_request leg runs the archiver's own --self-test and then a capped `--dry-run` snapshot on a real runner, so a workflow edit that breaks the archiver's invocation is red before it merges. It is OPTIONAL rather than required because that path filter means it does not report at all on a pull request that touches none of those paths, which is every Dependabot bump. ⛔ Not NOT_A_GATE: that bucket says a check cannot gate, and this one is the only thing in the repository that exercises the archiver's wiring before it merges.",
237237
});
238238

239239
/**

0 commit comments

Comments
 (0)