Skip to content

Commit 0b78a20

Browse files
docs(pm-dispatch): read a PR's live state before any report to the maintainer (#26741)
<!-- claude-projects-attribution: {"github_login":"os-steve"} --> _Requested by **Steve** · [project thread](https://claude.ai/code/project/chan_01FdL1XeUyvVNxLreh3F4Qi9?thread=cmsg_01FdL1XeUyvVNxLreh3F4Qi9PhMQ8uCJ2gFAvwHUAJPEcW)_ Fixes #26675 Clause-②: no Metadata-protocol: none ## 维护者速读 - 改了什么:pm-dispatch 协调者手册第七节,向你汇报任何 PR 状态前,必须当场重读 merged、draft、auto_merge、是否在队、reviews 与 mergeable_state。 - 为什么改:今天两次把你已处理(已批、已 ready 入队)的 PR 仍报成「等你」;旧规则只要求读 mergeable_state,且只管「无需你做」一个方向。 - 风险与回滚:只改一份内部技能文档的两行,不发布、不影响运行时;回滚即 revert 本 PR。 - 先看:`.claude/skills/pm-dispatch/references/coordinator.md` 第七节末两行。 - 两分钟验证:`pnpm check:pm-skill-ratchet && pnpm check:pm-skill-id-lint`,预期两条都绿、该文件仍 49 行。 - 需要你做的:总监契约复审 PASS 后,在 GitHub 上批准或直接 ready 入队(Tier S;席位自己 ready 会被权限拦下)。 ## What changes `.claude/skills/pm-dispatch/references/coordinator.md` section 7 (read by the coordinator and every seat thread): - The relay line that named only `mergeable_state`, and only before relaying "no action needed", is replaced by two lines that cover every PR state reported to the maintainer, both directions: before any report, re-read in the same act `merged`, `draft`, `auto_merge`, queue membership, reviews and `mergeable_state`; a PR can be readied and queued with no APPROVED review, so reviews alone is not the reading; a PR whose ask is already met is dropped; `dirty` still sends it back to the thread to merge main. - Paid for by deleting the when-to-report line (only results, blockers or pending decisions; routine progress to the thread checklist). Its surviving homes: SKILL.md's push-the-maintainer pair (what is pushed; routine progress is not) and `seat-lifecycle.md`'s "round report = card-thread checklist". The line itself said "same rule as the seats". - Queue membership is named, not spelled out: its reading already lives in `platform-readings.md` (queue ref, positive probes, timeline enqueue event). No second copy in SKILL.md. Maintainer, verbatim: 「这几个pr 都处理过了,你的消息不及时,如何优化」「是否建议更新到 pm-dispatch skills ,你会阅读那个吗」 Line budget: `coordinator.md` 49 → 49 (ceiling 49, +2 / −2); both new lines 118 bytes (cap 120); no untouched line re-wrapped. No forced test edits. ## Tests None: prose-only change to a repo-internal agent playbook. No changeset (`.claude`-only diff, `skip-changeset`). ## Acceptance notes - The card asks for the rule "stated once in section 7": it is, and SKILL.md is untouched. - Deleting the when-to-report line is a judgment call to keep the line count flat; the alternative cut was the language line (homes: AGENTS.md Communication and SKILL.md's all-seat invariant). The seat may swap. ## Verification Local derived set at `d8594255`, `node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran` → 17 derived, 17 run, 0 NOT-MEASURED (derived zero, every entry with an exit code). <details><summary>Gate readings at d859425</summary> - `pnpm check:pm-skill-ratchet` exit 0 - `pnpm check:pm-skill-id-lint` exit 0 (104 files clean) - `pnpm check:pm-governed-prose` exit 0 (13 surfaces named) - `pnpm check:pm-governed-merges`, `check:skill-frame-sync`, `check:doc-authoring`, `check:nul-bytes`, `check:agent-test-spelling`, `check:cross-package-test-inputs`, `check:driver-memory-census`, `check:gitlink-declared`, `check:refd-timer-probe`, `check:watch-hint-literal` exit 0 - `node scripts/check-closing-keyword-parity.mjs` (+ `--self-test`), `node scripts/check-comment-mask-corpus.mjs`, `node scripts/pm/check-harness-current.mjs --self-test` exit 0 - `pnpm --filter @objectstack/lint run check:doc-formula-expressions`: first run exit 3 (prerequisite: lint/formula not built, nothing measured); after `turbo run build --filter=@objectstack/formula --filter=@objectstack/lint` under the verify lock (VERDICT command-exit 0), exit 0 </details> Tier S governed surface (`.claude/**`): this PR stays draft until a contract-tier review of record. --- _Generated by [Claude Code](https://claude.ai/code/session_01ADHkmT9FyDTpYhP8sdb5Hj)_ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 1bd7574 commit 0b78a20

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎.claude/skills/pm-dispatch/references/coordinator.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,5 @@
4545
## 七、语言与汇报(coordinator 与席位线程皆读)
4646

4747
- 项目内对维护者用维护者的语言;GitHub 内容英文,照 SKILL.md 全体座位不变量。
48-
- 只在结果、阻塞或待裁决时向维护者汇报,与席位同规;例行进展进线程清单。
49-
- 转述线程 PR「无需你做」前自读其 `mergeable_state`;`dirty` ⇒ 退回线程先合 main,⛔ 不转述。
48+
- 向维护者报任一 PR 状态前同轮重读:merged、draft、auto_merge、在队、reviews、`mergeable_state`。
49+
- 无 APPROVED 也可能已被 ready 入队 ⇒ ⛔ 单读 reviews;已办即删;`dirty` ⇒ 退回线程先合 main。

0 commit comments

Comments
 (0)