Repository navigation
Commit 0f254f4
docs(adr): ADR-0048 §3.5 rename-on-install ships for unmanaged copies; ADR-0131 D6 notes the Q3 extension and the Q6 answer (#31205)
<!-- claude-projects-attribution: {"github_login":"marchtian"} -->
_Requested by **田騏** · [project
thread](https://claude.ai/code/project/chan_01VmuUhXU9SSUzqJYyXSmYSi?thread=cmsg_01VmuUhXU9SSUzqJYyXSmYSiU1rhbHT2BKdngdowSzudqP)_
Fixes #30794
Clause-②: no
Metadata-protocol: none
## 维护者速读
- 改了什么:两份 ADR 加注记。ADR-0048 §3.5「装时改名」从「暂不做」改为「unmanaged 副本可以改名,managed
永不改名」;ADR-0131 D6 记下副本可带自己的 namespace,以及 Q6 的裁定。
- 为什么改:PR A(#30997)和 PR C(#31182)已经上线了改名安装,ADR 还写着「不做」;Q6 你已裁定
B(改名副本不拒绝),要落进决策记录。
- 风险与回滚:只改文档,不动代码、不发版;原段落一字未改,只在旁边加带日期的注记和状态行条目;回滚即 revert。
-
先看:`docs/adr/0131-total-organization-ownership-no-null-organization-id.md`(D6
Unmanaged 后的新注记,Q6
那段)、`docs/adr/0048-cross-package-metadata-collision.md`(§3.5 下的注记)。
- 两分钟验证:打开 ADR-0131 搜「Note (2026-11-07, #30794)」,读 Q6
一段,预期写的是「改名副本不拒绝,未改名副本 Q6 原文有效」,并引用裁定记录 6709037798。
- 需要你做的:Fable 复核与席位 ACCEPT 之后,由维护者(os-zhuang 或 hotlong)合并。
## What changes
Docs only, two files, nothing else (`skip-changeset`: the diff publishes
nothing).
- **ADR-0048 §3.5.** The original paragraph stays verbatim. A dated note
`Amended (2026-11-07, #30794)` records that rename-on-install ships for
unmanaged copies only: a `targetNamespace` on an unmanaged install
renames the copy through `planNamespaceRename`
(`packages/metadata-protocol/src/package-namespace-rename.ts`), the one
engine `duplicatePackage` already applies (ADR-0070 D4). It states what
the two doors share and what they do not (only the duplicate rebinds a
permission set's `packageId`, ADR-0086 D3; only the import judges copy
names against the item-name grammar and the 63/255 limits); that a view
container follows its object on both doors; the refusals before the base
exists, including the `targetNamespace` refusals that answer `400
INVALID_REQUEST` since #31182; that §3.2 runs on the renamed names; that
a managed install is never renamed (`targetNamespace` beside it: `400
INVALID_REQUEST`); provenance (`sourceNamespace`,
`installedFrom.namespace`); and that the CLI sends no `targetNamespace`.
Out of scope: bare non-object names (ruling C on #30798), seed data, and
the hosted-cloud default namespace (objectstack-ai/cloud#3624). The
status line gains an **Amended** entry.
- **ADR-0131 D6.** After the **Unmanaged** bullet, a dated note `Note
(2026-11-07, #30794)`: Q3 on #15213 (seat answer, stage-0 ACCEPT record
`6108175106`) is extended — the copy still goes into a NEW base, and
keeps the source namespace unless the install names a `targetNamespace`.
Q6 (same record) does not apply to a renamed copy, by the maintainer's
ruling **B** (record `6709037798` on #30794, 「B 不拒绝(推荐)」); for a copy
that kept the source namespace, Q6 stands exactly as written. The status
line gains an **Amended** entry.
## Review
- **Fable review (independent, contract tier), verdict PASS with nits**,
no must-fix or should-fix. Scope per the narrowed rule: the two ADR
diffs, checked claim by claim against the code they describe. Files it
read: both ADRs;
`packages/metadata-protocol/src/package-unmanaged-install.ts` (whole),
`package-namespace-rename.ts` (whole), `protocol-package-commits.ts`
(duplicate and import callers);
`packages/cloud-connection/src/marketplace-install-local-plugin.ts`
(managed `targetNamespace` refusal, step 1f
`findEnvironmentBaseHoldingNamespace`, `installedFrom`);
`marketplace-install-local-install-modes.test.ts` (the Q6 = B pair);
`content/docs/deployment/install-modes.mdx`;
`packages/cli/src/commands/package/install.ts`;
`packages/spec/src/api/package-lifecycle.zod.ts`; ADR-0070 and ADR-0086
headings. It also confirmed records `6108175106` and `6709037798`.
- Nits applied in `35c09fa7`: "Every reference to a renamed name
follows" narrowed to "Every reference the engine reads follows (the
first bullet below says where)"; the #15213 Q3/Q6 now say they are that
record's, not ADR-0131's own §6 Q3/Q6. Not changed: the status-entry
punctuation (harmless), and the cloud#3624 citation (not verifiable from
this repo, kept as the card states it). Under the narrowed rule no delta
re-review is owed for nits.
## Acceptance notes
- objectstack-ai/cloud#3600 comment 6676044775 (the epic ruling) was not
read: it is in another repository this session cannot reach. Someone who
can read it should check the §3.5 note agrees with it.
- ADR-0048's TL;DR item 5, its non-goals line and Phase 4 still describe
rename-on-install as a non-goal; they are kept verbatim as the record's
original text, and the status line plus the §3.5 note carry the
amendment.
## Verification
<details><summary>Derived gates (head 35c09fa): 21 derived, 21 exit
0</summary>
Derived with `node scripts/pm/dispatch-gates.mjs --commands --repo
objectstack-ai/objectstack` (2 paths vs merge base bd5a443), run on
the final head under `NODE_OPTIONS=--max-old-space-size=8192`, exit
codes captured before any pipe; `--ran`: "21 derived famil(ies)
accounted for — 21 run, 0 NOT-MEASURED".
```text
node scripts/check-adr-links.mjs :: exit 0
node scripts/check-adr-links.mjs --self-test :: exit 0
node scripts/check-closing-keyword-parity.mjs :: exit 0
node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0
node scripts/check-comment-mask-corpus.mjs :: exit 0
node scripts/ci/plan-test-core-shards.mjs --self-test :: exit 0
pnpm --filter @objectstack/lint run check:doc-formula-expressions :: exit 0
pnpm check:adr-anchors :: exit 0
pnpm check:adr-index :: exit 0
pnpm check:adr-symbol-anchors :: exit 0
pnpm check:ci-filter-parity :: exit 0
pnpm check:closed-ceremony-text :: exit 0
pnpm check:cross-package-test-inputs :: exit 0
pnpm check:doc-authoring :: exit 0
pnpm check:driver-memory-census :: exit 0
pnpm check:gitlink-declared :: exit 0
pnpm check:nul-bytes :: exit 0
pnpm check:pm-governed-merges :: exit 0
pnpm check:pm-prior-rulings :: exit 0
pnpm check:refd-timer-probe :: exit 0
pnpm check:watch-hint-literal :: exit 0
```
</details>
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---
_Generated by [Claude
Code](https://claude.ai/code/session_017ihL2ewD2rAszkPvzKBT8T)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 007fdb1 commit 0f254f4
2 files changed
Lines changed: 64 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
296 | 335 | | |
297 | 336 | | |
298 | 337 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
523 | 523 | | |
524 | 524 | | |
525 | 525 | | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
526 | 549 | | |
527 | 550 | | |
528 | 551 | | |
| |||
0 commit comments