Repository navigation
Commit 119c2db
<!-- claude-projects-attribution: {"github_login":"os-bill"} -->
_Requested by **Bill** · [project
thread](https://claude.ai/code/project/chan_016iMXWSZDzqWRWvWzdNo8wg?thread=cmsg_016iMXWSZDzqWRWvWzdNo8wgFMKmBZQVKU38CQ6a3dqyHp)_
domain:server#2 · os-bill · session_01Utp6Cbvcmv8YWFhFJwzjKL
## 维护者速读
- **改了什么:** 回退 PR #30222(`490d136f`):`member_default` 去掉 `sys_comment` 和
`sys_activity` 两行,连同它的测试和 changeset,文件恢复到合并前的原样。
- **为什么改:** 合入后 main 的 `Dogfood Regression Gate (2/3)`
连红两次。没装审计插件的启动里,这两个对象没有注册,克隆 `member_default` 被保存门以 422 拒收。按 main
红的约定先止血。
- **风险与回滚:** 只撤落地,不撤裁决:普通成员暂时回到改动前(没有评论和动态),等前向修复。这个 changeset
还没发布,所以回退不发布任何东西。
- **先看:**
`packages/plugins/plugin-security/src/objects/default-permission-sets.ts`
的差异。
- **两分钟验证:** `git diff 314ad95 HEAD -- packages/plugins/plugin-security
.changeset` 为空。
- **需要您做的:** 无,席位落地。
Refs #30255
Refs #30108
Clause-②: no
Metadata-protocol: none
## What this does
Reverts the squash commit `490d136f` (PR #30222, #30108's landing): the
two `member_default` grants (`sys_comment` read, create and edit;
`sys_activity` read), the comment block above them, the integration test
file, the flipped pins in `member-default-explicit-allow.test.ts` and
`comment-reaction-own-record-floor.test.ts`, and the changeset
`.changeset/30108-member-default-feed-grants.md`.
The five paths are byte-identical to their state in `314ad955`, the
commit before the landing: `git diff 314ad95 HEAD` over them is empty.
No later commit on `main` touched them.
#30108's ruling A stands. Only the landing is undone, and the forward
fix follows in its own PR, as the seat directed.
## Why main went red
Measured in run 41961254209 (`797f9257`), `Dogfood Regression Gate
(2/3)`, case `permission-set-clone-door.dogfood.test.ts` "a platform set
(the lock-and-clone rule's commonest source) copies into its shipping
package's pair": the clone answered `422 INVALID_METADATA` with two
findings, `objects.sys_comment` and `objects.sys_activity`, each "no
package registers an object of that name and none is saved here".
`@objectstack/verify`'s `bootStack` constructs no `AuditPlugin` (fact 3
of
`packages/cli/src/commands/serve-audit-registration.contract.test.ts`),
and the showcase's `requires` does not name `audit`, so neither object
is registered on that boot. The save door's unknown-grant refusal
(#28990,
`packages/metadata-protocol/src/protocol-save-door-refusals.ts`) judges
every grant of a new item, and a clone is a new item. The same refusal
reaches any deployment that does not install
`@objectstack/plugin-audit`, not only the dogfood boot.
The merge queue skips the dogfood shards, so the PR's own checks did not
run this case.
## Verification
See the seat hand-off for the local run of the dogfood case on this
head.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01Utp6CatT2ajve5PJf1Hhzj)_
---------
Co-authored-by: Claude <noreply@anthropic.com>
1 parent d0da880 commit 119c2db
5 files changed
Lines changed: 13 additions & 607 deletions
File tree
- .changeset
- packages/plugins/plugin-security/src
- objects
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
38 | | - | |
| 36 | + | |
| 37 | + | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
274 | 277 | | |
275 | 278 | | |
276 | 279 | | |
| |||
288 | 291 | | |
289 | 292 | | |
290 | 293 | | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | 294 | | |
346 | 295 | | |
347 | 296 | | |
| |||
0 commit comments