Skip to content

Commit 128681f

Browse files
docs(qa): checklist items for the ADR-0146 Studio door promises (#28579 slice 2) (#29487)
<!-- claude-projects-attribution: {"github_login":"marchtian"} --> _Requested by **田騏** · [project thread](https://claude.ai/code/project/chan_01VmuUhXU9SSUzqJYyXSmYSi?thread=cmsg_01VmuUhXU9SSUzqJYyXSmYSi9paTx1Lu8ENYwwssthfK3h)_ Part of #28579 (slice 2 of 3) Clause-②: no Metadata-protocol: none ## 维护者速读 - **改了什么**:测试清单为 ADR-0146 已上线的「Studio 定制」能力各补了一条可执行测试项,共 7 条新项。它们覆盖:视图、仪表盘和报表的定制与恢复,流程覆盖,`__c` 扩展字段,定制配对包的创建入口,`os migrate` 迁移仪式,落地页计数,以及 Setup 到 Studio 的跳转。另有 1 条旧项扩展、1 条退役、5 条改写。只改 `docs/qa/platform-checklist`,不动产品代码。 - **为什么改**:这些能力已经交付,但清单里没有对应的测试项。上一片留下的几条旧项还写着已关闭的「无包覆盖」或已退役的 Setup 页面,QA 照着跑会得到错误结论。 - **风险与回滚**:纯文档与清单数据,不影响运行时。回滚即 revert 本 PR。 - **先看**:`studio-authoring.package-customize-restore-display`(新主项,替代退役的 `packaged-display-class-direct-edit`),以及 FOLLOW-UPS §14b(卸载基础包时先返回 422,不会走到点名配对包的 409)。 - **两分钟验证**:`node scripts/check-platform-checklist.mjs` 为绿,符号锚点从 1096/1106 增至 1134/1144,未解析的仍是原有 10 个。 - **需要你做的**:无,席位落地 ## What changes There are seven new items, one per ADR-0146 promise. Each was read from source at `eb123b7ccc` and cites the card that shipped it. | Item | Promise | | --- | --- | | `studio-authoring.package-customize-restore-display` | N-17: Customize, the five reads agree, the end user sees it, export, Restore package original. Variants for view, dashboard and report | | `automation.package-flow-override` | N-11 / N-18 / N-22: a flow override in the pair, the waiting run finishes on the base, the ledger switch is inherited, Restore re-arms the base, New similar is a separate copy | | `studio-authoring.package-extension-field-c` | N-23c: an `__c` field on a base object through `object_extension` in the pair, the label-only `fieldPatches` whitelist, the two `__c` refusals | | `platform-core.customization-pair-ensure-door` | N-13 / N-14: `POST /packages/:id/ensure-customization` (201, idempotent 200, every refusal) and the pair's uninstall refusal | | `cli.packageless-overlay-ceremony-and-close` | N-16a / N-16b: `os migrate packageless-overlays` preview, confirmation, apply, then the closed package-less write (403 `NOT_OVERRIDABLE` naming the pair) | | `studio-authoring.package-customization-counts-and-marks` | N-24 / N-26b: the landing's "n customized, m switched off", the directory marks and filter | | `platform-core.setup-metadata-redirects-to-studio` | N-28: Setup metadata URLs land in Studio in one hop, keeping package, review and hash; the datasource stays in Setup | Existing items changed. Every one bumps `revision` and adds a `history` row that says why. - `studio-authoring.access-permission-set-lifecycle` (r5→r6) is **extended rather than twinned** with N-20b, New similar on a packaged set: new steps[6] and acceptance[5]. The copy lands in `com.example.showcase.custom`, and no override gesture is offered (D6). - `studio-authoring.packaged-display-class-direct-edit` is **retired** (r6→r7) with `supersededBy` the new display item. Its `retiredReason` maps every clause. - `studio-authoring.org-override-registry-gate` (r8→r9): the "overlay open" side is now the declared override from the pair. The transitional knownGap is replaced. - The four FOLLOW-UPS §13c items now name the Studio landing URL instead of the retired Setup page: - `platform-core.metadata-authoring-roundtrip` (r8→r9). Its acceptance[4] wording no longer says a packaged view "accepts" a package-less overlay. The verify is unchanged. - `studio-authoring.record-page-roundtrip` (r12→r13) - `studio-authoring.permission-matrix-editor-ux` (r8→r9) - `automation.packaged-flow-subflow-disable-refusal` (r11→r12) - `coverage.json`: the retired id is re-mapped, and the new items are mapped under report, flow, object and manifest. - `FOLLOW-UPS.md` gets §14. Left alone, as the order says: `api-backend.packaged-action-disabled-dispatch` and `automation.packaged-flow-disable-durable`, whose knownGap waits on #29374. ## Tests No product code changes. Each new item's `automated.ref` names the unit and integration pins below. They were run on this branch (see Verification). - UI (jsdom): - studio-design: InterfacesPillar.customize-28562, StudioCustomizeControls.customize-28562, StudioDesignSurface.customizePublish-28562, AutomationsPillar.customizeFlow-28570, AutomationsPillar.newSimilar-28567, DataPillar.baseObjectExtension-28575, StudioCustomizeControls.objectExtension-28575, BuilderLanding.customizationCounts-28566, customizationMarks, setupMetadataRedirect, noSetupMetadataLink-28578 - metadataAreaHost.customizations-28568 - AppContent.setupMetadataStudio-28578 - StudioDesignSurface.accessNewSimilar-28573, for the extended access item - Server: - objectql: protocol-custom-override-effective-read, registry-assert-package-uninstallable, protocol-packageless-overlay-migration - service-automation: flow-sync-one-precedence - runtime: packages-ensure-customization, packages-uninstall-refuse-before-mutate, packages-customizations, permission-set-clone - metadata-protocol: protocol.named-base-overlay-write, protocol.extension-field-suffix - cli: packageless-overlays.integration ## Acceptance notes - **Seat decision: the retire.** The order says to retire `packaged-display-class-direct-edit` only if a new item covers every clause. The successor covers [0]–[3]. [4] (a packaged flow stays locked) is held by `packaged-automation-studio-lock` and the new flow-override item. The dashboard leg's specimen moves from the platform's `system_overview` (plugin-auth) to the showcase's `showcase_ops_dashboard`, and nothing here verifies whether a platform-shipped dashboard can be customized. - **Measured from source (FOLLOW-UPS §14b).** `DELETE /api/v1/packages/:id` runs `requireWritablePackage` before `assertPackageUninstallable`. So uninstalling the showcase (a read-only base) answers **422 `WRITABLE_PACKAGE_REQUIRED`**, and the pair is never asked. The 409 that names the pair is reachable only for a writable base with an exported pair, and the ensure-door item scores both. Slice 3's live spec should expect 422 on the showcase. - **The ceremony needs a staged row.** No door on main writes a package-less row any more, which is what the close means. The CLI item's knownGap says how a run stages one, the way the command's own integration test does. - **Out of scope, reported (FOLLOW-UPS §14c).** Studio's landing copy (`engine.studio.landing.description` and `readonlyHint`) still says "customize them with an environment overlay". `BuilderLanding.environmentOverlayCopy-12171.test.ts` pins that phrase. This was found by reading source only. - The browser journeys have no live e2e spec yet. #28579 slice 3 owes it, and the four browser items say so in `automated.ref`. ## Verification Run on the branch head after merging `origin/main` (`04e0c2c0c7`). Each exit code was recorded before any pipe, and heavy runs went through `os-verify-lock.sh`. - `node scripts/check-platform-checklist.mjs`: exit 0. 16 areas, 359 items. Symbol anchors resolved 1134/1144 (base 1096/1106), so all 38 new anchors resolve and the #16898 residual is unchanged at 10. Line citations: 0. - `node scripts/pm/dispatch-gates.mjs --commands`: 16 commands, each exit 0. `--ran` reports 16 derived, 16 run, 0 NOT-MEASURED, 0 UNRUN. The first pass had `check:doc-formula-expressions` exit 3 (lint not built). It was green after the build, and the reconciled list is the second pass. - UI pins: `cd ui && pnpm exec vitest run --maxWorkers=1 …` over the 14 files above: exit 0, 14 files, 242 tests. - Server pins (`pnpm exec vitest run` per package): all exit 0, nothing skipped. - objectql: 3 files, 42 tests - service-automation: 1 file, 16 tests - runtime: 4 files, 97 tests - metadata-protocol: 2 files, 41 tests - cli: 1 integration file, 3 tests - Changed lines: +807 / −39 across 6 files under `docs/qa/platform-checklist/`, within the slice's budget. - `skip-changeset`: docs and checklist only, nothing published. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent 461b0d3 commit 128681f

6 files changed

Lines changed: 807 additions & 39 deletions

File tree

‎docs/qa/platform-checklist/FOLLOW-UPS.md‎

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -819,3 +819,58 @@ steps[0] (`/apps/com.objectstack.setup/metadata/permission/…`) and
819819
`automation.packaged-flow-subflow-disable-refusal` steps[7] (the retired Setup
820820
packaged-automation page as the UI half). Those Setup URLs redirect to Studio since #28818,
821821
so the items still reach a page; their text was not re-measured here.
822+
823+
## 14. Scoped authoring 2026-11-02 — the ADR-0146 promises as items (#28579 slice 2)
824+
825+
**Not a sweep.** One item per promise ADR-0146 shipped, each read from source at `main`
826+
(`eb123b7ccc`) and citing the card that landed it, plus the carry-overs from §13. Each item's
827+
`history` row says what it is and why.
828+
829+
- **New:** `studio-authoring.package-customize-restore-display` (N-17: view, dashboard and
830+
report, from Customize to Restore package original), `automation.package-flow-override`
831+
(N-11/N-18/N-22), `studio-authoring.package-extension-field-c` (N-23c),
832+
`platform-core.customization-pair-ensure-door` (N-13/N-14),
833+
`cli.packageless-overlay-ceremony-and-close` (N-16a/N-16b),
834+
`studio-authoring.package-customization-counts-and-marks` (N-24/N-26b) and
835+
`platform-core.setup-metadata-redirects-to-studio` (N-28).
836+
- **Extended, not twinned:** `studio-authoring.access-permission-set-lifecycle` takes New
837+
similar on a packaged set (N-20b) as steps[6] and acceptance[5].
838+
- **§13a resolved:** `studio-authoring.packaged-display-class-direct-edit` is retired, with
839+
`supersededBy` the new display item (its retiredReason maps each clause). The dashboard
840+
leg moves from the platform's `system_overview` to the showcase's
841+
`showcase_ops_dashboard`. `studio-authoring.org-override-registry-gate`'s open side is now
842+
the declared override from `com.example.showcase.custom`, so its transitional knownGap is
843+
gone. The two §13b clauses are untouched: their knownGap waits on #29374.
844+
- **§13c resolved:** the four items there now name Studio's landing URL instead of the
845+
retired Setup page. `platform-core.metadata-authoring-roundtrip` acceptance[4] also stops
846+
saying a packaged view "accepts" a package-less overlay. Its verify already read the
847+
writable-package save, and that verify is unchanged.
848+
849+
### 14a. The live browser journeys are slice 3's
850+
851+
Every new item's `automated.ref` names the unit and integration pins that hold the contract,
852+
and none of them drives a live deployment. Four items say in `automated.ref` that no e2e spec
853+
walks the browser journey yet, which #28579 slice 3 owes: customize/restore display, the
854+
`__c` extension field, counts and marks, and the flow override. The ensure door, the
855+
ceremony and the redirects are API, CLI and URL contracts, and their live leg is the run's.
856+
857+
### 14b. Measured from source — the pair's uninstall refusal is unreachable for a read-only base
858+
859+
`DELETE /api/v1/packages/:id` runs `requireWritablePackage`
860+
(`packages/runtime/src/domains/packages.ts`) before `assertPackageUninstallable`
861+
(`packages/objectql/src/registry.ts`). So a booted or system/cloud base, such as the showcase,
862+
answers **422 `WRITABLE_PACKAGE_REQUIRED`** and the pair is never asked. The 409
863+
`RESOURCE_CONFLICT` that names the pair and its export URL is reached only for a writable
864+
base whose pair is installed. `platform-core.customization-pair-ensure-door` scores both:
865+
409 on a writable QA base with an exported pair, and 422 on the showcase.
866+
`packages-uninstall-refuse-before-mutate.test.ts` pins the order. A live spec (slice 3) that
867+
expects 409 when uninstalling the showcase will fail. Reach: source-read, not measured live.
868+
869+
### 14c. Product finding — reported, not filed here
870+
871+
Studio's landing still describes the D11-closed model. `engine.studio.landing.description`
872+
and `readonlyHint` (`ui/packages/i18n/src/namespaces/studio/en.ts`, rendered by
873+
`BuilderLanding.tsx`) tell the user to "customize them with an environment overlay".
874+
`BuilderLanding.environmentOverlayCopy-12171.test.ts` pins that phrase. The door is now
875+
Customize, which writes into the base's `.custom` pair. Reach: source-read only. The finding
876+
is in the slice's report for the seat to card.

0 commit comments

Comments
 (0)