Skip to content

Commit 131f855

Browse files
fix(mcp): a coded sandboxed hook crash is a fault on MCP, not a refusal at its declared status (#31290)
<!-- claude-projects-attribution: {"github_login":"os-project-manager"} --> _Requested by **Leehom** · [project thread](https://claude.ai/code/project/chan_01TenzsRopZj4jMbvjX8uz1X?thread=cmsg_01TenzsRopZj4jMbvjX8uz1X3apZSKwFDd6zvjM4gJPKAy)_ Fixes #31269 Clause-②: no Metadata-protocol: none ## 维护者速读 - 改了什么:沙箱 hook 主体在声明了错误码的情况下崩溃(如 `TypeError`),MCP 不再把它当成业务拒绝(声明的码 + 409 + 带 hook 名的包装文本)。现在它和不带码的同一个崩溃答得一样:六个记录数据工具答 `500 INTERNAL_ERROR` / `Internal server error`,并在服务端记一行日志,与 `/api/v1/data` 一致。 - 为什么改:REST 各入口先判断"是不是崩溃"(`isSandboxCrash`),崩溃一律按服务端故障答 500;MCP 只看错误码,于是把 hook 内部名和原生错误文字以业务状态码交给 agent。 - 风险与回滚:只在 `@objectstack/mcp` 的 `thrownRefusalEnvelope` 加一行,直接调用 `@objectstack/types` 已导出的同一个判断函数;不带崩溃的带码拒绝不变。回滚即删这一行。patch。 - 先看:`packages/mcp/src/mcp-http-tools.ts` 的 `thrownRefusalEnvelope`;`packages/mcp/src/mcp-coded-refusal.test.ts` 末尾的 #31269 块。 - 两分钟验证:`pnpm --filter @objectstack/mcp exec vitest run src/mcp-coded-refusal.test.ts -t 31269`,预期 15 个用例全部通过。 - 需要你做的:无,席位落地。 ## What changes `thrownRefusalEnvelope` (`packages/mcp/src/mcp-http-tools.ts`), the one reader every MCP face uses to tell a coded refusal, now returns `undefined` when `isSandboxCrash(err)`. `isSandboxCrash` is the predicate `classifyDataError` and `resolveErrorResponse` ask before any code-gated arm. `@objectstack/types` already exports it (`rest`'s `error-response.ts` imports it), so no export is added and there is no copy of the crash read in `packages/mcp`. A sandboxed body that crashed while declaring a code is therefore no coded refusal, and each face renders it as it renders the same crash with no code. That is the fault answer each face already gives an uncoded crash today, not a new shape. Measured on `/mcp` over a bridge member throwing the real runner's `SandboxError` (`message` `hook 'demo_guard' threw: TypeError: boom`, `innerMessage` `TypeError: boom`, `code` `RECORD_LOCKED`, `status` 409): | Face | Before | Now (= that face's answer to the same crash with no code) | REST door | |---|---|---|---| | `query_records`, `aggregate_records`, `get_record`, `create_record`, `update_record`, `delete_record` | `RECORD_LOCKED` · wrapper · 409 | `INTERNAL_ERROR` · `Internal server error` · 500, one `[5xx] 500 tools/call TOOL task — …` log line | `/data`: `500 INTERNAL_ERROR` `Internal server error` | | `delete_records` (a row that crashes) | fault with `code: RECORD_LOCKED`, `status: 409`, the wrapper quoted | the uncoded fault answer: no code, no status, the thrown message quoted (kept on purpose, PR #31245 note) | n/a | | `list_objects`, `describe_object`, `validate_expression`, `list_actions`, `delete_records` outer catch | `RECORD_LOCKED` · wrapper · 409 | the bare thrown text (today's uncoded rendering) | `/meta`: `500 INTERNAL_ERROR` | | `run_action`, `resume_run` | `RECORD_LOCKED` · wrapper · 409 | the bare thrown text (today's uncoded rendering) | `/actions`: `500 INTERNAL_ERROR` | | record resource | `{ error: wrapper, code: RECORD_LOCKED, status: 409 }` | `{ error: wrapper }` (today's uncoded rendering) | `/data`: `500 INTERNAL_ERROR` | No face serves the declared code or its business status for a crash any more. The record data tools now give the doors' full fault answer. On the other faces, the crash's text is still the face's uncoded rendering, which carries the wrapper. Those renderings are the next cards in this chain, which the order fences out of this PR: #31270 (record resource), #31271 (`run_action` / `resume_run`), #31272 (metadata tools and `list_actions`). When they land, the coded crash follows them, because the pins hold each such face equal to its code-less answer. `delete_records`' outer catch and its fault quote are kept as intended (PR #31245 and #31268). Unchanged, measured before and after on the same probe: a coded sandboxed refusal (`Locked.` 409, #31246), a code-less sandboxed abort, a bare `Error`, and a driver string code (`SQLITE_BUSY`, #31273's face) answer byte for byte as before on every face. ## Tests `packages/mcp/src/mcp-coded-refusal.test.ts`, a new `#31269` describe on the shared `/mcp` harness: - each of the six record data tools: `{ code: 'INTERNAL_ERROR', message: 'Internal server error', status: 500 }`, equal to `mapDataError`'s answer to the same throw; the text carries no hook name and no `TypeError`; one `[5xx] 500 tools/call TOOL task — ` log line; - every other tool (the `SITES` table, which is held equal to the registered tool list): the coded crash's answer equals the same crash's answer with no code, and `RECORD_LOCKED` / `409` are absent; - CONTROL: a coded sandboxed refusal keeps `{ code: 'RECORD_LOCKED', message: 'Locked.', status: 409 }` on every tool. In the record-resource describe: the coded crash answers byte for byte what the same crash with no code answers, and `RECORD_LOCKED` is absent. `packages/mcp/src/mcp-delete-records.test.ts`: a row that crashes with a declared code stops the call as a fault with no code and no status, and the whole answer equals the one for the same crash with no code. <details><summary>Red first and ablation</summary> Red first on `b3bd75d8` (`main`, with PR #31268), new pins and no fix: `Tests 15 failed | 107 passed (122)` across the two files. The CONTROL passed. The real runner probe (`QuickJSScriptRunner`, hook body `throw Object.assign(new TypeError('boom'), { code: 'RECORD_LOCKED', status: 409 })`) gave `message` `hook 'demo_guard' threw: TypeError: boom`, `innerMessage` `TypeError: boom`, `code` `RECORD_LOCKED`, `status` 409. `mapDataError` answered `500 INTERNAL_ERROR` `Internal server error`, while every MCP tool and the record resource answered `RECORD_LOCKED` / wrapper / 409. With the fix: `Tests 122 passed (122)`. Ablation (`node scripts/ablation-replace.mjs`, `mcp-http-tools.ts`): `if (isSandboxCrash(err)) return undefined;` replaced by `if (isSandboxCrash(err) && String("ABL").length < 0) return undefined;`. Output: `ok mutation landed: anchor 1 -> 0, blob eca0c12 -> c7b949836b5f`, then `Tests 15 failed | 107 passed (122)`, then `ok restored: blob == HEAD (eca0c12) and git diff HEAD is empty`. The tests import the package's source, so no `dist/` is involved. </details> ## Acceptance notes - `Clause-②: no`: no export is added (`isSandboxCrash` was already on `@objectstack/types`' entry), and no published type changes. The answer that moves is a crash's text and status on MCP, which become the fault answer each face already gives. - The hook name still reaches an agent on the record resource, `run_action` / `resume_run`, and the metadata tools and `list_actions`, through their code-less renderings. Their carriers are #31270, #31271 and #31272, as the order rules. ## Verification Base: `b3bd75d8`; head: `f7517feb`. - `pnpm --filter @objectstack/mcp test`: `Test Files 60 passed (60)`, `Tests 822 passed (822)`, lock `VERDICT command-exit 0`. - `pnpm --filter @objectstack/mcp typecheck`: exit 0 (`check:test-typecheck`: 53 errors / 8 pinned signatures held). - `pnpm exec eslint --no-inline-config` on the three touched `.ts` files: exit 0 (`@objectstack/mcp` has no `lint` script). <details><summary>Derived gates (node scripts/pm/dispatch-gates.mjs --commands, 62 commands, all on f7517fe)</summary> - `node scripts/check-adr-0087-registration.mjs --base origin/main` :: exit 0 - `node scripts/check-adr-0087-registration.mjs --self-test` :: exit 0 - `node scripts/check-changeset-no-major.mjs --base origin/main` :: exit 0 - `node scripts/check-closing-keyword-parity.mjs` :: exit 0 - `node scripts/check-closing-keyword-parity.mjs --self-test` :: exit 0 - `node scripts/check-comment-mask-adoption.mjs` :: exit 0 - `node scripts/check-comment-mask-adoption.mjs --self-test` :: exit 0 - `node scripts/check-comment-mask-corpus.mjs` :: exit 0 - `node scripts/check-dts-emitted.mjs --self-test` :: exit 0 - `node scripts/check-empty-changeset.mjs --base origin/main` :: exit 0 - `node scripts/check-empty-changeset.mjs --self-test` :: exit 0 - `node scripts/check-issue-citations.mjs` :: exit 0 - `node scripts/check-plugin-teardown-shape.mjs` :: exit 0 - `node scripts/check-plugin-teardown-shape.mjs --self-test` :: exit 0 - `node scripts/ci/assert-turbo-remote-cache.mjs --self-test` :: exit 0 - `node scripts/ci/plan-test-core-shards.mjs --self-test` :: exit 0 - `node scripts/ci/prune-turbo-cache.mjs --self-test` :: exit 0 - `node scripts/ci/snapshot-next.mjs --self-test` :: exit 0 - `node scripts/docs-audit/check-affected-docs.mjs` :: exit 0 - `node scripts/docs-audit/check-drift-comment.mjs` :: exit 0 - `node scripts/pm/release-rehearsal-clone.mjs --self-test` :: exit 0 - `node scripts/release-pending-publish.mjs --self-test` :: exit 0 - `pnpm --filter @objectstack/spec run check:duration-unit-keys` :: exit 0 - `pnpm --filter @objectstack/spec run check:error-code-provenance` :: exit 0 - `pnpm check:adr-symbol-anchors` :: exit 0 - `pnpm check:changeset-gate-self-tests` :: exit 0 - `pnpm check:ci-filter-parity` :: exit 0 - `pnpm check:closed-ceremony-text` :: exit 0 - `pnpm check:cross-package-test-inputs` :: exit 0 - `pnpm check:dispatcher-error-vocabulary` :: exit 0 - `pnpm check:doc-authoring` :: exit 0 - `pnpm check:driver-memory-census` :: exit 0 - `pnpm check:dts-closure` :: exit 0 - `pnpm check:dual-build-cjs-loads` :: exit 0 - `pnpm check:engine-double-contract` :: exit 0 - `pnpm check:error-status-conformance` :: exit 0 - `pnpm check:gitlink-declared` :: exit 0 - `pnpm check:issue-citations` :: exit 0 - `pnpm check:keyed-text-bounds` :: exit 0 - `pnpm check:lean-entry-closure` :: exit 0 - `pnpm check:logger-receiver-detach` :: exit 0 - `pnpm check:nul-bytes` :: exit 0 - `pnpm check:objectql-double-limit` :: exit 0 - `pnpm check:org-identifier` :: exit 0 - `pnpm check:page-declaration-shape` :: exit 0 - `pnpm check:platform-object-tenancy-census` :: exit 0 - `pnpm check:published-files` :: exit 0 - `pnpm check:query-options-erasure` :: exit 0 - `pnpm check:refd-timer-probe` :: exit 0 - `pnpm check:registry-log-declared` :: exit 0 - `pnpm check:rest-log-spy-declared` :: exit 0 - `pnpm check:slot-lookup` :: exit 0 - `pnpm check:sourcemap-no-sources-content` :: exit 0 - `pnpm check:system-context-census` :: exit 0 - `pnpm check:test-source-alias` :: exit 0 - `pnpm check:tier-file-adoption` :: exit 0 - `pnpm check:type-check-coverage` :: exit 0 - `pnpm check:type-check-debt` :: exit 0 - `pnpm check:undeclared-dep-imports` :: exit 0 - `pnpm check:vouch-for-reference-callers` :: exit 0 - `pnpm check:watch-hint-literal` :: exit 0 - `pnpm check:where-matcher` :: exit 0 `node scripts/pm/dispatch-gates.mjs --ran`: `62 derived famil(ies) accounted for — 62 run, 0 NOT-MEASURED`. `check:dual-build-cjs-loads` first exited 3 (PREREQUISITE NOT MET: not every package had a dist). It exited 0 when re-run after `check:type-check-debt` had built every package. Not run locally (CI's): `test:repo`, the dogfood shards, the type-check lanes. </details> ## Human Minimum - [x] 1. Schemas start as Zod; `packages/spec` holds no runtime logic. (Not touched.) - [x] 2. Every name I added uses the casing for its kind. - [x] 3. No formatter ran; `pnpm lint` passes. (eslint on the touched files.) - [x] 4. One issue, one branch off an up-to-date `main`, one pull request. - [x] 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset. - [x] 6. `packages/spec` touched: its generated artifacts are regenerated and committed. (Not touched.) - [x] 7. No hand edits to `content/docs/references/`, `packages/*/CHANGELOG.md` or `content/docs/releases/`. - [x] 8. Title, body and comments are in English. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01FEkQ5oWCPWH6i2Lsts9cdP Co-authored-by: Claude <noreply@anthropic.com>
1 parent 534a287 commit 131f855

4 files changed

Lines changed: 127 additions & 1 deletion

File tree

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
'@objectstack/mcp': patch
3+
---
4+
5+
fix(mcp): a sandboxed hook body that crashes while declaring a code is a fault on MCP, not a refusal at its declared status
6+
7+
Clause-②: no
8+
Metadata-protocol: none
9+
10+
A QuickJS hook body that crashed while declaring a code, for example `throw Object.assign(new TypeError('boom'), { code: 'RECORD_LOCKED', status: 409 })`, reached every MCP tool and the `objectstack://objects/{name}/records/{id}` resource as `{ code: 'RECORD_LOCKED', message: "hook '<name>' threw: TypeError: boom", status: 409 }`: the hook's internal name and the native error text, at a status that reads as a business refusal. `/api/v1/data`, `/meta` and `/actions` classify such a crash first and answer `500 INTERNAL_ERROR`.
11+
12+
MCP now asks the doors' own crash predicate (`isSandboxCrash`, `@objectstack/types`) before it reads a thrown code, so a crash with a declared code is answered as the same crash with no code. The record data tools (`query_records`, `aggregate_records`, `get_record`, `create_record`, `update_record`, `delete_record`) answer `{ "error": { "code": "INTERNAL_ERROR", "message": "Internal server error", "status": 500 } }` and log the crash once on the server, as `/api/v1/data` does. The other tools, `delete_records` and the record resource answer what they answer today for a crash with no code. A sandboxed body's coded refusal (no crash) is unchanged.

‎packages/mcp/src/mcp-coded-refusal.test.ts‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,17 @@ describe('the record resource: a coded refusal adds its code beside the unchange
553553
);
554554
});
555555

556+
it('[#31269] a coded sandboxed CRASH answers what the same crash with no code answers; its code and status are not served', async () => {
557+
const crash = (extra: Record<string, unknown> = {}) => Object.assign(
558+
new Error("hook 'demo_crash_guard' threw: TypeError: boom"),
559+
{ name: 'SandboxError', innerMessage: 'TypeError: boom' },
560+
extra,
561+
);
562+
const coded = await readRefused(crash({ code: 'RECORD_LOCKED', status: 409 }));
563+
expect(coded).toBe(await readRefused(crash()));
564+
expect(coded).not.toContain('RECORD_LOCKED');
565+
});
566+
556567
it('a code-less throw answers `{ error }` byte-identically', async () => {
557568
expect(await readRefused(new Error('engine exploded'))).toBe(JSON.stringify({ error: 'engine exploded' }));
558569
expect(await readRefused('a thrown string')).toBe(JSON.stringify({ error: 'a thrown string' }));
@@ -561,3 +572,68 @@ describe('the record resource: a coded refusal adds its code beside the unchange
561572
);
562573
});
563574
});
575+
576+
/**
577+
* [#31269] A sandboxed body that CRASHED while declaring a code (a hook body's
578+
* `throw Object.assign(new TypeError('boom'), { code: 'RECORD_LOCKED', status: 409 })`)
579+
* is a fault, not a refusal. The doors classify it first (`isSandboxCrash`,
580+
* `@objectstack/types`) and answer `500 INTERNAL_ERROR`; MCP's coded path read
581+
* the declared code and status and the runner's wrapper, so an agent saw the
582+
* hook's name and the native error text at a business status.
583+
*
584+
* `thrownRefusalEnvelope` now asks that same predicate, so a coded crash is no
585+
* coded refusal and each face renders it as it renders the same crash with no
586+
* code: the record data tools answer the `/data` door's fault, every other
587+
* face its own uncoded rendering (those faces' code-less renderings are
588+
* #31270–#31272's, and this card does not touch them).
589+
*/
590+
describe('a coded sandboxed CRASH is a fault on every face, never a refusal at its declared status (#31269)', () => {
591+
const CRASH_TEXT = "hook 'demo_crash_guard' threw: TypeError: boom";
592+
593+
/** The `SandboxError` the QuickJS runner raises for the crash above (measured on the real runner). */
594+
function crash(extra: Record<string, unknown> = {}): Error {
595+
return Object.assign(new Error(CRASH_TEXT), { name: 'SandboxError', innerMessage: 'TypeError: boom' }, extra);
596+
}
597+
const codedCrash = () => crash({ code: 'RECORD_LOCKED', status: 409 });
598+
599+
afterEach(() => {
600+
vi.restoreAllMocks();
601+
});
602+
603+
for (const site of SITES.filter((s) => s.dataDoor)) {
604+
it(`${site.tool}: 500 INTERNAL_ERROR, the /data door's answer, logged once; no hook name, no native text`, async () => {
605+
const log = vi.spyOn(console, 'error').mockImplementation(() => {});
606+
const thrown = codedCrash();
607+
const result = await callTool(site, thrown);
608+
expect(result.isError).toBe(true);
609+
const error = JSON.parse(result.content[0].text).error;
610+
expect(error).toEqual({ code: 'INTERNAL_ERROR', message: 'Internal server error', status: 500 });
611+
const door = mapDataError(thrown, 'task');
612+
expect(error).toEqual({ code: door.body.code, message: door.body.error, status: door.status });
613+
expect(result.content[0].text).not.toContain('demo_crash_guard');
614+
expect(result.content[0].text).not.toContain('TypeError');
615+
expect(log).toHaveBeenCalledTimes(1);
616+
expect(String(log.mock.calls[0]![0])).toMatch(new RegExp(`^\\[5xx\\] 500 tools/call ${site.tool} task — `));
617+
});
618+
}
619+
620+
for (const site of SITES.filter((s) => !s.dataDoor)) {
621+
it(`${site.tool}: answers what it answers for the same crash with no code; its declared code and status are not served`, async () => {
622+
vi.spyOn(console, 'error').mockImplementation(() => {});
623+
const coded = await callTool(site, codedCrash());
624+
expect(coded).toEqual(await callTool(site, crash()));
625+
expect(coded.content[0].text).not.toContain('RECORD_LOCKED');
626+
expect(coded.content[0].text).not.toContain('409');
627+
});
628+
}
629+
630+
// CONTROL: a coded sandboxed REFUSAL keeps the #31246 answer on every face.
631+
it('CONTROL: a coded sandboxed refusal keeps its code, inner sentence and status', async () => {
632+
const refusal = crash({ innerMessage: 'Locked.', code: 'RECORD_LOCKED', status: 409 });
633+
for (const site of SITES) {
634+
expect(JSON.parse((await callTool(site, refusal)).content[0].text), site.tool).toEqual({
635+
error: { code: 'RECORD_LOCKED', message: 'Locked.', status: 409 },
636+
});
637+
}
638+
});
639+
});

‎packages/mcp/src/mcp-delete-records.test.ts‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -680,6 +680,30 @@ describe('MCP delete_records: many records of one object in one confirmed call (
680680
});
681681
expect(result.content[0]!.text).not.toContain('dlr_task_guard');
682682
});
683+
684+
it('[#31269] a sandboxed body that CRASHED with a declared code is a fault, answered as the same crash with no code', async () => {
685+
const crash = (extra: Record<string, unknown> = {}) => Object.assign(
686+
new Error("hook 'dlr_task_guard' threw: TypeError: boom"),
687+
{ name: 'SandboxError', innerMessage: 'TypeError: boom' },
688+
extra,
689+
);
690+
const run = async (thrown: Error) => {
691+
rows.get('t3')!.throws = thrown;
692+
return callTool(bridge, 'delete_records', {
693+
objectName: OBJECT,
694+
recordIds: ['t3', 't6'],
695+
[AI_ACTION_CONFIRMATION_MEMBER]: true,
696+
});
697+
};
698+
699+
const coded = await run(crash({ code: 'RECORD_LOCKED', status: 409 }));
700+
expect(coded.isError).toBe(true);
701+
const { error, progress } = parsed(coded);
702+
expect(error.code).toBeUndefined();
703+
expect(error.status).toBeUndefined();
704+
expect(progress).toMatchObject({ attempted: 1, deleted: 0, refused: 0, stoppedAt: 't3', notAttempted: 1 });
705+
expect(coded).toEqual(await run(crash()));
706+
});
683707
});
684708

685709
it('the long-lived server the stdio transport serves refuses, previews and deletes the same way', async () => {

‎packages/mcp/src/mcp-http-tools.ts‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ import { StandardErrorCode, type ErrorCode } from '@objectstack/spec/api';
5050
// [#23701] The one key every door that translates the engine's unique-violation
5151
// envelope asks (the registered code AND the class name, never message text),
5252
// and the one classification whose arm states the wire code for it.
53-
import { earnedAnswerOf, isEngineDuplicateRecordEnvelope, isServerFault, logServerFault, mapDataError, resolveQueryReadLimits, sandboxBusinessMessage, staleSummaryAnswerLines, structuredCodeAnswer, type SummaryRecomputeRefusal } from '@objectstack/types';
53+
import { earnedAnswerOf, isEngineDuplicateRecordEnvelope, isSandboxCrash, isServerFault, logServerFault, mapDataError, resolveQueryReadLimits, sandboxBusinessMessage, staleSummaryAnswerLines, structuredCodeAnswer, type SummaryRecomputeRefusal } from '@objectstack/types';
5454
import {
5555
MCP_OAUTH_SCOPE_DATA_READ,
5656
MCP_OAUTH_SCOPE_DATA_WRITE,
@@ -1131,10 +1131,24 @@ export interface ThrownRefusalEnvelope {
11311131
* reader, never a copy of its logic here, and never a strip of the wrapper's
11321132
* prose: a non-sandbox refusal keeps its own message byte for byte. The code
11331133
* and status are unchanged.
1134+
*
1135+
* ## A sandboxed body that crashed is not a coded refusal (#31269)
1136+
*
1137+
* A body that CRASHED while declaring a code (`throw Object.assign(new
1138+
* TypeError('boom'), { code, status })`) is a fault: the doors ask
1139+
* `isSandboxCrash` (`@objectstack/types`) before any code-gated arm and answer
1140+
* `500 INTERNAL_ERROR`, because a declared code is the author's statement
1141+
* about a failure mode they handled, and a crash is not one. This reader asks
1142+
* the same predicate and answers `undefined`, so every face renders the crash
1143+
* as it renders the same crash with no code: the record data tools answer the
1144+
* `/data` door's fault ({@link dataDoorErrorResult}), and no face serves the
1145+
* declared code, its business status or the runner's wrapper as a refusal.
1146+
* ⛔ One predicate, never a copy of the crash read here.
11341147
*/
11351148
export function thrownRefusalEnvelope(err: unknown): ThrownRefusalEnvelope | undefined {
11361149
const thrownCode = (err as { code?: unknown } | null | undefined)?.code;
11371150
if (typeof thrownCode !== 'string' || thrownCode.length === 0) return undefined;
1151+
if (isSandboxCrash(err)) return undefined;
11381152
const status = (err as { status?: unknown }).status;
11391153
return {
11401154
code: wireCodeOf(err, thrownCode),

0 commit comments

Comments
 (0)