Skip to content

Commit 1685a06

Browse files
docs(pm-dispatch): the director seat stops presenting governed drafts in a ruling batch (#26693)
<!-- claude-projects-attribution: {"github_login":"os-steve"} --> _Requested by **Steve** · [project thread](https://claude.ai/code/project/chan_01FdL1XeUyvVNxLreh3F4Qi9?thread=cmsg_01FdL1XeUyvVNxLreh3F4Qi9KtT2goQEmcLve8BQ7enWSn)_ Fixes #26671 Clause-②: no Metadata-protocol: none ## 维护者速读 - 改了什么:总监席不再把受管草稿 PR 编进决裁批「一 PR 一行」呈给你、也不再要你在聊天里回「同意」;改为一条核对职责:PR 等你批之前,席位核齐四件(席位记录、维护者速读、经中继请你审核、head 全绿),缺的补上。 - 为什么改:你的原话「pr 你交给我批的价值是什么,我说同意你能合并吗」「所以总监席你呈给我完全没必要啊」——聊天里的「同意」落不进门禁,又和 PR 正文的速读重复。 - 风险与回滚:只删两份 pm-dispatch 参考文档里的规则行(净 −2 行),不动 AGENTS.md、GOVERNED_APPROVERS 与入队守卫;回滚即 revert 本 PR。 - 先看:`.claude/skills/pm-dispatch/references/lanes/director.md` 第 57–58 行(新的四件核对);`.claude/skills/pm-dispatch/references/decision-analysis.md` 原第 13 行(删除的例外)。 - 两分钟验证:`git grep -n 受管草稿 .claude/skills/pm-dispatch` 应无输出。 - 需要你做的:批准本 PR(GOVERNED_APPROVERS);席位已请总监契约复核,批准后席位落地。 ## What changes - `.claude/skills/pm-dispatch/references/decision-analysis.md`: the governed-draft batch exception (one row per PR in a ruling batch) is deleted. - `.claude/skills/pm-dispatch/references/lanes/director.md`: the three governed-draft batch lines (the draft list diff, the batch of at most five rows, recording batch replies per PR) become one duty in two lines: before a governed PR waits on the maintainer the seat checks four pieces (seat record, 维护者速读, review requested through the relay `pr_request_reviewers`, green head), fills the missing ones, never puts the PR into a batch and never asks for a chat 「同意」; approval and merge stay the maintainer's click. - Line count: decision-analysis.md 50 to 49, director.md 88 to 87 (3 lines out, 2 in). The new duty takes two lines, not one, because the 120-byte line cap cannot hold the four pieces plus both prohibitions on one line. ## Tests No test edits; no forced test edit. Docs-only diff on a governed `.claude/**` surface. ## Acceptance notes - `git grep -n 受管草稿 .claude/skills/pm-dispatch` now prints nothing (exit 1); before, it printed decision-analysis.md:13 and director.md:57. - Surviving homes for the retired text: "approval and merge stay the maintainer's click" is kept in the new line and in director.md 职责一 (到合并 = 推进到就绪并点名等待); the review request through the relay is also SKILL.md 复核 (缺口经中继 `pr_request_reviewers` 补). - director.md 33–34 (enumerating landed governed PRs for review quality) is untouched, as the card delta requires. - AGENTS.md Prime Directive 14 still says "the director seat requests the word as ONE batch of at most five rows". The card forbids an AGENTS.md change here, so that sentence now disagrees with the skill line and AGENTS.md wins conflicts. It needs its own Tier H follow-up for the maintainer; named in the os-dev-report for the seat. - The two ratchet ceilings (50 and 88) are left as they are, so each file now has 1 line of headroom; the ratchet script is outside this card's file surface. ## Verification Head `eac0bda1`, local gate set from `node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack`, run after the last commit: <details><summary>17 derived families, all exit 0; --ran reconciliation</summary> ``` node scripts/check-closing-keyword-parity.mjs :: exit 0 node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0 node scripts/check-comment-mask-corpus.mjs :: exit 0 node scripts/pm/check-harness-current.mjs --self-test :: exit 0 pnpm --filter @objectstack/lint run check:doc-formula-expressions :: exit 0 (first run exit 3 prerequisite; built formula+lint under os-verify-lock, VERDICT command-exit 0, rerun exit 0) pnpm check:agent-test-spelling :: exit 0 pnpm check:cross-package-test-inputs :: exit 0 pnpm check:doc-authoring :: exit 0 pnpm check:driver-memory-census :: exit 0 pnpm check:gitlink-declared :: exit 0 pnpm check:nul-bytes :: exit 0 pnpm check:pm-governed-merges :: exit 0 pnpm check:pm-skill-id-lint :: exit 0 pnpm check:pm-skill-ratchet :: exit 0 pnpm check:refd-timer-probe :: exit 0 pnpm check:skill-frame-sync :: exit 0 pnpm check:watch-hint-literal :: exit 0 Run reconciliation — 17 derived, 17 run, 0 NOT-MEASURED, 0 UNRUN. ✓ dispatch-gates --ran: 17 derived famil(ies) accounted for — 17 run, 0 NOT-MEASURED (a DERIVED zero — all 17 recorded an exit code and none of them is 3). ``` ``` ✓ check-skill-line-ratchet: .claude/skills/pm-dispatch/references/decision-analysis.md is 49 lines (ceiling 50; headroom 1). ✓ check-skill-line-ratchet: .claude/skills/pm-dispatch/references/lanes/director.md is 87 lines (ceiling 88; headroom 1). ✓ check-skill-id-lint: 104 file(s) clean (pattern /#[0-9]{3,}/g). ``` </details> Tier S governed surface: this PR stays draft; the seat asks the director for the contract review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01ADHkmRU8xsrP6izdDAuZvx --- _Generated by [Claude Code](https://claude.ai/code/session_01ADHkmRU8xsrP6izdDAuZvx)_ Co-authored-by: Claude <noreply@anthropic.com>
1 parent e744244 commit 1685a06

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

‎.claude/skills/pm-dispatch/references/decision-analysis.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
- 入批前认领:`Brief-claimed-by:` 行的写法、跳过与接管判据住 `lanes/director.md` 职责二。
1111
- 回批一行式逐卡对应字母选项;带的附加条件随执行落地,⛔ 不为它另起请示轮。
1212
- 呈递详解 = 逐卡散文按正文六项;⛔ 表格行、判词、栅格不构成详解,压缩批次是违规。
13-
- 受管草稿批例外:一 PR 一行(改了什么/为什么/席位意见/一个动作),⛔ 不套六项;速读住 PR。
1413
- 重分析轮同纪律;适用面 = 任何席位向维护者呈递的待裁项,⛔ 不及结果陈述如轮报表格。
1514

1615
## 落卡分析模板

‎.claude/skills/pm-dispatch/references/lanes/director.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@
5454
- 入箱勤务:校验/补全四棱块、速读与 `Prior rulings on this card:` 行;入箱同笔现读前提。
5555
- 线程有 `Ruling:`/RULED 的卡再入箱,该行逐 id 各一句变化;缺行 ⇒ 拒入,`pm:retriage` 回立卡者。
5656
- 一次只开一批:维护者对批 N 回字(一字即可)后,新到才合成批 N+1;续批至清零才收工。
57-
- 受管草稿批:两仓 `is:pr is:open is:draft label:needs-user-decision` 对照等人合清单,差集点名。
58-
- 有席内 ACCEPT 者呈一批 ≤5 行,写法见 `../decision-analysis.md`;四件缺一者列缺口不呈。
59-
- 回批原话逐 PR 记到 PR 上,缺的请审补上即止步;批准与合并恒是维护者的点击,⛔ 不代。
57+
- 受管 PR 待人批前核四件:席位记录、维护者速读、中继 `pr_request_reviewers` 请审、绿 head。
58+
- 缺件即补;⛔ 不入批、不求聊天「同意」;批准与合并恒是维护者的点击,⛔ 不代。
6059
- 呈报前逐卡逐仓重跑 `git grep -n -iE 'TERMS' origin/main -- AGENTS.md docs/adr packages/spec/src`。
6160
- 以协议为准:消费面对齐协议 ⇒ 荐对齐呈批,协议没有的能力荐删;⛔ 不自裁。
6261
- 协议是否正确由本席按①读协议原文与主流平台分析,有误即荐改动呈批,⛔ 不自裁。

0 commit comments

Comments
 (0)