Skip to content

Commit 1a50dca

Browse files
committed
docs(adr): ADR-0119 names the retired DataEngineRequest without a symbol anchor (#27028)
`check:adr-symbol-anchors` reds once `DataEngineRequest` leaves `data/data-engine.zod.ts`: ADR-0119's "Rot found on the way" anchored it as `data-engine.zod.ts#DataEngineRequest`. The gate's remedy is to fix the anchor, so the sentence keeps the name, points at the file, and an editorial note (the record's own 2026-08-05 precedent) says the protocol has since been retired and where it is registered. The finding itself is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGufziUAPh2YojDuNQpVXp
1 parent 644adb1 commit 1a50dca

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎docs/adr/0119-plugin-reachable-transactions-and-honest-atomic-batch.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ The honest shape is therefore *both*: the transaction is the unit of atomicity f
5858

5959
### Rot found on the way
6060

61-
**`IDataEngine.batch?`** (`packages/spec/src/contracts/data-engine.ts#IDataEngine`) — the member #4612 opens with. Optional, so nothing must implement it; no engine does. Its entire specification is the three-word comment `Batch Operations (Transactional)` — nothing about partial failure, ordering, cross-object references, rollback scope, or what `transaction: false` means. `DataEngineRequest` is imported by exactly one non-spec file: the contract declaring it. Its request union (`packages/spec/src/data/data-engine.zod.ts#DataEngineRequest`) even nests batches recursively, a shape nobody designed against because nobody built it. The only test (`packages/spec/src/contracts/data-engine.test.ts`) constructs an ad-hoc literal with a `batch` property and asserts it is defined — it pins the type, not an implementation.
61+
**`IDataEngine.batch?`** (`packages/spec/src/contracts/data-engine.ts#IDataEngine`) — the member #4612 opens with. Optional, so nothing must implement it; no engine does. Its entire specification is the three-word comment `Batch Operations (Transactional)` — nothing about partial failure, ordering, cross-object references, rollback scope, or what `transaction: false` means. `DataEngineRequest` is imported by exactly one non-spec file: the contract declaring it. Its request union (`DataEngineRequest`, in `packages/spec/src/data/data-engine.zod.ts`) even nests batches recursively, a shape nobody designed against because nobody built it. The only test (`packages/spec/src/contracts/data-engine.test.ts`) constructs an ad-hoc literal with a `batch` property and asserts it is defined — it pins the type, not an implementation.
62+
63+
> **Editorial note (2026-10-28, #27028):** `DataEngineRequest` and the rest of that request protocol have since been retired (ADR-0049 enforce-or-remove; registered as `packages/spec/src/migrations/entries/semantic/18.data-engine-rpc-protocol-retired.ts`), so the symbol is named here without an anchor. The finding stands as written: nothing served the union.
6264
6365
**`batchData`'s `atomic` flag** (`packages/metadata-protocol/src/protocol.ts#batchData`) — advertised as *"rollback entire batch on any failure (transaction mode)"*. It opens no transaction. It breaks the loop :
6466

0 commit comments

Comments
 (0)