Repository navigation
Commit 1b3e22f
pm-dispatch: a pending-changeset correction is confirmed by the dispatching seat's record, never by a maintainer wait (#30845)
<!-- claude-projects-attribution: {"github_login":"os-tesla"} -->
_Requested by **Tesla** · [project
thread](https://claude.ai/code/project/chan_01AXsQkLFKRdQCqQ3RTr6Jao?thread=cmsg_01AXsQkLFKRdQCqQ3RTr6JaoX8nvRQff2oqQnbG7NKDgZ8)_
Fixes #30271
Clause-②: no
Metadata-protocol: none
## 维护者速读
- 改了什么:`check-empty-changeset` 的 DELIBERATE CORRECTION
补救句现在点名由谁确认:派发席自己的记录(纯文字 diff 用 ACCEPT,其余用同 head 达档契约复审 PASS,出处
`landing-operations.md`),⛔ 不等维护者;dev 侧(`os-dev.md`)改为在 PR 正文申报
DELIBERATE CORRECTION、逐 note 引改后句、不请维护者确认;`execution-duties.md`
那行改为指向唯一成文处。判决不变:该类照旧拒收。
- 为什么改:规则早就在 `landing-operations.md`,但 dev 与门禁实际读到的文字只说「get it
confirmed」不说由谁,本周三张安全修复 PR 在正文里请维护者确认,席位等到维护者答复才落地。维护者已说「changeset
改写确认都同意」;本 PR 只是把既有规则写进读者会看到的那几行。
- 风险与回滚:只改门禁的补救文案与其自测断言、两份内部指令文本;不改任何判决、schema 或运行时。回滚即 revert。
- 先看:`scripts/check-empty-changeset.mjs`(常量 `FOREIGN_CORRECTION_REMEDY`
与 `reportForeign` 的 DELIBERATE CORRECTION 段)、`.claude/agents/os-dev.md`
L300–301(新两行,付账删原
L100)、`.claude/skills/pm-dispatch/references/execution-duties.md` L180。
- 两分钟验证:`node scripts/check-empty-changeset.mjs --self-test`,预期末行 `✓
check-empty-changeset --self-test: 167 assertions …`;`pnpm
check:pm-skill-ratchet` 预期全绿且 `os-dev.md is 405 lines (ceiling 405;
headroom 0)`。
- 需要你做的:无,席位落地(Tier S:`.claude/**` 加非受管脚本)。
## What changes
**`scripts/check-empty-changeset.mjs`** (card item 1 — the gate's remedy
line)
- `FOREIGN_CORRECTION_REMEDY` now names the confirmer by pointing at the
record that confirms: "do NOT restore it -- declare the DELIBERATE
CORRECTION on the PR, naming each note; the dispatching seat confirms it
by its own record (its ACCEPT, or its same-head at-tier contract-review
PASS: pm-dispatch references/landing-operations.md), never a maintainer
wait". The one-source / two-renderings construction is untouched: the
constant is still interpolated into `FOREIGN_TWO_CLASS_LINES`, which the
body renders as indented lines and the `::error` annotation as one line,
and the equality pin still reads the block back out of the rendered
body.
- The DELIBERATE CORRECTION paragraph of `reportForeign` says the same
in prose (declare it, name each note, quote the corrected sentences; the
dispatching seat confirms by ACCEPT or same-head at-tier PASS; do not
ask the maintainer and do not wait) and keeps "this gate stays red
either way".
- The constant's docblock and the header's two-class table say why the
confirmer is named.
- **Verdict unchanged.** `scanForeign`, `--diff-filter=MD`,
`--no-renames`, the merge-base derivation and both exemptions are not
touched; the "D strength" fixture (a PR that adds its own changeset and
rewrites a foreign one) is still refused by name.
- Self-test kept in step: the routing assertion now looks for "the
dispatching seat, by its own record" instead of "get it confirmed"; two
assertions are added (the remedy carries the confirmer and
`references/landing-operations.md`; the body says "Do not ask the
maintainer to confirm it"); the D battery's floor moves 12 → 14 to
match.
**`.claude/agents/os-dev.md`** (card item 2 — the dev's side; the
PR-body duties live here, under 「Definition of done」)
- L300–301 replace the one line 「PR 改到已有的 `.changeset/*.md`:… 确认走 PR
文字。」 with two: the dev declares the DELIBERATE CORRECTION in the PR
body, names each note and quotes the corrected sentences, and ⛔ does not
ask the maintainer to confirm — the dispatching seat's record confirms
(`landing-operations.md`).
- Paid by deleting the former 资源纪律 item 5 「⛔ 永不按进程名杀(`pkill -f`
…);记下你启动的 PID,只对它操作。」, which restates AGENTS.md › Multi-agent working
discipline §8 word for word and is hook-enforced by
`.claude/hooks/guard-process-kill.sh`; os-dev.md's own charter (L21)
keeps only clauses a hook cannot enforce. Items 6 and 7 renumber to 5
and 6; nothing references them by number. 405 lines before and after,
ceiling 405.
**`.claude/skills/pm-dispatch/references/execution-duties.md`** (one
home per rule)
- L180 no longer restates the confirmation ("同 head 达档 PASS 或维护者原话")
beside the home; it points at `landing-operations.md` and says the
confirmation is the dispatching seat's own record. 188 lines before and
after.
**`.claude/skills/pm-dispatch/references/landing-operations.md`** — not
changed: it is the rule's home (L14–17) and already says ⛔ 不等维护者, ACCEPT
for a text-only diff, same-head at-tier PASS otherwise.
## Why
The rule existed only where the seat reads it. The two texts a dev and
the gate actually meet said "get it confirmed" with no confirmer, so
devs wrote "please confirm" to the maintainer in PR bodies and the seat
held the landings. The maintainer's 「changeset 改写确认都同意」 restates the
rule; this PR moves the wording, not the verdict.
## Tests
- `node scripts/check-empty-changeset.mjs --self-test` at `b297730a`: `✓
check-empty-changeset --self-test: 167 assertions over real temp git
repos (real scan() path)`, exit 0 (the D battery registers 14 cases
against its floor of 14).
- `node scripts/check-empty-changeset.mjs --base origin/main`: exit 0 on
this branch (it adds no changeset and changes none).
- No ablation: the diff changes refusal text and instruction text, which
the ablation rule excludes (配置、脚本、workflow、文档 ⛔ 不消融).
## Verification
Derived at `b297730a` with `node scripts/pm/dispatch-gates.mjs
--commands --repo objectstack-ai/objectstack` — 43 commands (17 direct
node, 26 pnpm); each run in the foreground with stdin from /dev/null,
its exit code landed on disk before any pipe, then reconciled: `✓
dispatch-gates --ran: 43 derived famil(ies) accounted for — 43 run, 0
NOT-MEASURED`. **All 43 exit 0 at `b297730a`.** The ran-list is at
`skills-seat-2/r2026-11-06/out/30271-gates-ran-b297730a.list` in the
project files.
Two readings from the first sweep at `a566bb6d`, both resolved before
the final sweep: `pnpm --filter @objectstack/lint run
check:doc-formula-expressions` exited 3 (prerequisite:
`@objectstack/formula` and `@objectstack/lint` not built in a fresh
worktree; built under the verify lock, rerun exit 0 — not a finding),
and `pnpm check:pm-skill-ratchet` exited 1 on the 120-byte line budget
(os-dev.md L300–301 at 129B/132B, execution-duties.md L180 at 138B;
shortened in `05ae6a85` and `b297730a`, rerun exit 0, every ceiling
still at headroom 0).
Not run locally, CI's own: `pnpm lint` (repo-wide eslint), `test:repo`,
the type-check lanes, the 8 whole-tree families and the 11
wide-population families the derivation names; the PR's check-runs are
the reading for those.
Families named only when a changeset exists (7): not applicable, this PR
carries `skip-changeset`.
<details>
<summary>The 43 derived commands with their exit codes at
b297730</summary>
- `node scripts/check-closing-keyword-parity.mjs :: exit 0`
- `node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0`
- `node scripts/check-comment-mask-corpus.mjs :: exit 0`
- `node scripts/check-declaration-mirrors.mjs :: exit 0`
- `node scripts/check-declaration-mirrors.mjs --self-test :: exit 0`
- `node scripts/check-empty-changeset.mjs --base origin/main :: exit 0`
- `node scripts/check-empty-changeset.mjs --self-test :: exit 0`
- `node scripts/check-self-test-wired.mjs :: exit 0`
- `node scripts/check-self-test-wired.mjs --self-test :: exit 0`
- `node scripts/check-self-test-workflow-commands.mjs :: exit 0`
- `node scripts/check-self-test-workflow-commands.mjs --self-test ::
exit 0`
- `node scripts/check-whole-set-label-write.mjs :: exit 0`
- `node scripts/check-whole-set-label-write.mjs --self-test :: exit 0`
- `node scripts/ci/plan-test-core-shards.mjs --self-test :: exit 0`
- `node scripts/pm/bare-root-worklist.mjs --self-test :: exit 0`
- `node scripts/pm/check-governed-queue-guard.mjs --self-test :: exit 0`
- `node scripts/pm/check-harness-current.mjs --self-test :: exit 0`
- `pnpm --filter @objectstack/lint run check:doc-formula-expressions ::
exit 0`
- `pnpm check:agent-model-declared :: exit 0`
- `pnpm check:agent-test-spelling :: exit 0`
- `pnpm check:bash32-floor :: exit 0`
- `pnpm check:changeset-gate-self-tests :: exit 0`
- `pnpm check:ci-filter-parity :: exit 0`
- `pnpm check:cli-command-ids :: exit 0`
- `pnpm check:commit-card-trailers :: exit 0`
- `pnpm check:cross-package-test-inputs :: exit 0`
- `pnpm check:doc-authoring :: exit 0`
- `pnpm check:driver-memory-census :: exit 0`
- `pnpm check:entry-guard :: exit 0`
- `pnpm check:gitlink-declared :: exit 0`
- `pnpm check:nul-bytes :: exit 0`
- `pnpm check:parse-guard :: exit 0`
- `pnpm check:pm-dispatch-gates :: exit 0`
- `pnpm check:pm-governed-merges :: exit 0`
- `pnpm check:pm-skill-id-lint :: exit 0`
- `pnpm check:pm-skill-ratchet :: exit 0`
- `pnpm check:pnpm-filter-targets :: exit 0`
- `pnpm check:pnpm-flag-spellings :: exit 0`
- `pnpm check:ratchet-remedy-authority :: exit 0`
- `pnpm check:refd-timer-probe :: exit 0`
- `pnpm check:scripts-symbol-anchors :: exit 0`
- `pnpm check:skill-frame-sync :: exit 0`
- `pnpm check:watch-hint-literal :: exit 0`
</details>
## Acceptance notes
- **Card item 3 (security-fix PR bodies never narrate pre-fix behaviour)
is deferred from this push on the seat's instruction.** Its home is
`references/security-findings.md` §6, and seat 1's #30114 (branch
`claude/project-thread-shi9ig`) rewrites the very line this edit would
delete to pay for the addition and adds a §6 line of its own. Plan
agreed with the seat: once #30114 merges, merge `origin/main` here and
add the §6 line, paid by a deletion #30114 left alone, as its own commit
on this PR. The exact line and payment were named to the seat before any
edit.
- **Residue, outside this card's surface (workflows):**
`.github/workflows/pr-automation.yml` route 0 (the "This PR adds no
changeset" message, near L727) still says "get it confirmed there in
writing" and "the approver merges over it" without naming the confirmer.
Left as is per the seat; a workflow edit is Tier H and not this card.
- `skip-changeset`: the root package is `private: true` and `.claude/**`
is on the no-publish fast track, so this PR releases nothing; the label
is declared in the `pr_create` action.
- The relay's `pr_create` carries no assignee and no reviewer by design;
the harness's assignee/reviewer step is skipped (no GitHub MCP write
tools were used).
## Human Minimum
- [x] 1. Schemas start as Zod; `packages/spec` holds no runtime logic.
(No schema touched.)
- [x] 2. Every name I added uses the casing for its kind. (No new
identifier.)
- [x] 3. No formatter ran; `pnpm lint` is CI's run.
- [x] 4. One issue, one branch off an up-to-date `main`, one pull
request.
- [x] 5. A change that publishes carries a changeset — this one
publishes nothing (`skip-changeset`); both declaration lines are at the
top.
- [x] 6. `packages/spec` not touched.
- [x] 7. No hand edits to `content/docs/references/`,
`packages/*/CHANGELOG.md` or `content/docs/releases/`.
- [x] 8. Title, body and comments are in English (the 维护者速读 block is the
repo's own Chinese form).
- [x] The *Before Submitting* list in CONTRIBUTING.md is done.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01L9qibxpHybSfTtRNdGnUZZ)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent ebe0a98 commit 1b3e22f
4 files changed
Lines changed: 35 additions & 14 deletions
File tree
- .claude
- agents
- skills/pm-dispatch/references
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
101 | | - | |
| 100 | + | |
102 | 101 | | |
103 | 102 | | |
104 | 103 | | |
105 | 104 | | |
106 | | - | |
| 105 | + | |
107 | 106 | | |
108 | 107 | | |
109 | 108 | | |
| |||
298 | 297 | | |
299 | 298 | | |
300 | 299 | | |
301 | | - | |
| 300 | + | |
| 301 | + | |
302 | 302 | | |
303 | 303 | | |
304 | 304 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| |||
547 | 547 | | |
548 | 548 | | |
549 | 549 | | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
550 | 558 | | |
551 | | - | |
| 559 | + | |
| 560 | + | |
552 | 561 | | |
553 | 562 | | |
554 | 563 | | |
| |||
606 | 615 | | |
607 | 616 | | |
608 | 617 | | |
609 | | - | |
610 | | - | |
611 | | - | |
612 | | - | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
613 | 625 | | |
614 | 626 | | |
615 | 627 | | |
| |||
688 | 700 | | |
689 | 701 | | |
690 | 702 | | |
691 | | - | |
| 703 | + | |
692 | 704 | | |
693 | 705 | | |
694 | 706 | | |
| |||
1454 | 1466 | | |
1455 | 1467 | | |
1456 | 1468 | | |
1457 | | - | |
| 1469 | + | |
1458 | 1470 | | |
1459 | 1471 | | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
1460 | 1481 | | |
1461 | 1482 | | |
1462 | 1483 | | |
| |||
0 commit comments